Skip to content

Correct declaration and comments re size of rej-uniform lookup table#1657

Merged
hanno-becker merged 1 commit intomainfrom
fix-rej-uniform-table-size
Apr 21, 2026
Merged

Correct declaration and comments re size of rej-uniform lookup table#1657
hanno-becker merged 1 commit intomainfrom
fix-rej-uniform-table-size

Conversation

@rod-chapman
Copy link
Copy Markdown
Contributor

Review of the AArch64 back-end shows that comments pertaining to the size of the rej_uniform lookup were are incorrect in a number of places. The table is 256 * 16 bytes, so 4096 bytes, NOT 2048 bytes as appears in the comments.

Signed-off-by: Rod Chapman <rodchap@amazon.com>
@rod-chapman rod-chapman self-assigned this Apr 20, 2026
@rod-chapman rod-chapman requested a review from a team as a code owner April 20, 2026 16:46
@rod-chapman rod-chapman added the documentation Improvements or additions to documentation label Apr 20, 2026
@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Apr 20, 2026

CBMC Results (ML-KEM-1024)

Full Results (191 proofs)
Proof Status Current Previous Change
**TOTAL** 1174s 1296s -9.4%
mlk_indcpa_enc 142s 146s -3%
mlk_indcpa_keypair_derand 122s 134s -9%
mlk_rej_uniform_c 118s 144s -18%
mlk_polyvec_basemul_acc_montgomery_cached_c 76s 84s -10%
polyvec_basemul_acc_montgomery_cached_native 35s 37s -5%
mlk_poly_rej_uniform 31s 32s -3%
mlk_ntt_layer 30s 37s -19%
mlk_keccak_squeezeblocks_x4 25s 25s +0%
poly_ntt_native 23s 31s -26%
mlk_poly_reduce_native 21s 22s -5%
mlk_fqmul 18s 17s +6%
keccakf1600x4_permute_native_x4 16s 19s -16%
mlk_poly_decompress_d11_native 14s 14s +0%
mlk_poly_decompress_d5_native 11s 16s -31%
mlk_indcpa_dec 10s 10s +0%
mlk_polyvec_add 10s 12s -17%
mlk_keccak_squeeze_once 9s 7s +29%
mlk_keccak_squeezeblocks 8s 10s -20%
mlk_poly_frombytes_native 8s 12s -33%
mlk_ntt_butterfly_block 7s 9s -22%
kem_dec 6s 7s -14%
mlk_ct_cmask_nonzero_u8 6s 1s +500%
mlk_keccak_absorb_once_x4 6s 7s -14%
mlk_poly_compress_d11_c 6s 5s +20%
mlk_poly_frommsg 6s 11s -45%
mlk_poly_ntt 6s 8s -25%
mlk_poly_rej_uniform_x4 6s 6s +0%
mlk_gen_matrix 5s 5s +0%
mlk_gen_matrix_serial 5s 3s +67%
mlk_invntt_layer 5s 6s -17%
mlk_keccakf1600_permute_c 5s 6s -17%
mlk_keypair_getnoise_eta1 5s 4s +25%
poly_decompress_d5_native_x86_64 5s 6s -17%
poly_frombytes_native_x86_64 5s 5s +0%
poly_mulcache_compute_native_x86_64 5s 2s +150%
keccak_f1600_x1_native_aarch64 4s 2s +100%
keccakf1600x4_xor_bytes_native 4s 2s +100%
mlk_ct_get_optblocker_u32 4s 1s +300%
mlk_ct_memcmp 4s 5s -20%
mlk_poly_add 4s 5s -20%
mlk_poly_reduce 4s 1s +300%
mlk_poly_tobytes_c 4s 3s +33%
mlk_polymat_permute_bitrev_to_custom 4s 6s -33%
mlk_polyvec_compress_du 4s 2s +100%
mlk_polyvec_ntt 4s 3s +33%
mlk_shake256 4s 2s +100%
poly_compress_d4_native_x86_64 4s 1s +300%
poly_decompress_d11_native_x86_64 4s 3s +33%
poly_tomont_native_aarch64 4s 3s +33%
poly_tomont_native_x86_64 4s 2s +100%
polyvec_basemul_acc_montgomery_cached_k3_native_aarch64 4s 1s +300%
rej_uniform_native_x86_64 4s 5s -20%
intt_native_aarch64 3s 2s +50%
keccak_f1600_x4_native_aarch64_v84a 3s 2s +50%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 3s 2s +50%
kem_check_pk 3s 3s +0%
kem_check_sk 3s 2s +50%
kem_enc 3s 3s +0%
kem_keypair 3s 4s -25%
kem_keypair_derand 3s 1s +200%
mlk_ct_cmov_zero 3s 2s +50%
mlk_ct_get_optblocker_u8 3s 2s +50%
mlk_enc_getnoise_eta1_eta2 3s 4s -25%
mlk_keccak_absorb_once 3s 4s -25%
mlk_keccakf1600_permute 3s 2s +50%
mlk_keccakf1600_xor_bytes (big endian) 3s 3s +0%
mlk_keccakf1600x4_xor_bytes 3s 2s +50%
mlk_keccakf1600x4_xor_bytes_c 3s 3s +0%
mlk_matvec_mul 3s 4s -25%
mlk_poly_cbd_eta1 3s 3s +0%
mlk_poly_compress_d11_native 3s 3s +0%
mlk_poly_compress_d4 3s 1s +200%
mlk_poly_compress_d4_c 3s 2s +50%
mlk_poly_compress_d5 3s 4s -25%
mlk_poly_decompress_d11_c 3s 3s +0%
mlk_poly_decompress_d4_c 3s 3s +0%
mlk_poly_decompress_d4_native 3s 2s +50%
mlk_poly_decompress_dv 3s 2s +50%
mlk_poly_getnoise_eta1_4x_native 3s 3s +0%
mlk_poly_invntt_tomont_c 3s 2s +50%
mlk_poly_mulcache_compute 3s 2s +50%
mlk_poly_mulcache_compute_c 3s 2s +50%
mlk_poly_ntt_c 3s 3s +0%
mlk_poly_reduce_c 3s 5s -40%
mlk_poly_tobytes_native 3s 2s +50%
mlk_scalar_compress_d5 3s 5s -40%
mlk_scalar_signed_to_unsigned_q 3s 1s +200%
mlk_sha3_256 3s 2s +50%
mlk_sha3_512 3s 2s +50%
mlk_value_barrier_u8 3s 2s +50%
poly_compress_d10_native_x86_64 3s 2s +50%
poly_decompress_d10_native_x86_64 3s 2s +50%
polyvec_basemul_acc_montgomery_cached_k4_native_aarch64 3s 3s +0%
rej_uniform_native_aarch64 3s 2s +50%
sys_check_capability 3s 1s +200%
intt_native_x86_64 2s 5s -60%
keccak_f1600_x1_native_aarch64_v84a 2s 3s -33%
keccakf1600_permute_native 2s 2s +0%
keccakf1600x4_extract_bytes_native 2s 3s -33%
mlk_ct_cmask_neg_i16 2s 3s -33%
mlk_ct_cmask_nonzero_u16 2s 3s -33%
mlk_ct_sel_int16 2s 5s -60%
mlk_keccakf1600_xor_bytes 2s 1s +100%
mlk_keccakf1600x4_extract_bytes 2s 1s +100%
mlk_keccakf1600x4_extract_bytes_c 2s 1s +100%
mlk_keccakf1600x4_permute 2s 1s +100%
mlk_montgomery_reduce 2s 2s +0%
mlk_poly_cbd_eta2 2s 2s +0%
mlk_poly_compress_d10 2s 3s -33%
mlk_poly_compress_d10_native 2s 2s +0%
mlk_poly_compress_d11 2s 2s +0%
mlk_poly_compress_d4_native 2s 2s +0%
mlk_poly_compress_d5_c 2s 4s -50%
mlk_poly_compress_d5_native 2s 1s +100%
mlk_poly_compress_du 2s 3s -33%
mlk_poly_compress_dv 2s 1s +100%
mlk_poly_decompress_d10 2s 2s +0%
mlk_poly_decompress_d10_c 2s 3s -33%
mlk_poly_decompress_d10_native 2s 3s -33%
mlk_poly_decompress_d11 2s 2s +0%
mlk_poly_decompress_d4 2s 3s -33%
mlk_poly_decompress_d5 2s 2s +0%
mlk_poly_decompress_d5_c 2s 3s -33%
mlk_poly_decompress_du 2s 3s -33%
mlk_poly_frombytes 2s 2s +0%
mlk_poly_frombytes_c 2s 1s +100%
mlk_poly_getnoise_eta1122_4x 2s 2s +0%
mlk_poly_getnoise_eta1_4x 2s 4s -50%
mlk_poly_invntt_tomont 2s 2s +0%
mlk_poly_sub 2s 3s -33%
mlk_poly_tobytes 2s 1s +100%
mlk_poly_tomont 2s 2s +0%
mlk_poly_tomont_c 2s 2s +0%
mlk_polyvec_basemul_acc_montgomery_cached 2s 2s +0%
mlk_polyvec_decompress_du 2s 4s -50%
mlk_polyvec_invntt_tomont 2s 3s -33%
mlk_polyvec_reduce 2s 4s -50%
mlk_polyvec_tomont 2s 3s -33%
mlk_scalar_compress_d1 2s 3s -33%
mlk_scalar_compress_d10 2s 2s +0%
mlk_scalar_compress_d11 2s 2s +0%
mlk_scalar_compress_d4 2s 4s -50%
mlk_scalar_decompress_d10 2s 3s -33%
mlk_scalar_decompress_d11 2s 3s -33%
mlk_scalar_decompress_d5 2s 3s -33%
mlk_shake128_absorb_once 2s 2s +0%
mlk_shake128_squeezeblocks 2s 1s +100%
mlk_shake128x4_squeezeblocks 2s 1s +100%
mlk_shake256x4 2s 4s -50%
mlk_value_barrier_u32 2s 2s +0%
ntt_native_aarch64 2s 3s -33%
poly_decompress_d4_native_x86_64 2s 1s +100%
poly_getnoise_eta1122_4x_native 2s 2s +0%
poly_reduce_native_x86_64 2s 1s +100%
poly_tobytes_native_aarch64 2s 2s +0%
polyvec_basemul_acc_montgomery_cached_k2_native_aarch64 2s 3s -33%
polyvec_basemul_acc_montgomery_cached_k2_native_x86_64 2s 3s -33%
polyvec_basemul_acc_montgomery_cached_k3_native_x86_64 2s 3s -33%
polyvec_basemul_acc_montgomery_cached_k4_native_x86_64 2s 2s +0%
rej_uniform_native 2s 1s +100%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 1s 2s -50%
keccak_f1600_x4_native_avx2 1s 3s -67%
kem_enc_derand 1s 2s -50%
mlk_barrett_reduce 1s 4s -75%
mlk_check_pct 1s 2s -50%
mlk_ct_get_optblocker_i32 1s 2s -50%
mlk_ct_sel_uint8 1s 3s -67%
mlk_keccakf1600_extract_bytes 1s 4s -75%
mlk_keccakf1600_extract_bytes (big endian) 1s 4s -75%
mlk_poly_compress_d10_c 1s 3s -67%
mlk_poly_getnoise_eta2 1s 4s -75%
mlk_poly_mulcache_compute_native 1s 3s -67%
mlk_poly_tomont_native 1s 2s -50%
mlk_poly_tomsg 1s 3s -67%
mlk_polyvec_frombytes 1s 2s -50%
mlk_polyvec_mulcache_compute 1s 2s -50%
mlk_polyvec_permute_bitrev_to_custom 1s 3s -67%
mlk_polyvec_permute_bitrev_to_custom_native 1s 3s -67%
mlk_polyvec_tobytes 1s 3s -67%
mlk_rej_uniform 1s 2s -50%
mlk_scalar_decompress_d4 1s 2s -50%
mlk_shake128x4_absorb_once 1s 1s +0%
mlk_value_barrier_i32 1s 3s -67%
ntt_native_x86_64 1s 2s -50%
nttunpack_native_x86_64 1s 3s -67%
poly_compress_d11_native_x86_64 1s 2s -50%
poly_compress_d5_native_x86_64 1s 2s -50%
poly_invntt_tomont_native 1s 3s -67%
poly_mulcache_compute_native_aarch64 1s 3s -67%
poly_reduce_native_aarch64 1s 3s -67%
poly_tobytes_native_x86_64 1s 3s -67%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Apr 20, 2026

CBMC Results (ML-KEM-768)

Full Results (191 proofs)
Proof Status Current Previous Change
**TOTAL** 1213s 1399s -13.3%
mlk_indcpa_keypair_derand 184s 221s -17%
mlk_indcpa_enc 168s 196s -14%
mlk_rej_uniform_c 115s 166s -31%
mlk_polyvec_basemul_acc_montgomery_cached_c 42s 49s -14%
mlk_ntt_layer 32s 41s -22%
mlk_poly_rej_uniform 28s 34s -18%
mlk_keccak_squeezeblocks_x4 25s 28s -11%
poly_ntt_native 23s 32s -28%
keccakf1600x4_permute_native_x4 20s 18s +11%
mlk_poly_reduce_native 20s 22s -9%
polyvec_basemul_acc_montgomery_cached_native 17s 19s -11%
mlk_fqmul 16s 18s -11%
mlk_indcpa_dec 15s 14s +7%
mlk_poly_decompress_d4_native 13s 17s -24%
mlk_poly_decompress_d10_native 12s 20s -40%
mlk_polyvec_add 12s 9s +33%
mlk_poly_frombytes_native 9s 10s -10%
mlk_keccak_squeeze_once 8s 8s +0%
mlk_keccak_squeezeblocks 8s 10s -20%
mlk_poly_frommsg 8s 12s -33%
mlk_ntt_butterfly_block 7s 9s -22%
mlk_keccak_absorb_once_x4 6s 7s -14%
mlk_poly_rej_uniform_x4 6s 9s -33%
mlk_invntt_layer 5s 5s +0%
mlk_poly_decompress_d10 5s 3s +67%
mlk_poly_ntt 5s 9s -44%
mlk_scalar_compress_d11 5s 2s +150%
poly_decompress_d10_native_x86_64 5s 6s -17%
poly_decompress_d4_native_x86_64 5s 7s -29%
poly_frombytes_native_x86_64 5s 8s -38%
rej_uniform_native 5s 2s +150%
intt_native_aarch64 4s 1s +300%
intt_native_x86_64 4s 3s +33%
keccak_f1600_x1_native_aarch64 4s 2s +100%
kem_check_pk 4s 4s +0%
kem_dec 4s 4s +0%
mlk_gen_matrix_serial 4s 2s +100%
mlk_keccakf1600_permute_c 4s 6s -33%
mlk_keccakf1600x4_xor_bytes 4s 1s +300%
mlk_poly_decompress_dv 4s 3s +33%
mlk_poly_ntt_c 4s 6s -33%
mlk_poly_tobytes 4s 3s +33%
mlk_poly_tobytes_native 4s 3s +33%
mlk_polyvec_invntt_tomont 4s 2s +100%
mlk_scalar_decompress_d11 4s 3s +33%
mlk_shake128_absorb_once 4s 3s +33%
ntt_native_aarch64 4s 2s +100%
poly_compress_d10_native_x86_64 4s 1s +300%
poly_getnoise_eta1122_4x_native 4s 2s +100%
keccak_f1600_x4_native_avx2 3s 2s +50%
keccakf1600x4_extract_bytes_native 3s 2s +50%
kem_enc 3s 2s +50%
mlk_barrett_reduce 3s 3s +0%
mlk_ct_sel_int16 3s 5s -40%
mlk_gen_matrix 3s 3s +0%
mlk_keccak_absorb_once 3s 3s +0%
mlk_keccakf1600_xor_bytes 3s 2s +50%
mlk_matvec_mul 3s 3s +0%
mlk_montgomery_reduce 3s 1s +200%
mlk_poly_cbd_eta1 3s 3s +0%
mlk_poly_compress_d10 3s 2s +50%
mlk_poly_compress_d11 3s 2s +50%
mlk_poly_compress_d11_native 3s 3s +0%
mlk_poly_compress_d4_native 3s 2s +50%
mlk_poly_compress_d5 3s 2s +50%
mlk_poly_decompress_d10_c 3s 1s +200%
mlk_poly_decompress_d11_native 3s 1s +200%
mlk_poly_decompress_d4 3s 2s +50%
mlk_poly_decompress_d4_c 3s 2s +50%
mlk_poly_decompress_d5 3s 2s +50%
mlk_poly_decompress_d5_c 3s 3s +0%
mlk_poly_decompress_d5_native 3s 4s -25%
mlk_poly_decompress_du 3s 3s +0%
mlk_poly_getnoise_eta1122_4x 3s 2s +50%
mlk_poly_getnoise_eta1_4x_native 3s 1s +200%
mlk_poly_getnoise_eta2 3s 2s +50%
mlk_poly_invntt_tomont_c 3s 1s +200%
mlk_poly_mulcache_compute_c 3s 3s +0%
mlk_poly_tomont_c 3s 2s +50%
mlk_poly_tomsg 3s 3s +0%
mlk_polymat_permute_bitrev_to_custom 3s 6s -50%
mlk_polyvec_decompress_du 3s 2s +50%
mlk_polyvec_ntt 3s 2s +50%
mlk_polyvec_permute_bitrev_to_custom_native 3s 1s +200%
mlk_polyvec_tobytes 3s 3s +0%
mlk_rej_uniform 3s 2s +50%
mlk_scalar_compress_d1 3s 1s +200%
mlk_scalar_compress_d5 3s 2s +50%
mlk_sha3_256 3s 2s +50%
mlk_sha3_512 3s 3s +0%
mlk_shake256x4 3s 3s +0%
nttunpack_native_x86_64 3s 1s +200%
poly_compress_d4_native_x86_64 3s 2s +50%
poly_decompress_d11_native_x86_64 3s 3s +0%
poly_tobytes_native_aarch64 3s 2s +50%
poly_tomont_native_x86_64 3s 2s +50%
polyvec_basemul_acc_montgomery_cached_k2_native_x86_64 3s 2s +50%
polyvec_basemul_acc_montgomery_cached_k4_native_aarch64 3s 2s +50%
polyvec_basemul_acc_montgomery_cached_k4_native_x86_64 3s 1s +200%
rej_uniform_native_aarch64 3s 1s +200%
sys_check_capability 3s 1s +200%
keccak_f1600_x1_native_aarch64_v84a 2s 3s -33%
keccak_f1600_x4_native_aarch64_v84a 2s 3s -33%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 2s 4s -50%
keccakf1600x4_xor_bytes_native 2s 2s +0%
kem_enc_derand 2s 2s +0%
kem_keypair 2s 4s -50%
kem_keypair_derand 2s 4s -50%
mlk_check_pct 2s 4s -50%
mlk_ct_cmask_neg_i16 2s 2s +0%
mlk_ct_cmov_zero 2s 2s +0%
mlk_ct_get_optblocker_i32 2s 2s +0%
mlk_ct_get_optblocker_u8 2s 1s +100%
mlk_ct_memcmp 2s 2s +0%
mlk_enc_getnoise_eta1_eta2 2s 1s +100%
mlk_keccakf1600_extract_bytes 2s 3s -33%
mlk_keccakf1600_extract_bytes (big endian) 2s 3s -33%
mlk_keccakf1600_permute 2s 1s +100%
mlk_keccakf1600_xor_bytes (big endian) 2s 3s -33%
mlk_keccakf1600x4_extract_bytes 2s 5s -60%
mlk_keccakf1600x4_extract_bytes_c 2s 2s +0%
mlk_keypair_getnoise_eta1 2s 1s +100%
mlk_poly_cbd_eta2 2s 3s -33%
mlk_poly_compress_d10_c 2s 3s -33%
mlk_poly_compress_d10_native 2s 2s +0%
mlk_poly_compress_d11_c 2s 2s +0%
mlk_poly_compress_d4_c 2s 2s +0%
mlk_poly_compress_d5_native 2s 4s -50%
mlk_poly_compress_du 2s 4s -50%
mlk_poly_compress_dv 2s 2s +0%
mlk_poly_decompress_d11_c 2s 2s +0%
mlk_poly_frombytes_c 2s 1s +100%
mlk_poly_getnoise_eta1_4x 2s 2s +0%
mlk_poly_invntt_tomont 2s 2s +0%
mlk_poly_reduce 2s 2s +0%
mlk_poly_reduce_c 2s 4s -50%
mlk_poly_sub 2s 1s +100%
mlk_poly_tobytes_c 2s 1s +100%
mlk_poly_tomont_native 2s 3s -33%
mlk_polyvec_basemul_acc_montgomery_cached 2s 1s +100%
mlk_polyvec_compress_du 2s 3s -33%
mlk_polyvec_tomont 2s 2s +0%
mlk_scalar_compress_d10 2s 1s +100%
mlk_scalar_decompress_d10 2s 4s -50%
mlk_scalar_decompress_d5 2s 2s +0%
mlk_scalar_signed_to_unsigned_q 2s 2s +0%
mlk_shake128x4_absorb_once 2s 2s +0%
mlk_shake128x4_squeezeblocks 2s 1s +100%
mlk_shake256 2s 4s -50%
mlk_value_barrier_u32 2s 1s +100%
mlk_value_barrier_u8 2s 4s -50%
ntt_native_x86_64 2s 3s -33%
poly_compress_d5_native_x86_64 2s 3s -33%
poly_decompress_d5_native_x86_64 2s 2s +0%
poly_mulcache_compute_native_aarch64 2s 1s +100%
poly_reduce_native_x86_64 2s 5s -60%
poly_tobytes_native_x86_64 2s 3s -33%
poly_tomont_native_aarch64 2s 2s +0%
polyvec_basemul_acc_montgomery_cached_k2_native_aarch64 2s 2s +0%
polyvec_basemul_acc_montgomery_cached_k3_native_aarch64 2s 4s -50%
polyvec_basemul_acc_montgomery_cached_k3_native_x86_64 2s 4s -50%
rej_uniform_native_x86_64 2s 3s -33%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 1s 2s -50%
keccakf1600_permute_native 1s 3s -67%
kem_check_sk 1s 1s +0%
mlk_ct_cmask_nonzero_u16 1s 2s -50%
mlk_ct_cmask_nonzero_u8 1s 3s -67%
mlk_ct_get_optblocker_u32 1s 3s -67%
mlk_ct_sel_uint8 1s 2s -50%
mlk_keccakf1600x4_permute 1s 2s -50%
mlk_keccakf1600x4_xor_bytes_c 1s 2s -50%
mlk_poly_add 1s 3s -67%
mlk_poly_compress_d4 1s 3s -67%
mlk_poly_compress_d5_c 1s 4s -75%
mlk_poly_decompress_d11 1s 2s -50%
mlk_poly_frombytes 1s 2s -50%
mlk_poly_mulcache_compute 1s 4s -75%
mlk_poly_mulcache_compute_native 1s 2s -50%
mlk_poly_tomont 1s 3s -67%
mlk_polyvec_frombytes 1s 3s -67%
mlk_polyvec_mulcache_compute 1s 3s -67%
mlk_polyvec_permute_bitrev_to_custom 1s 2s -50%
mlk_polyvec_reduce 1s 2s -50%
mlk_scalar_compress_d4 1s 1s +0%
mlk_scalar_decompress_d4 1s 1s +0%
mlk_shake128_squeezeblocks 1s 2s -50%
mlk_value_barrier_i32 1s 2s -50%
poly_compress_d11_native_x86_64 1s 1s +0%
poly_invntt_tomont_native 1s 4s -75%
poly_mulcache_compute_native_x86_64 1s 2s -50%
poly_reduce_native_aarch64 1s 2s -50%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Apr 20, 2026

CBMC Results (ML-KEM-512)

Full Results (191 proofs)
Proof Status Current Previous Change
**TOTAL** 1372s 1256s +9.2%
mlk_indcpa_keypair_derand 253s 243s +4%
mlk_indcpa_enc 179s 160s +12%
mlk_rej_uniform_c 136s 110s +24%
mlk_polyvec_basemul_acc_montgomery_cached_c 61s 51s +20%
mlk_ntt_layer 40s 28s +43%
mlk_poly_rej_uniform 29s 28s +4%
poly_ntt_native 29s 23s +26%
mlk_keccak_squeezeblocks_x4 25s 24s +4%
mlk_poly_reduce_native 22s 20s +10%
keccakf1600x4_permute_native_x4 17s 18s -6%
mlk_fqmul 16s 16s +0%
mlk_poly_decompress_d4_native 16s 13s +23%
mlk_indcpa_dec 14s 13s +8%
mlk_poly_decompress_d10_native 14s 12s +17%
mlk_poly_frommsg 11s 8s +38%
mlk_poly_frombytes_native 10s 6s +67%
mlk_polyvec_add 10s 10s +0%
mlk_keccak_squeeze_once 9s 7s +29%
mlk_keccak_squeezeblocks 8s 8s +0%
mlk_poly_ntt 8s 7s +14%
mlk_poly_rej_uniform_x4 7s 7s +0%
polyvec_basemul_acc_montgomery_cached_native 7s 6s +17%
mlk_invntt_layer 6s 7s -14%
mlk_keccak_absorb_once_x4 6s 5s +20%
mlk_ntt_butterfly_block 6s 9s -33%
mlk_poly_cbd_eta2 6s 5s +20%
kem_dec 5s 5s +0%
mlk_keccak_absorb_once 5s 4s +25%
mlk_keccakf1600_permute_c 5s 6s -17%
mlk_poly_compress_d5 5s 3s +67%
mlk_polyvec_mulcache_compute 5s 3s +67%
mlk_shake128_squeezeblocks 5s 1s +400%
mlk_shake256x4 5s 4s +25%
poly_decompress_d10_native_x86_64 5s 4s +25%
poly_invntt_tomont_native 5s 3s +67%
keccak_f1600_x4_native_aarch64_v84a 4s 3s +33%
kem_check_sk 4s 2s +100%
kem_enc 4s 2s +100%
kem_enc_derand 4s 2s +100%
kem_keypair 4s 1s +300%
mlk_poly_frombytes_c 4s 1s +300%
mlk_poly_getnoise_eta1_4x 4s 2s +100%
mlk_poly_getnoise_eta2 4s 3s +33%
mlk_poly_invntt_tomont 4s 4s +0%
mlk_poly_invntt_tomont_c 4s 4s +0%
mlk_poly_tomont 4s 3s +33%
mlk_shake256 4s 1s +300%
poly_compress_d5_native_x86_64 4s 1s +300%
poly_frombytes_native_x86_64 4s 5s -20%
poly_mulcache_compute_native_x86_64 4s 2s +100%
intt_native_x86_64 3s 3s +0%
keccakf1600_permute_native 3s 3s +0%
keccakf1600x4_extract_bytes_native 3s 4s -25%
keccakf1600x4_xor_bytes_native 3s 1s +200%
kem_check_pk 3s 4s -25%
mlk_barrett_reduce 3s 3s +0%
mlk_ct_cmask_neg_i16 3s 2s +50%
mlk_ct_get_optblocker_i32 3s 2s +50%
mlk_ct_sel_int16 3s 1s +200%
mlk_enc_getnoise_eta1_eta2 3s 3s +0%
mlk_gen_matrix 3s 4s -25%
mlk_keccakf1600_permute 3s 2s +50%
mlk_keccakf1600x4_extract_bytes_c 3s 3s +0%
mlk_keccakf1600x4_xor_bytes 3s 4s -25%
mlk_keccakf1600x4_xor_bytes_c 3s 2s +50%
mlk_keypair_getnoise_eta1 3s 3s +0%
mlk_poly_compress_d10_c 3s 4s -25%
mlk_poly_compress_d11 3s 1s +200%
mlk_poly_compress_d4 3s 2s +50%
mlk_poly_compress_d4_c 3s 2s +50%
mlk_poly_compress_d5_native 3s 2s +50%
mlk_poly_decompress_d11_native 3s 4s -25%
mlk_poly_decompress_d4 3s 1s +200%
mlk_poly_frombytes 3s 3s +0%
mlk_poly_getnoise_eta1122_4x 3s 2s +50%
mlk_poly_mulcache_compute_c 3s 1s +200%
mlk_poly_ntt_c 3s 2s +50%
mlk_poly_reduce_c 3s 1s +200%
mlk_poly_tobytes 3s 4s -25%
mlk_poly_tomsg 3s 4s -25%
mlk_polyvec_basemul_acc_montgomery_cached 3s 2s +50%
mlk_polyvec_decompress_du 3s 3s +0%
mlk_polyvec_frombytes 3s 2s +50%
mlk_polyvec_invntt_tomont 3s 2s +50%
mlk_polyvec_ntt 3s 4s -25%
mlk_polyvec_permute_bitrev_to_custom_native 3s 2s +50%
mlk_rej_uniform 3s 2s +50%
mlk_scalar_compress_d1 3s 2s +50%
mlk_scalar_compress_d10 3s 1s +200%
mlk_scalar_compress_d11 3s 1s +200%
mlk_scalar_compress_d4 3s 3s +0%
mlk_scalar_compress_d5 3s 3s +0%
mlk_scalar_decompress_d10 3s 4s -25%
mlk_scalar_decompress_d11 3s 2s +50%
mlk_value_barrier_i32 3s 4s -25%
mlk_value_barrier_u32 3s 2s +50%
ntt_native_aarch64 3s 2s +50%
poly_compress_d10_native_x86_64 3s 2s +50%
poly_compress_d4_native_x86_64 3s 3s +0%
poly_decompress_d4_native_x86_64 3s 5s -40%
poly_mulcache_compute_native_aarch64 3s 4s -25%
poly_reduce_native_aarch64 3s 1s +200%
poly_tomont_native_x86_64 3s 2s +50%
polyvec_basemul_acc_montgomery_cached_k2_native_aarch64 3s 3s +0%
polyvec_basemul_acc_montgomery_cached_k3_native_aarch64 3s 3s +0%
polyvec_basemul_acc_montgomery_cached_k3_native_x86_64 3s 3s +0%
rej_uniform_native 3s 2s +50%
rej_uniform_native_x86_64 3s 2s +50%
intt_native_aarch64 2s 4s -50%
keccak_f1600_x1_native_aarch64 2s 1s +100%
keccak_f1600_x1_native_aarch64_v84a 2s 2s +0%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 2s 3s -33%
keccak_f1600_x4_native_avx2 2s 2s +0%
mlk_ct_cmask_nonzero_u16 2s 3s -33%
mlk_ct_cmov_zero 2s 2s +0%
mlk_ct_get_optblocker_u32 2s 1s +100%
mlk_ct_get_optblocker_u8 2s 2s +0%
mlk_ct_memcmp 2s 1s +100%
mlk_ct_sel_uint8 2s 2s +0%
mlk_gen_matrix_serial 2s 3s -33%
mlk_keccakf1600_extract_bytes 2s 4s -50%
mlk_keccakf1600_xor_bytes (big endian) 2s 2s +0%
mlk_keccakf1600x4_extract_bytes 2s 1s +100%
mlk_keccakf1600x4_permute 2s 2s +0%
mlk_matvec_mul 2s 2s +0%
mlk_poly_add 2s 2s +0%
mlk_poly_cbd_eta1 2s 3s -33%
mlk_poly_compress_d10 2s 3s -33%
mlk_poly_compress_d10_native 2s 3s -33%
mlk_poly_compress_d11_c 2s 3s -33%
mlk_poly_compress_d11_native 2s 2s +0%
mlk_poly_compress_d4_native 2s 3s -33%
mlk_poly_compress_d5_c 2s 2s +0%
mlk_poly_compress_du 2s 1s +100%
mlk_poly_compress_dv 2s 2s +0%
mlk_poly_decompress_d10 2s 3s -33%
mlk_poly_decompress_d11 2s 3s -33%
mlk_poly_decompress_d11_c 2s 1s +100%
mlk_poly_decompress_d4_c 2s 3s -33%
mlk_poly_decompress_d5_c 2s 2s +0%
mlk_poly_decompress_d5_native 2s 3s -33%
mlk_poly_decompress_dv 2s 2s +0%
mlk_poly_getnoise_eta1_4x_native 2s 2s +0%
mlk_poly_mulcache_compute 2s 2s +0%
mlk_poly_mulcache_compute_native 2s 5s -60%
mlk_poly_reduce 2s 2s +0%
mlk_poly_sub 2s 2s +0%
mlk_poly_tobytes_native 2s 1s +100%
mlk_poly_tomont_c 2s 3s -33%
mlk_poly_tomont_native 2s 3s -33%
mlk_polymat_permute_bitrev_to_custom 2s 2s +0%
mlk_polyvec_compress_du 2s 3s -33%
mlk_polyvec_permute_bitrev_to_custom 2s 2s +0%
mlk_polyvec_reduce 2s 1s +100%
mlk_polyvec_tobytes 2s 2s +0%
mlk_scalar_signed_to_unsigned_q 2s 3s -33%
mlk_sha3_512 2s 3s -33%
mlk_shake128_absorb_once 2s 2s +0%
mlk_value_barrier_u8 2s 4s -50%
ntt_native_x86_64 2s 2s +0%
nttunpack_native_x86_64 2s 2s +0%
poly_decompress_d11_native_x86_64 2s 3s -33%
poly_decompress_d5_native_x86_64 2s 1s +100%
poly_getnoise_eta1122_4x_native 2s 2s +0%
poly_reduce_native_x86_64 2s 3s -33%
poly_tobytes_native_aarch64 2s 3s -33%
poly_tobytes_native_x86_64 2s 4s -50%
poly_tomont_native_aarch64 2s 1s +100%
polyvec_basemul_acc_montgomery_cached_k2_native_x86_64 2s 2s +0%
polyvec_basemul_acc_montgomery_cached_k4_native_aarch64 2s 2s +0%
polyvec_basemul_acc_montgomery_cached_k4_native_x86_64 2s 3s -33%
rej_uniform_native_aarch64 2s 4s -50%
sys_check_capability 2s 1s +100%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 1s 2s -50%
kem_keypair_derand 1s 2s -50%
mlk_check_pct 1s 5s -80%
mlk_ct_cmask_nonzero_u8 1s 3s -67%
mlk_keccakf1600_extract_bytes (big endian) 1s 2s -50%
mlk_keccakf1600_xor_bytes 1s 2s -50%
mlk_montgomery_reduce 1s 2s -50%
mlk_poly_decompress_d10_c 1s 3s -67%
mlk_poly_decompress_d5 1s 2s -50%
mlk_poly_decompress_du 1s 4s -75%
mlk_poly_tobytes_c 1s 2s -50%
mlk_polyvec_tomont 1s 1s +0%
mlk_scalar_decompress_d4 1s 1s +0%
mlk_scalar_decompress_d5 1s 2s -50%
mlk_sha3_256 1s 2s -50%
mlk_shake128x4_absorb_once 1s 3s -67%
mlk_shake128x4_squeezeblocks 1s 3s -67%
poly_compress_d11_native_x86_64 1s 1s +0%

Copy link
Copy Markdown
Contributor

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rod-chapman !

@hanno-becker hanno-becker merged commit fb886a2 into main Apr 21, 2026
431 checks passed
@hanno-becker hanno-becker deleted the fix-rej-uniform-table-size branch April 21, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants