Correct declaration and comments re size of rej-uniform lookup table#1657
Merged
hanno-becker merged 1 commit intomainfrom Apr 21, 2026
Merged
Correct declaration and comments re size of rej-uniform lookup table#1657hanno-becker merged 1 commit intomainfrom
hanno-becker merged 1 commit intomainfrom
Conversation
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Contributor
CBMC Results (ML-KEM-1024)Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-768)Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-512)Full Results (191 proofs)
|
hanno-becker
approved these changes
Apr 21, 2026
Contributor
hanno-becker
left a comment
There was a problem hiding this comment.
Thanks @rod-chapman !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review of the AArch64 back-end shows that comments pertaining to the size of the rej_uniform lookup were are incorrect in a number of places. The table is 256 * 16 bytes, so 4096 bytes, NOT 2048 bytes as appears in the comments.