Skip to content

Correct declaration and comments re size of rej-uniform lookup table #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanno-becker merged 1 commit into from
Apr 21, 2026
Merged

Correct declaration and comments re size of rej-uniform lookup table #1657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/aarch64_clean/src/arith_native_aarch64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ __contract__(
#define mlk_rej_uniform_asm MLK_NAMESPACE(rej_uniform_asm)
MLK_MUST_CHECK_RETURN_VALUE
uint64_t mlk_rej_uniform_asm(int16_t r[256], const uint8_t *buf,
unsigned buflen, const uint8_t table[2048])
unsigned buflen, const uint8_t table[4096])
/* This must be kept in sync with the HOL-Light specification
* in proofs/hol_light/aarch64/proofs/mlkem_rej_uniform.ml. */
__contract__(
Expand Down
6 changes: 3 additions & 3 deletions dev/aarch64_clean/src/rej_uniform_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
/*yaml
Name: rej_uniform_asm
Description: Run rejection sampling on uniform random bytes to generate uniform random integers mod q
Signature: uint64_t mlk_rej_uniform_asm(int16_t r[256], const uint8_t *buf, unsigned buflen, const uint8_t table[2048])
Signature: uint64_t mlk_rej_uniform_asm(int16_t r[256], const uint8_t *buf, unsigned buflen, const uint8_t table[4096])
ABI:
x0:
type: buffer
Expand All @@ -27,9 +27,9 @@
test_with: 504 # MLKEM_GEN_MATRIX_NBLOCKS * MLK_XOF_RATE
x3:
type: buffer
size_bytes: 2048
size_bytes: 4096
permissions: read-only
c_parameter: const uint8_t table[2048]
c_parameter: const uint8_t table[4096]
description: Lookup table
Stack:
bytes: 576
Expand Down
2 changes: 1 addition & 1 deletion dev/aarch64_opt/src/arith_native_aarch64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ __contract__(
#define mlk_rej_uniform_asm MLK_NAMESPACE(rej_uniform_asm)
MLK_MUST_CHECK_RETURN_VALUE
uint64_t mlk_rej_uniform_asm(int16_t r[256], const uint8_t *buf,
unsigned buflen, const uint8_t table[2048])
unsigned buflen, const uint8_t table[4096])
/* This must be kept in sync with the HOL-Light specification
* in proofs/hol_light/aarch64/proofs/mlkem_rej_uniform.ml. */
__contract__(
Expand Down
6 changes: 3 additions & 3 deletions dev/aarch64_opt/src/rej_uniform_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
/*yaml
Name: rej_uniform_asm
Description: Run rejection sampling on uniform random bytes to generate uniform random integers mod q
Signature: uint64_t mlk_rej_uniform_asm(int16_t r[256], const uint8_t *buf, unsigned buflen, const uint8_t table[2048])
Signature: uint64_t mlk_rej_uniform_asm(int16_t r[256], const uint8_t *buf, unsigned buflen, const uint8_t table[4096])
ABI:
x0:
type: buffer
Expand All @@ -27,9 +27,9 @@
test_with: 504 # MLKEM_GEN_MATRIX_NBLOCKS * MLK_XOF_RATE
x3:
type: buffer
size_bytes: 2048
size_bytes: 4096
permissions: read-only
c_parameter: const uint8_t table[2048]
c_parameter: const uint8_t table[4096]
description: Lookup table
Stack:
bytes: 576
Expand Down
2 changes: 1 addition & 1 deletion mlkem/src/native/aarch64/src/arith_native_aarch64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ __contract__(
#define mlk_rej_uniform_asm MLK_NAMESPACE(rej_uniform_asm)
MLK_MUST_CHECK_RETURN_VALUE
uint64_t mlk_rej_uniform_asm(int16_t r[256], const uint8_t *buf,
unsigned buflen, const uint8_t table[2048])
unsigned buflen, const uint8_t table[4096])
/* This must be kept in sync with the HOL-Light specification
* in proofs/hol_light/aarch64/proofs/mlkem_rej_uniform.ml. */
__contract__(
Expand Down
6 changes: 3 additions & 3 deletions mlkem/src/native/aarch64/src/rej_uniform_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
/*yaml
Name: rej_uniform_asm
Description: Run rejection sampling on uniform random bytes to generate uniform random integers mod q
Signature: uint64_t mlk_rej_uniform_asm(int16_t r[256], const uint8_t *buf, unsigned buflen, const uint8_t table[2048])
Signature: uint64_t mlk_rej_uniform_asm(int16_t r[256], const uint8_t *buf, unsigned buflen, const uint8_t table[4096])
ABI:
x0:
type: buffer
Expand All @@ -27,9 +27,9 @@
test_with: 504 # MLKEM_GEN_MATRIX_NBLOCKS * MLK_XOF_RATE
x3:
type: buffer
size_bytes: 2048
size_bytes: 4096
permissions: read-only
c_parameter: const uint8_t table[2048]
c_parameter: const uint8_t table[4096]
description: Lookup table
Stack:
bytes: 576
Expand Down
6 changes: 3 additions & 3 deletions proofs/hol_light/aarch64/mlkem/mlkem_rej_uniform.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
/*yaml
Name: rej_uniform_asm
Description: Run rejection sampling on uniform random bytes to generate uniform random integers mod q
Signature: uint64_t mlk_rej_uniform_asm(int16_t r[256], const uint8_t *buf, unsigned buflen, const uint8_t table[2048])
Signature: uint64_t mlk_rej_uniform_asm(int16_t r[256], const uint8_t *buf, unsigned buflen, const uint8_t table[4096])
ABI:
x0:
type: buffer
Expand All @@ -27,9 +27,9 @@
test_with: 504 # MLKEM_GEN_MATRIX_NBLOCKS * MLK_XOF_RATE
x3:
type: buffer
size_bytes: 2048
size_bytes: 4096
permissions: read-only
c_parameter: const uint8_t table[2048]
c_parameter: const uint8_t table[4096]
description: Lookup table
Stack:
bytes: 576
Expand Down
Loading