check-contracts: Detect contracts separated from prototype by a comment#1661
Merged
mkannwischer merged 1 commit intomainfrom Apr 22, 2026
Merged
check-contracts: Detect contracts separated from prototype by a comment#1661mkannwischer merged 1 commit intomainfrom
mkannwischer merged 1 commit intomainfrom
Conversation
The previous regex skipped contracts with a block comment between the
prototype's `)` and `__contract__`, silently missing six contracts
(polyvec_basemul_acc_montgomery_cached_asm_k{2,3,4} on both aarch64
and x86_64). Strip comments before matching, and extend the exception
list to cover the `_asm_k{2,3,4}` suffixes alongside `_native`, `_asm`,
and `_avx2`. Also fix a typo in the `_avx2` suffix.
Also align DECREASES_EXCEPTIONS handling with mldsa-native.
- Ported from pq-code-package/mldsa-native#1051.
Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
mkannwischer
commented
Apr 22, 2026
Contributor
CBMC Results (ML-KEM-1024)Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-768)Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-512)Full Results (191 proofs)
|
hanno-becker
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous regex skipped contracts with a block comment between the prototype's
)and__contract__, silently missing six contracts (polyvec_basemul_acc_montgomery_cached_asm_k{2,3,4} on both aarch64 and x86_64). Strip comments before matching, and extend the exception list to cover the_asm_k{2,3,4}suffixes alongside_native,_asm, and_avx2. Also fix a typo in the_avx2suffix.Also align DECREASES_EXCEPTIONS handling with mldsa-native.