Skip to content

native: Unify asm backend symbol naming #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkannwischer merged 5 commits into from
Apr 24, 2026
Merged

native: Unify asm backend symbol naming #1663

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9bf9fcf
bench: call _native wrappers instead of raw _asm
mkannwischer Apr 23, 2026
181a465
native: Unify asm backend symbol naming
mkannwischer Apr 23, 2026
101f214
hol_light: Unify asm and proof filenames with exported symbols
mkannwischer Apr 23, 2026
ee72a51
bench: Gate native component bench per-function and cover full native…
mkannwischer Apr 23, 2026
295530e
CI: Disable RISE riscv runner (apt install failing)
mkannwischer Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 25 additions & 19 deletions test/bench/bench_components_mlkem.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,31 +213,37 @@ static int bench(void)
printf("---AArch64 native backend components---\n");

BENCH("ntt-native",
mlk_ntt_asm((int16_t *)data0, (int16_t *)data1, (int16_t *)data2));
CHECK(mlk_ntt_native((int16_t *)data0) == MLK_NATIVE_FUNC_SUCCESS));
Comment thread
mkannwischer marked this conversation as resolved.
Outdated
BENCH("intt-native",
mlk_intt_asm((int16_t *)data0, (int16_t *)data1, (int16_t *)data2));
BENCH("mlk_poly-reduce-native", mlk_poly_reduce_asm((int16_t *)data0));
BENCH("mlk_poly-tomont-native", mlk_poly_tomont_asm((int16_t *)data0));
CHECK(mlk_intt_native((int16_t *)data0) == MLK_NATIVE_FUNC_SUCCESS));
BENCH("mlk_poly-reduce-native",
CHECK(mlk_poly_reduce_native((int16_t *)data0) ==
MLK_NATIVE_FUNC_SUCCESS));
BENCH("mlk_poly-tomont-native",
CHECK(mlk_poly_tomont_native((int16_t *)data0) ==
MLK_NATIVE_FUNC_SUCCESS));
BENCH("mlk_poly-tobytes-native",
mlk_poly_tobytes_asm((uint8_t *)data0, (int16_t *)data1));
CHECK(mlk_poly_tobytes_native((uint8_t *)data0, (int16_t *)data1) ==
MLK_NATIVE_FUNC_SUCCESS));
BENCH("mlk_poly-mulcache-compute-native",
mlk_poly_mulcache_compute_asm((int16_t *)data0, (int16_t *)data1,
(int16_t *)data2, (int16_t *)data3));
CHECK(mlk_poly_mulcache_compute_native((int16_t *)data0,
(int16_t *)data1) ==
MLK_NATIVE_FUNC_SUCCESS));
#if MLKEM_K == 2
BENCH("mlk_polyvec-basemul-acc-montgomery-cached-asm-k2-native",
mlk_polyvec_basemul_acc_montgomery_cached_asm_k2(
(int16_t *)data0, (int16_t *)data1, (int16_t *)data2,
(int16_t *)data3));
BENCH("mlk_polyvec-basemul-acc-montgomery-cached-k2-native",
CHECK(mlk_polyvec_basemul_acc_montgomery_cached_k2_native(
(int16_t *)data0, (int16_t *)data1, (int16_t *)data2,
(int16_t *)data3) == MLK_NATIVE_FUNC_SUCCESS));
#elif MLKEM_K == 3
BENCH("mlk_polyvec-basemul-acc-montgomery-cached-asm-k3-native",
mlk_polyvec_basemul_acc_montgomery_cached_asm_k3(
(int16_t *)data0, (int16_t *)data1, (int16_t *)data2,
(int16_t *)data3));
BENCH("mlk_polyvec-basemul-acc-montgomery-cached-k3-native",
CHECK(mlk_polyvec_basemul_acc_montgomery_cached_k3_native(
(int16_t *)data0, (int16_t *)data1, (int16_t *)data2,
(int16_t *)data3) == MLK_NATIVE_FUNC_SUCCESS));
#elif MLKEM_K == 4
BENCH("mlk_polyvec-basemul-acc-montgomery-cached-asm-k4-native",
mlk_polyvec_basemul_acc_montgomery_cached_asm_k4(
(int16_t *)data0, (int16_t *)data1, (int16_t *)data2,
(int16_t *)data3));
BENCH("mlk_polyvec-basemul-acc-montgomery-cached-k4-native",
CHECK(mlk_polyvec_basemul_acc_montgomery_cached_k4_native(
(int16_t *)data0, (int16_t *)data1, (int16_t *)data2,
(int16_t *)data3) == MLK_NATIVE_FUNC_SUCCESS));
#endif /* MLKEM_K == 4 */

#endif /* MLK_ARITH_BACKEND_AARCH64 */
Expand Down