Skip to content

Remove 2 dead instruction from AArch64 back-end poly_tomont()#1664

Merged
mkannwischer merged 1 commit intomainfrom
poly_tomont_dead_code
Apr 23, 2026
Merged

Remove 2 dead instruction from AArch64 back-end poly_tomont()#1664
mkannwischer merged 1 commit intomainfrom
poly_tomont_dead_code

Conversation

@rod-chapman
Copy link
Copy Markdown
Contributor

@rod-chapman rod-chapman commented Apr 23, 2026

Fixes #1656

  1. Remove 2 dead instructions and re-assign registers
  2. Re-apply SLOTHY
  3. Re-autogen all files
  4. Update HOL-Light bytecode for poly_tomont()

The HOL-Light proof scripts itself did not require modifiction

@rod-chapman rod-chapman self-assigned this Apr 23, 2026
@rod-chapman rod-chapman requested a review from a team as a code owner April 23, 2026 06:35
@rod-chapman
Copy link
Copy Markdown
Contributor Author

On a Graviton4 (r8g) instance, the tests bench --components benchmark says exec time for poly_tomont() reduces from 58 to 56 cycles.

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Apr 23, 2026

CBMC Results (ML-KEM-1024)

Full Results (191 proofs)
Proof Status Current Previous Change
**TOTAL** 1203s 1154s +4.2%
mlk_indcpa_enc 135s 133s +2%
mlk_indcpa_keypair_derand 125s 124s +1%
mlk_rej_uniform_c 123s 108s +14%
mlk_polyvec_basemul_acc_montgomery_cached_c 72s 72s +0%
mlk_ntt_layer 35s 27s +30%
polyvec_basemul_acc_montgomery_cached_native 32s 31s +3%
mlk_poly_rej_uniform 31s 28s +11%
mlk_keccak_squeezeblocks_x4 23s 25s -8%
poly_ntt_native 23s 21s +10%
mlk_poly_reduce_native 21s 20s +5%
keccakf1600x4_permute_native_x4 17s 17s +0%
mlk_fqmul 17s 16s +6%
mlk_poly_decompress_d5_native 14s 14s +0%
mlk_poly_decompress_d11_native 13s 13s +0%
mlk_polyvec_add 11s 13s -15%
mlk_poly_frombytes_native 10s 10s +0%
mlk_indcpa_dec 9s 7s +29%
mlk_poly_frommsg 9s 7s +29%
mlk_keccak_squeeze_once 8s 8s +0%
mlk_keccak_squeezeblocks 8s 11s -27%
mlk_keccakf1600_permute_c 8s 5s +60%
mlk_ntt_butterfly_block 8s 7s +14%
mlk_poly_ntt 7s 5s +40%
mlk_poly_rej_uniform_x4 7s 7s +0%
mlk_keccak_absorb_once_x4 6s 6s +0%
mlk_keypair_getnoise_eta1 6s 3s +100%
mlk_polymat_permute_bitrev_to_custom 6s 6s +0%
poly_decompress_d11_native_x86_64 6s 6s +0%
poly_decompress_d5_native_x86_64 6s 3s +100%
poly_frombytes_native_x86_64 6s 5s +20%
mlk_invntt_layer 5s 6s -17%
mlk_keccakf1600_extract_bytes 5s 3s +67%
mlk_matvec_mul 5s 3s +67%
intt_native_aarch64 4s 2s +100%
keccak_f1600_x1_native_aarch64_v84a 4s 2s +100%
kem_dec 4s 6s -33%
kem_enc_derand 4s 1s +300%
kem_keypair 4s 2s +100%
mlk_gen_matrix 4s 5s -20%
mlk_gen_matrix_serial 4s 4s +0%
mlk_keccak_absorb_once 4s 6s -33%
mlk_keccakf1600x4_extract_bytes_c 4s 3s +33%
mlk_poly_compress_d11_c 4s 5s -20%
mlk_poly_decompress_d11 4s 3s +33%
mlk_poly_decompress_d11_c 4s 3s +33%
mlk_poly_invntt_tomont 4s 3s +33%
mlk_poly_mulcache_compute_c 4s 2s +100%
mlk_poly_mulcache_compute_native 4s 4s +0%
mlk_poly_reduce_c 4s 2s +100%
mlk_poly_tobytes_c 4s 2s +100%
mlk_poly_tomont 4s 4s +0%
mlk_polyvec_permute_bitrev_to_custom_native 4s 3s +33%
mlk_scalar_decompress_d10 4s 2s +100%
mlk_shake256x4 4s 3s +33%
poly_compress_d11_native_x86_64 4s 3s +33%
polyvec_basemul_acc_montgomery_cached_k4_native_x86_64 4s 2s +100%
rej_uniform_native_aarch64 4s 4s +0%
intt_native_x86_64 3s 2s +50%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 3s 2s +50%
keccakf1600_permute_native 3s 3s +0%
keccakf1600x4_xor_bytes_native 3s 2s +50%
mlk_barrett_reduce 3s 2s +50%
mlk_ct_cmask_nonzero_u8 3s 1s +200%
mlk_ct_sel_int16 3s 2s +50%
mlk_keccakf1600_permute 3s 1s +200%
mlk_keccakf1600x4_extract_bytes 3s 1s +200%
mlk_poly_cbd_eta1 3s 1s +200%
mlk_poly_compress_d10 3s 3s +0%
mlk_poly_compress_d10_native 3s 2s +50%
mlk_poly_compress_d11 3s 3s +0%
mlk_poly_compress_dv 3s 2s +50%
mlk_poly_decompress_d10 3s 2s +50%
mlk_poly_decompress_d10_native 3s 2s +50%
mlk_poly_decompress_d4_c 3s 2s +50%
mlk_poly_decompress_d4_native 3s 2s +50%
mlk_poly_decompress_dv 3s 3s +0%
mlk_poly_getnoise_eta1122_4x 3s 2s +50%
mlk_poly_ntt_c 3s 3s +0%
mlk_poly_reduce 3s 1s +200%
mlk_poly_tobytes 3s 1s +200%
mlk_poly_tomont_native 3s 1s +200%
mlk_polyvec_decompress_du 3s 2s +50%
mlk_polyvec_invntt_tomont 3s 2s +50%
mlk_polyvec_ntt 3s 3s +0%
mlk_scalar_compress_d1 3s 3s +0%
mlk_scalar_compress_d4 3s 2s +50%
mlk_scalar_decompress_d5 3s 2s +50%
mlk_sha3_256 3s 1s +200%
mlk_shake128_absorb_once 3s 4s -25%
mlk_value_barrier_i32 3s 2s +50%
mlk_value_barrier_u32 3s 2s +50%
mlk_value_barrier_u8 3s 2s +50%
poly_compress_d5_native_x86_64 3s 3s +0%
poly_getnoise_eta1122_4x_native 3s 1s +200%
poly_mulcache_compute_native_aarch64 3s 4s -25%
poly_mulcache_compute_native_x86_64 3s 4s -25%
poly_reduce_native_aarch64 3s 1s +200%
poly_tomont_native_aarch64 3s 4s -25%
polyvec_basemul_acc_montgomery_cached_k2_native_x86_64 3s 1s +200%
rej_uniform_native_x86_64 3s 3s +0%
sys_check_capability 3s 4s -25%
keccak_f1600_x1_native_aarch64 2s 3s -33%
keccak_f1600_x4_native_aarch64_v84a 2s 2s +0%
keccakf1600x4_extract_bytes_native 2s 3s -33%
kem_check_pk 2s 2s +0%
kem_check_sk 2s 3s -33%
kem_enc 2s 2s +0%
kem_keypair_derand 2s 3s -33%
mlk_ct_cmask_neg_i16 2s 3s -33%
mlk_ct_cmask_nonzero_u16 2s 3s -33%
mlk_ct_cmov_zero 2s 1s +100%
mlk_ct_get_optblocker_i32 2s 1s +100%
mlk_ct_get_optblocker_u32 2s 1s +100%
mlk_ct_get_optblocker_u8 2s 3s -33%
mlk_ct_memcmp 2s 3s -33%
mlk_ct_sel_uint8 2s 4s -50%
mlk_enc_getnoise_eta1_eta2 2s 3s -33%
mlk_keccakf1600x4_permute 2s 2s +0%
mlk_keccakf1600x4_xor_bytes 2s 5s -60%
mlk_keccakf1600x4_xor_bytes_c 2s 2s +0%
mlk_montgomery_reduce 2s 4s -50%
mlk_poly_compress_d10_c 2s 2s +0%
mlk_poly_compress_d11_native 2s 2s +0%
mlk_poly_compress_d4 2s 1s +100%
mlk_poly_compress_d4_native 2s 2s +0%
mlk_poly_compress_d5 2s 2s +0%
mlk_poly_compress_d5_c 2s 5s -60%
mlk_poly_compress_d5_native 2s 2s +0%
mlk_poly_compress_du 2s 1s +100%
mlk_poly_decompress_d10_c 2s 1s +100%
mlk_poly_decompress_d4 2s 1s +100%
mlk_poly_decompress_d5 2s 2s +0%
mlk_poly_decompress_d5_c 2s 3s -33%
mlk_poly_decompress_du 2s 2s +0%
mlk_poly_frombytes_c 2s 1s +100%
mlk_poly_getnoise_eta1_4x 2s 3s -33%
mlk_poly_invntt_tomont_c 2s 1s +100%
mlk_poly_mulcache_compute 2s 1s +100%
mlk_poly_sub 2s 1s +100%
mlk_poly_tobytes_native 2s 2s +0%
mlk_poly_tomont_c 2s 2s +0%
mlk_poly_tomsg 2s 3s -33%
mlk_polyvec_compress_du 2s 3s -33%
mlk_polyvec_frombytes 2s 4s -50%
mlk_polyvec_mulcache_compute 2s 3s -33%
mlk_polyvec_permute_bitrev_to_custom 2s 3s -33%
mlk_polyvec_reduce 2s 2s +0%
mlk_polyvec_tobytes 2s 3s -33%
mlk_rej_uniform 2s 1s +100%
mlk_scalar_compress_d5 2s 3s -33%
mlk_scalar_decompress_d4 2s 5s -60%
mlk_scalar_signed_to_unsigned_q 2s 3s -33%
mlk_shake128_squeezeblocks 2s 1s +100%
mlk_shake128x4_absorb_once 2s 3s -33%
mlk_shake128x4_squeezeblocks 2s 4s -50%
mlk_shake256 2s 2s +0%
ntt_native_aarch64 2s 1s +100%
ntt_native_x86_64 2s 3s -33%
nttunpack_native_x86_64 2s 3s -33%
poly_compress_d4_native_x86_64 2s 2s +0%
poly_decompress_d10_native_x86_64 2s 3s -33%
poly_invntt_tomont_native 2s 4s -50%
poly_tobytes_native_aarch64 2s 2s +0%
poly_tobytes_native_x86_64 2s 2s +0%
poly_tomont_native_x86_64 2s 2s +0%
polyvec_basemul_acc_montgomery_cached_k2_native_aarch64 2s 2s +0%
polyvec_basemul_acc_montgomery_cached_k3_native_x86_64 2s 2s +0%
polyvec_basemul_acc_montgomery_cached_k4_native_aarch64 2s 2s +0%
rej_uniform_native 2s 2s +0%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 1s 1s +0%
keccak_f1600_x4_native_avx2 1s 2s -50%
mlk_check_pct 1s 4s -75%
mlk_keccakf1600_extract_bytes (big endian) 1s 2s -50%
mlk_keccakf1600_xor_bytes 1s 2s -50%
mlk_keccakf1600_xor_bytes (big endian) 1s 1s +0%
mlk_poly_add 1s 1s +0%
mlk_poly_cbd_eta2 1s 3s -67%
mlk_poly_compress_d4_c 1s 2s -50%
mlk_poly_frombytes 1s 2s -50%
mlk_poly_getnoise_eta1_4x_native 1s 2s -50%
mlk_poly_getnoise_eta2 1s 3s -67%
mlk_polyvec_basemul_acc_montgomery_cached 1s 4s -75%
mlk_polyvec_tomont 1s 4s -75%
mlk_scalar_compress_d10 1s 3s -67%
mlk_scalar_compress_d11 1s 2s -50%
mlk_scalar_decompress_d11 1s 1s +0%
mlk_sha3_512 1s 1s +0%
poly_compress_d10_native_x86_64 1s 3s -67%
poly_decompress_d4_native_x86_64 1s 3s -67%
poly_reduce_native_x86_64 1s 1s +0%
polyvec_basemul_acc_montgomery_cached_k3_native_aarch64 1s 2s -50%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Apr 23, 2026

CBMC Results (ML-KEM-768)

Full Results (191 proofs)
Proof Status Current Previous Change
**TOTAL** 1208s 1214s -0.5%
mlk_indcpa_keypair_derand 188s 168s +12%
mlk_indcpa_enc 162s 173s -6%
mlk_rej_uniform_c 114s 124s -8%
mlk_polyvec_basemul_acc_montgomery_cached_c 42s 44s -5%
mlk_poly_rej_uniform 30s 27s +11%
mlk_ntt_layer 29s 27s +7%
poly_ntt_native 25s 26s -4%
mlk_keccak_squeezeblocks_x4 24s 25s -4%
keccakf1600x4_permute_native_x4 19s 17s +12%
mlk_poly_reduce_native 19s 21s -10%
mlk_fqmul 16s 16s +0%
polyvec_basemul_acc_montgomery_cached_native 16s 18s -11%
mlk_indcpa_dec 14s 13s +8%
mlk_poly_decompress_d10_native 13s 15s -13%
mlk_poly_decompress_d4_native 11s 15s -27%
mlk_polyvec_add 10s 8s +25%
mlk_ntt_butterfly_block 9s 6s +50%
mlk_poly_frommsg 9s 8s +12%
mlk_keccak_squeeze_once 7s 9s -22%
mlk_keccak_squeezeblocks 7s 7s +0%
mlk_poly_ntt 7s 7s +0%
kem_dec 6s 5s +20%
mlk_keccak_absorb_once 6s 5s +20%
mlk_keccak_absorb_once_x4 6s 8s -25%
mlk_poly_frombytes_native 6s 10s -40%
poly_decompress_d4_native_x86_64 6s 3s +100%
kem_check_sk 5s 3s +67%
mlk_invntt_layer 5s 5s +0%
mlk_keccakf1600x4_extract_bytes 5s 5s +0%
mlk_keccakf1600x4_permute 5s 2s +150%
mlk_poly_getnoise_eta1_4x 5s 2s +150%
mlk_poly_rej_uniform_x4 5s 7s -29%
mlk_polyvec_mulcache_compute 5s 3s +67%
mlk_shake128x4_squeezeblocks 5s 1s +400%
poly_tomont_native_x86_64 5s 2s +150%
kem_enc_derand 4s 2s +100%
mlk_ct_sel_uint8 4s 3s +33%
mlk_keccakf1600_permute_c 4s 4s +0%
mlk_poly_add 4s 2s +100%
mlk_poly_cbd_eta1 4s 2s +100%
mlk_poly_decompress_d10 4s 3s +33%
mlk_poly_getnoise_eta1122_4x 4s 2s +100%
mlk_poly_tobytes 4s 3s +33%
mlk_polyvec_decompress_du 4s 1s +300%
ntt_native_aarch64 4s 3s +33%
poly_compress_d5_native_x86_64 4s 3s +33%
poly_decompress_d11_native_x86_64 4s 3s +33%
poly_frombytes_native_x86_64 4s 5s -20%
polyvec_basemul_acc_montgomery_cached_k2_native_aarch64 4s 3s +33%
rej_uniform_native_x86_64 4s 3s +33%
sys_check_capability 4s 2s +100%
intt_native_aarch64 3s 3s +0%
intt_native_x86_64 3s 2s +50%
keccak_f1600_x1_native_aarch64_v84a 3s 3s +0%
kem_check_pk 3s 4s -25%
kem_enc 3s 2s +50%
kem_keypair_derand 3s 4s -25%
mlk_barrett_reduce 3s 2s +50%
mlk_check_pct 3s 3s +0%
mlk_ct_cmask_nonzero_u16 3s 1s +200%
mlk_ct_cmov_zero 3s 3s +0%
mlk_gen_matrix_serial 3s 4s -25%
mlk_keccakf1600_extract_bytes (big endian) 3s 2s +50%
mlk_keccakf1600_permute 3s 2s +50%
mlk_matvec_mul 3s 2s +50%
mlk_poly_cbd_eta2 3s 1s +200%
mlk_poly_compress_d10 3s 2s +50%
mlk_poly_compress_d10_c 3s 3s +0%
mlk_poly_compress_d4_c 3s 3s +0%
mlk_poly_compress_d4_native 3s 3s +0%
mlk_poly_compress_d5_native 3s 1s +200%
mlk_poly_compress_du 3s 2s +50%
mlk_poly_decompress_d10_c 3s 3s +0%
mlk_poly_decompress_d11 3s 2s +50%
mlk_poly_decompress_d11_native 3s 3s +0%
mlk_poly_decompress_d5 3s 2s +50%
mlk_poly_decompress_d5_c 3s 1s +200%
mlk_poly_decompress_dv 3s 2s +50%
mlk_poly_invntt_tomont 3s 2s +50%
mlk_poly_mulcache_compute_c 3s 4s -25%
mlk_poly_ntt_c 3s 3s +0%
mlk_poly_reduce 3s 3s +0%
mlk_poly_reduce_c 3s 2s +50%
mlk_poly_tobytes_native 3s 4s -25%
mlk_polymat_permute_bitrev_to_custom 3s 4s -25%
mlk_polyvec_permute_bitrev_to_custom 3s 2s +50%
mlk_polyvec_permute_bitrev_to_custom_native 3s 3s +0%
mlk_polyvec_tobytes 3s 1s +200%
mlk_scalar_compress_d1 3s 3s +0%
mlk_scalar_compress_d4 3s 1s +200%
mlk_scalar_decompress_d10 3s 2s +50%
mlk_shake128_absorb_once 3s 1s +200%
mlk_shake256 3s 2s +50%
mlk_shake256x4 3s 4s -25%
poly_compress_d10_native_x86_64 3s 3s +0%
poly_invntt_tomont_native 3s 1s +200%
poly_mulcache_compute_native_x86_64 3s 2s +50%
poly_reduce_native_x86_64 3s 1s +200%
polyvec_basemul_acc_montgomery_cached_k3_native_x86_64 3s 2s +50%
polyvec_basemul_acc_montgomery_cached_k4_native_x86_64 3s 4s -25%
keccak_f1600_x1_native_aarch64 2s 1s +100%
keccak_f1600_x4_native_aarch64_v84a 2s 3s -33%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 2s 4s -50%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 2s 2s +0%
keccak_f1600_x4_native_avx2 2s 1s +100%
keccakf1600_permute_native 2s 1s +100%
keccakf1600x4_extract_bytes_native 2s 1s +100%
kem_keypair 2s 4s -50%
mlk_ct_cmask_neg_i16 2s 1s +100%
mlk_ct_cmask_nonzero_u8 2s 2s +0%
mlk_ct_get_optblocker_i32 2s 3s -33%
mlk_ct_get_optblocker_u32 2s 2s +0%
mlk_ct_memcmp 2s 2s +0%
mlk_ct_sel_int16 2s 4s -50%
mlk_enc_getnoise_eta1_eta2 2s 3s -33%
mlk_gen_matrix 2s 5s -60%
mlk_keccakf1600_xor_bytes 2s 2s +0%
mlk_keypair_getnoise_eta1 2s 4s -50%
mlk_montgomery_reduce 2s 2s +0%
mlk_poly_compress_d10_native 2s 4s -50%
mlk_poly_compress_d11 2s 1s +100%
mlk_poly_compress_d11_c 2s 2s +0%
mlk_poly_compress_d11_native 2s 2s +0%
mlk_poly_compress_d4 2s 1s +100%
mlk_poly_compress_dv 2s 1s +100%
mlk_poly_decompress_d4 2s 3s -33%
mlk_poly_decompress_d5_native 2s 2s +0%
mlk_poly_decompress_du 2s 3s -33%
mlk_poly_frombytes_c 2s 4s -50%
mlk_poly_getnoise_eta1_4x_native 2s 1s +100%
mlk_poly_getnoise_eta2 2s 3s -33%
mlk_poly_mulcache_compute 2s 3s -33%
mlk_poly_sub 2s 1s +100%
mlk_poly_tomont 2s 2s +0%
mlk_poly_tomont_c 2s 1s +100%
mlk_poly_tomont_native 2s 1s +100%
mlk_polyvec_compress_du 2s 3s -33%
mlk_polyvec_frombytes 2s 3s -33%
mlk_polyvec_reduce 2s 1s +100%
mlk_polyvec_tomont 2s 2s +0%
mlk_scalar_compress_d10 2s 3s -33%
mlk_scalar_compress_d5 2s 4s -50%
mlk_scalar_decompress_d11 2s 3s -33%
mlk_scalar_decompress_d4 2s 2s +0%
mlk_scalar_decompress_d5 2s 3s -33%
mlk_scalar_signed_to_unsigned_q 2s 5s -60%
mlk_sha3_256 2s 1s +100%
mlk_shake128x4_absorb_once 2s 3s -33%
ntt_native_x86_64 2s 2s +0%
nttunpack_native_x86_64 2s 3s -33%
poly_compress_d11_native_x86_64 2s 3s -33%
poly_compress_d4_native_x86_64 2s 1s +100%
poly_decompress_d10_native_x86_64 2s 6s -67%
poly_decompress_d5_native_x86_64 2s 2s +0%
poly_getnoise_eta1122_4x_native 2s 1s +100%
poly_reduce_native_aarch64 2s 4s -50%
poly_tobytes_native_aarch64 2s 3s -33%
polyvec_basemul_acc_montgomery_cached_k2_native_x86_64 2s 2s +0%
polyvec_basemul_acc_montgomery_cached_k3_native_aarch64 2s 2s +0%
polyvec_basemul_acc_montgomery_cached_k4_native_aarch64 2s 2s +0%
keccakf1600x4_xor_bytes_native 1s 1s +0%
mlk_ct_get_optblocker_u8 1s 2s -50%
mlk_keccakf1600_extract_bytes 1s 2s -50%
mlk_keccakf1600_xor_bytes (big endian) 1s 4s -75%
mlk_keccakf1600x4_extract_bytes_c 1s 1s +0%
mlk_keccakf1600x4_xor_bytes 1s 2s -50%
mlk_keccakf1600x4_xor_bytes_c 1s 1s +0%
mlk_poly_compress_d5 1s 2s -50%
mlk_poly_compress_d5_c 1s 1s +0%
mlk_poly_decompress_d11_c 1s 2s -50%
mlk_poly_decompress_d4_c 1s 2s -50%
mlk_poly_frombytes 1s 2s -50%
mlk_poly_invntt_tomont_c 1s 4s -75%
mlk_poly_mulcache_compute_native 1s 1s +0%
mlk_poly_tobytes_c 1s 3s -67%
mlk_poly_tomsg 1s 2s -50%
mlk_polyvec_basemul_acc_montgomery_cached 1s 2s -50%
mlk_polyvec_invntt_tomont 1s 1s +0%
mlk_polyvec_ntt 1s 4s -75%
mlk_rej_uniform 1s 4s -75%
mlk_scalar_compress_d11 1s 3s -67%
mlk_sha3_512 1s 3s -67%
mlk_shake128_squeezeblocks 1s 3s -67%
mlk_value_barrier_i32 1s 2s -50%
mlk_value_barrier_u32 1s 3s -67%
mlk_value_barrier_u8 1s 2s -50%
poly_mulcache_compute_native_aarch64 1s 2s -50%
poly_tobytes_native_x86_64 1s 3s -67%
poly_tomont_native_aarch64 1s 2s -50%
rej_uniform_native 1s 2s -50%
rej_uniform_native_aarch64 1s 2s -50%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Apr 23, 2026

CBMC Results (ML-KEM-512)

Full Results (191 proofs)
Proof Status Current Previous Change
**TOTAL** 1335s 1477s -9.6%
mlk_indcpa_keypair_derand 243s 273s -11%
mlk_indcpa_enc 172s 186s -8%
mlk_rej_uniform_c 133s 157s -15%
mlk_polyvec_basemul_acc_montgomery_cached_c 52s 62s -16%
mlk_ntt_layer 35s 43s -19%
mlk_poly_rej_uniform 31s 35s -11%
mlk_keccak_squeezeblocks_x4 25s 31s -19%
poly_ntt_native 25s 31s -19%
mlk_poly_reduce_native 21s 22s -5%
keccakf1600x4_permute_native_x4 18s 18s +0%
mlk_fqmul 16s 20s -20%
mlk_indcpa_dec 15s 18s -17%
mlk_poly_decompress_d10_native 15s 16s -6%
mlk_poly_decompress_d4_native 15s 17s -12%
mlk_polyvec_add 13s 13s +0%
mlk_keccak_squeezeblocks 10s 10s +0%
mlk_poly_frombytes_native 10s 12s -17%
mlk_poly_frommsg 9s 13s -31%
mlk_keccak_squeeze_once 7s 9s -22%
mlk_keccakf1600_permute_c 7s 7s +0%
mlk_ntt_butterfly_block 7s 10s -30%
mlk_poly_rej_uniform_x4 7s 6s +17%
polyvec_basemul_acc_montgomery_cached_native 7s 7s +0%
mlk_keccak_absorb_once_x4 6s 7s -14%
mlk_keccakf1600_extract_bytes (big endian) 6s 2s +200%
mlk_poly_cbd_eta2 6s 8s -25%
mlk_poly_ntt 6s 9s -33%
poly_decompress_d10_native_x86_64 6s 6s +0%
poly_decompress_d5_native_x86_64 6s 3s +100%
poly_frombytes_native_x86_64 6s 8s -25%
kem_dec 5s 5s +0%
kem_keypair 5s 1s +400%
mlk_invntt_layer 5s 6s -17%
mlk_keccakf1600x4_extract_bytes_c 5s 3s +67%
mlk_poly_decompress_d5 5s 1s +400%
mlk_ct_get_optblocker_u32 4s 1s +300%
mlk_ct_sel_uint8 4s 1s +300%
mlk_keccakf1600_xor_bytes 4s 2s +100%
mlk_keccakf1600x4_extract_bytes 4s 1s +300%
mlk_keccakf1600x4_xor_bytes 4s 2s +100%
mlk_poly_compress_d10_c 4s 2s +100%
mlk_poly_decompress_d11_c 4s 2s +100%
mlk_poly_getnoise_eta1122_4x 4s 2s +100%
mlk_poly_reduce 4s 3s +33%
mlk_polyvec_frombytes 4s 2s +100%
mlk_polyvec_permute_bitrev_to_custom_native 4s 4s +0%
mlk_polyvec_tomont 4s 2s +100%
mlk_scalar_decompress_d10 4s 2s +100%
mlk_scalar_decompress_d5 4s 2s +100%
ntt_native_aarch64 4s 3s +33%
nttunpack_native_x86_64 4s 2s +100%
poly_decompress_d4_native_x86_64 4s 4s +0%
polyvec_basemul_acc_montgomery_cached_k4_native_x86_64 4s 2s +100%
rej_uniform_native_aarch64 4s 4s +0%
rej_uniform_native_x86_64 4s 3s +33%
intt_native_x86_64 3s 2s +50%
keccak_f1600_x1_native_aarch64 3s 2s +50%
keccak_f1600_x1_native_aarch64_v84a 3s 4s -25%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 3s 1s +200%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 3s 2s +50%
keccakf1600_permute_native 3s 4s -25%
kem_check_pk 3s 5s -40%
kem_enc_derand 3s 3s +0%
kem_keypair_derand 3s 4s -25%
mlk_barrett_reduce 3s 2s +50%
mlk_check_pct 3s 2s +50%
mlk_ct_cmask_neg_i16 3s 4s -25%
mlk_ct_cmov_zero 3s 3s +0%
mlk_gen_matrix 3s 3s +0%
mlk_gen_matrix_serial 3s 1s +200%
mlk_keccak_absorb_once 3s 5s -40%
mlk_keccakf1600_extract_bytes 3s 2s +50%
mlk_keccakf1600x4_permute 3s 2s +50%
mlk_keypair_getnoise_eta1 3s 2s +50%
mlk_poly_cbd_eta1 3s 4s -25%
mlk_poly_compress_d11_native 3s 3s +0%
mlk_poly_compress_d5_native 3s 3s +0%
mlk_poly_compress_du 3s 3s +0%
mlk_poly_compress_dv 3s 3s +0%
mlk_poly_decompress_d4_c 3s 1s +200%
mlk_poly_decompress_dv 3s 4s -25%
mlk_poly_getnoise_eta1_4x_native 3s 2s +50%
mlk_poly_invntt_tomont 3s 2s +50%
mlk_poly_mulcache_compute_c 3s 4s -25%
mlk_poly_mulcache_compute_native 3s 2s +50%
mlk_poly_reduce_c 3s 1s +200%
mlk_poly_tobytes_c 3s 2s +50%
mlk_poly_tomont_c 3s 2s +50%
mlk_poly_tomont_native 3s 4s -25%
mlk_polyvec_ntt 3s 5s -40%
mlk_polyvec_tobytes 3s 1s +200%
mlk_scalar_compress_d11 3s 3s +0%
mlk_sha3_512 3s 3s +0%
mlk_shake128_absorb_once 3s 4s -25%
mlk_shake256x4 3s 4s -25%
mlk_value_barrier_u8 3s 4s -25%
ntt_native_x86_64 3s 6s -50%
poly_compress_d4_native_x86_64 3s 1s +200%
poly_getnoise_eta1122_4x_native 3s 2s +50%
poly_reduce_native_aarch64 3s 4s -25%
poly_reduce_native_x86_64 3s 5s -40%
poly_tomont_native_x86_64 3s 2s +50%
intt_native_aarch64 2s 1s +100%
keccak_f1600_x4_native_avx2 2s 1s +100%
keccakf1600x4_extract_bytes_native 2s 1s +100%
keccakf1600x4_xor_bytes_native 2s 1s +100%
kem_enc 2s 4s -50%
mlk_ct_cmask_nonzero_u16 2s 4s -50%
mlk_ct_cmask_nonzero_u8 2s 3s -33%
mlk_ct_get_optblocker_i32 2s 3s -33%
mlk_ct_get_optblocker_u8 2s 2s +0%
mlk_ct_memcmp 2s 2s +0%
mlk_enc_getnoise_eta1_eta2 2s 5s -60%
mlk_keccakf1600_xor_bytes (big endian) 2s 2s +0%
mlk_keccakf1600x4_xor_bytes_c 2s 2s +0%
mlk_matvec_mul 2s 4s -50%
mlk_poly_add 2s 1s +100%
mlk_poly_compress_d10 2s 1s +100%
mlk_poly_compress_d10_native 2s 3s -33%
mlk_poly_compress_d11 2s 2s +0%
mlk_poly_compress_d11_c 2s 1s +100%
mlk_poly_compress_d4 2s 2s +0%
mlk_poly_compress_d4_native 2s 2s +0%
mlk_poly_compress_d5 2s 3s -33%
mlk_poly_decompress_d10 2s 5s -60%
mlk_poly_decompress_d11_native 2s 1s +100%
mlk_poly_decompress_d4 2s 1s +100%
mlk_poly_decompress_d5_c 2s 2s +0%
mlk_poly_decompress_du 2s 2s +0%
mlk_poly_frombytes_c 2s 2s +0%
mlk_poly_getnoise_eta1_4x 2s 2s +0%
mlk_poly_getnoise_eta2 2s 1s +100%
mlk_poly_invntt_tomont_c 2s 3s -33%
mlk_poly_ntt_c 2s 3s -33%
mlk_poly_sub 2s 2s +0%
mlk_poly_tobytes 2s 3s -33%
mlk_poly_tomont 2s 3s -33%
mlk_polyvec_basemul_acc_montgomery_cached 2s 2s +0%
mlk_polyvec_compress_du 2s 2s +0%
mlk_polyvec_decompress_du 2s 3s -33%
mlk_polyvec_invntt_tomont 2s 3s -33%
mlk_polyvec_mulcache_compute 2s 6s -67%
mlk_polyvec_permute_bitrev_to_custom 2s 4s -50%
mlk_polyvec_reduce 2s 2s +0%
mlk_rej_uniform 2s 3s -33%
mlk_scalar_compress_d1 2s 1s +100%
mlk_scalar_compress_d4 2s 2s +0%
mlk_scalar_compress_d5 2s 2s +0%
mlk_scalar_decompress_d11 2s 4s -50%
mlk_scalar_decompress_d4 2s 4s -50%
mlk_scalar_signed_to_unsigned_q 2s 2s +0%
mlk_sha3_256 2s 4s -50%
mlk_shake128_squeezeblocks 2s 2s +0%
mlk_shake128x4_absorb_once 2s 2s +0%
mlk_shake128x4_squeezeblocks 2s 1s +100%
mlk_shake256 2s 2s +0%
mlk_value_barrier_i32 2s 2s +0%
mlk_value_barrier_u32 2s 1s +100%
poly_compress_d10_native_x86_64 2s 5s -60%
poly_compress_d5_native_x86_64 2s 4s -50%
poly_invntt_tomont_native 2s 1s +100%
poly_mulcache_compute_native_x86_64 2s 3s -33%
poly_tobytes_native_aarch64 2s 3s -33%
poly_tobytes_native_x86_64 2s 3s -33%
polyvec_basemul_acc_montgomery_cached_k2_native_x86_64 2s 4s -50%
polyvec_basemul_acc_montgomery_cached_k3_native_aarch64 2s 4s -50%
polyvec_basemul_acc_montgomery_cached_k4_native_aarch64 2s 3s -33%
keccak_f1600_x4_native_aarch64_v84a 1s 2s -50%
kem_check_sk 1s 4s -75%
mlk_ct_sel_int16 1s 1s +0%
mlk_keccakf1600_permute 1s 2s -50%
mlk_montgomery_reduce 1s 1s +0%
mlk_poly_compress_d4_c 1s 2s -50%
mlk_poly_compress_d5_c 1s 2s -50%
mlk_poly_decompress_d10_c 1s 2s -50%
mlk_poly_decompress_d11 1s 3s -67%
mlk_poly_decompress_d5_native 1s 1s +0%
mlk_poly_frombytes 1s 4s -75%
mlk_poly_mulcache_compute 1s 2s -50%
mlk_poly_tobytes_native 1s 4s -75%
mlk_poly_tomsg 1s 4s -75%
mlk_polymat_permute_bitrev_to_custom 1s 2s -50%
mlk_scalar_compress_d10 1s 2s -50%
poly_compress_d11_native_x86_64 1s 2s -50%
poly_decompress_d11_native_x86_64 1s 4s -75%
poly_mulcache_compute_native_aarch64 1s 1s +0%
poly_tomont_native_aarch64 1s 2s -50%
polyvec_basemul_acc_montgomery_cached_k2_native_aarch64 1s 1s +0%
polyvec_basemul_acc_montgomery_cached_k3_native_x86_64 1s 2s -50%
rej_uniform_native 1s 2s -50%
sys_check_capability 1s 3s -67%

Copy link
Copy Markdown
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rod-chapman for fixing. I would prefer if we do not run the SLOTHY re-optimization as this makes the diff larger than it needs to be. Or am I missing something here?

Comment thread dev/aarch64_opt/src/poly_tomont_asm.S
1. Remove 2 dead instructions.
2. These appear outside the inner-loop of poly_tomont(), so do NOT
   re-apply SLOTHY to minimize the difference in code going into production.
3. Re-autogen all files
4. Update HOL-Light bytecode for poly_tomont()
5. Re-check HOL-Light proof of this function.

Signed-off-by: Rod Chapman <rodchap@amazon.com>
@rod-chapman rod-chapman force-pushed the poly_tomont_dead_code branch from 85a713b to 73f992a Compare April 23, 2026 09:38
Copy link
Copy Markdown
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many thanks to @rod-chapman for spotting and fixing this one.

@mkannwischer mkannwischer merged commit fb00ece into main Apr 23, 2026
429 checks passed
@mkannwischer mkannwischer deleted the poly_tomont_dead_code branch April 23, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead code in AArch64 poly_tomont_asm.S

4 participants