Remove 2 dead instruction from AArch64 back-end poly_tomont()#1664
Merged
mkannwischer merged 1 commit intomainfrom Apr 23, 2026
Merged
Remove 2 dead instruction from AArch64 back-end poly_tomont()#1664mkannwischer merged 1 commit intomainfrom
mkannwischer merged 1 commit intomainfrom
Conversation
Contributor
Author
|
On a Graviton4 (r8g) instance, the |
Contributor
CBMC Results (ML-KEM-1024)Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-768)Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-512)Full Results (191 proofs)
|
mkannwischer
requested changes
Apr 23, 2026
Contributor
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @rod-chapman for fixing. I would prefer if we do not run the SLOTHY re-optimization as this makes the diff larger than it needs to be. Or am I missing something here?
1. Remove 2 dead instructions. 2. These appear outside the inner-loop of poly_tomont(), so do NOT re-apply SLOTHY to minimize the difference in code going into production. 3. Re-autogen all files 4. Update HOL-Light bytecode for poly_tomont() 5. Re-check HOL-Light proof of this function. Signed-off-by: Rod Chapman <rodchap@amazon.com>
85a713b to
73f992a
Compare
mkannwischer
approved these changes
Apr 23, 2026
Contributor
mkannwischer
left a comment
There was a problem hiding this comment.
LGTM. Many thanks to @rod-chapman for spotting and fixing this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1656
The HOL-Light proof scripts itself did not require modifiction