Add alloc test Windows support (C backend only)#1749
Closed
willieyz wants to merge 1 commit into
Closed
Conversation
Contributor
CBMC Results (ML-KEM-512)Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-1024)Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-768)Full Results (191 proofs)
|
mlkem-native currently has no alloc test coverage on Windows. This commit enabling alloc tests against the portable C backend. Signed-off-by: willieyz <willie.zhao@chelpis.com>
Contributor
Author
|
Based on the review comment: #1738 (review), the remaining gaps should be addressed in a single PR. As a result, I will close this PR and cherry-pick the relevant commit into PR #1738. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds alloc test support for Windows using the C backend.
mlkem-native currently has no alloc test coverage on Windows. Referencing the Linux Makefile, this PR adds the alloc test
(
test/src/test_alloc.c,test/configs/test_alloc_config.h) toMakefile.Microsoft_nmake. Note that this alloc test needs to rebuild the.objfiles, since it uses a different config from the default functional test. I also define a new macroALLOC_CFLAGSto reduce the length of the build rules