FIPS202: Consolidate backend MLK_USE_NATIVE_* flags - #1775
Open
mkannwischer wants to merge 1 commit into
Open
Conversation
Rename the FIPS202 backend function-support flags to the MLK_USE_NATIVE_<function> convention already used by the arithmetic backend: MLK_USE_FIPS202_X1_NATIVE -> MLK_USE_NATIVE_FIPS202_X1 MLK_USE_FIPS202_X4_NATIVE -> MLK_USE_NATIVE_FIPS202_X4 MLK_USE_FIPS202_X4_XOR_BYTES_NATIVE -> MLK_USE_NATIVE_FIPS202_X4_XOR_BYTES MLK_USE_FIPS202_X4_EXTRACT_BYTES_NATIVE -> MLK_USE_NATIVE_FIPS202_X4_EXTRACT_BYTES Custom backends that set these flags must rename them accordingly. - Ports pq-code-package/mldsa-native#1207 Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Contributor
CBMC Results (ML-KEM-512)
Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-1024)Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-768)
Full Results (191 proofs)
|
mkannwischer
marked this pull request as ready for review
July 1, 2026 07:09
hanno-becker
approved these changes
Jul 1, 2026
Contributor
Author
|
Thanks for the review @hanno-becker. What's blocking the merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the FIPS202 backend function-support flags to the MLK_USE_NATIVE_ convention already used by the arithmetic backend:
MLK_USE_FIPS202_X1_NATIVE -> MLK_USE_NATIVE_FIPS202_X1
MLK_USE_FIPS202_X4_NATIVE -> MLK_USE_NATIVE_FIPS202_X4
MLK_USE_FIPS202_X4_XOR_BYTES_NATIVE -> MLK_USE_NATIVE_FIPS202_X4_XOR_BYTES
MLK_USE_FIPS202_X4_EXTRACT_BYTES_NATIVE -> MLK_USE_NATIVE_FIPS202_X4_EXTRACT_BYTES
Custom backends that set these flags must rename them accordingly.
MLK_USE_XXXflags indicating function support #1523