fix: align cost model key lists with Haskell ParamName enum order#51
Open
jonathanlim222 wants to merge 2 commits into
Open
fix: align cost model key lists with Haskell ParamName enum order#51jonathanlim222 wants to merge 2 commits into
jonathanlim222 wants to merge 2 commits into
Conversation
b0293fb to
5791470
Compare
Signed-off-by: Jonathan Lim <jonathan.lim.222@gmail.com>
Signed-off-by: Jonathan Lim <jonathan.lim.222@gmail.com>
5791470 to
0ba280f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the cost model logic to support the upcoming v11 changes.
cost_map.rs: Rewrote V1, V2, and V3 key lists to match the HaskellParamNameenum order exactly — 332/332/350 entries respectively. Removed the incorrect length gates (len == 169, len == 178, len == 297) that were gatingripemd_160at the wrong positions (166/175 instead of 276–278). Extracted sharedPLOMIN_KEYS,PV11_KEYS,BLS12_G1_KEYS,BLS12_G2_KEYSconstants to avoid repetition across versions. Fixed a key name bug in V3: "blake2b_224-mem-arguments-slope" → "blake2b_224-mem-arguments".builtin_costs_v1.rs/builtin_costs_v2.rs:initialize()now readsdrop_list,length_of_array,list_to_array, andindex_arrayfrom the cost map rather than using hardcoded values, so PV11 protocol parameters are respected for V1 and V2 scripts.builtin_costs_v3.rs: Fixed the matching "blake2b_224-mem-arguments-slope" key lookup in initialize().