Unify turn detection parameters#84
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a shared, provider-neutral context_switch_core::TurnDetection configuration to unify end-of-turn tuning across the Deepgram Flux and Microsoft Voice Live transcription services, with each backend forwarding only the fields it supports.
Changes:
- Added
core::TurnDetection+ThresholdLeveland re-exported them fromcontext_switch_core. - Updated Deepgram and Voice Live transcribe params to accept the shared
TurnDetectionshape and mapped it to provider-specific SDK/session settings. - Extended the
examples/transcribeCLI and README with turn-detection tuning flags and usage examples; documented the design in an ADR and CONTEXT glossary.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/microsoft-voice-live/src/transcribe.rs | Switch Voice Live params to use context_switch_core::TurnDetection and clarify forwarding behavior. |
| services/microsoft-voice-live/src/client.rs | Map neutral threshold_level/timeout_ms into Voice Live Azure multilingual semantic VAD config. |
| services/deepgram/src/transcribe.rs | Replace Deepgram-specific flattened turn-detection fields with shared TurnDetection (now nested). |
| examples/transcribe.rs | Add CLI flags for turn detection and thread a shared TurnDetection into provider params. |
| core/src/turn_detection.rs | New shared turn detection types (TurnDetection, ThresholdLevel). |
| core/src/lib.rs | Wire in and re-export the new turn detection module/types. |
| docs/adr/0001-turn-detection-provider-specific-fields.md | Document rationale/decision for provider-specific fields within a shared struct. |
| README.md | Add example commands for Deepgram and Voice Live end-of-turn tuning. |
| CONTEXT.md | Add terminology definitions for turn detection and threshold levels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.