Skip to content

Commit 9a7be00

Browse files
authored
Bump go versions to 1.23 / 1.24 (#41)
* Update testdata for 1.24 file:lines * Skip new methods from 1.24
1 parent da8e6eb commit 9a7be00

5 files changed

Lines changed: 10 additions & 6 deletions

File tree

.mise.oldstable.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[tools]
2-
go = "1.22"
2+
go = "1.23"
33

44
[env]
55
GO_NOT_LATEST = true

.mise.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[tools]
2-
go = "1.23"
2+
go = "1.24"
33
golangci-lint = "v1.63.4"
44

55
[tasks.build]

fake_coverage_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ func TestTBCoverage(t *testing.T) {
3636
}
3737

3838
mn := m.Name
39+
// TODO(prashant): Implement new methods added in 1.24 before release.
40+
if mn == "Chdir" || mn == "Context" {
41+
continue
42+
}
3943
if _, ok := ftSet[mn]; !ok {
4044
t.Errorf("faket missing testing.TB.%s", mn)
4145
}

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module github.com/prashantv/faket
22

3-
go 1.22
3+
go 1.23

testdata/cmp_test_results.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,12 +106,12 @@
106106
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/always_nest_with_skips","Output":" integration_test.go:207: defer cleanup 2\n"}
107107
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/always_nest_with_skips","Output":" integration_test.go:201: nested cleanup 2\n"}
108108
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/always_nest_with_skips","Output":" integration_test.go:204: skip in nested cleanup 2\n"}
109-
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/always_nest_with_skips","Output":" panic.go:629: defer nested cleanup 2\n"}
109+
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/always_nest_with_skips","Output":" panic.go:636: defer nested cleanup 2\n"}
110110
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/always_nest_with_skips","Output":" integration_test.go:193: cleanup 1\n"}
111111
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/always_nest_with_skips","Output":" integration_test.go:207: defer cleanup 1\n"}
112112
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/always_nest_with_skips","Output":" integration_test.go:201: nested cleanup 1\n"}
113113
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/always_nest_with_skips","Output":" integration_test.go:204: skip in nested cleanup 1\n"}
114-
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/always_nest_with_skips","Output":" panic.go:629: defer nested cleanup 1\n"}
114+
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/always_nest_with_skips","Output":" panic.go:636: defer nested cleanup 1\n"}
115115
{"Time":"2022-06-11T00:00:00.0Z","Action":"run","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/mix_nesting_and_skips"}
116116
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/mix_nesting_and_skips","Output":"=== RUN TestCmp_NestedCleanup/mix_nesting_and_skips\n"}
117117
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/mix_nesting_and_skips","Output":" integration_test.go:187: log 1\n"}
@@ -126,7 +126,7 @@
126126
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/mix_nesting_and_skips","Output":" integration_test.go:207: defer cleanup 1\n"}
127127
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/mix_nesting_and_skips","Output":" integration_test.go:201: nested cleanup 1\n"}
128128
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/mix_nesting_and_skips","Output":" integration_test.go:204: skip in nested cleanup 1\n"}
129-
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/mix_nesting_and_skips","Output":" panic.go:629: defer nested cleanup 1\n"}
129+
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/mix_nesting_and_skips","Output":" panic.go:636: defer nested cleanup 1\n"}
130130
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup","Output":"--- PASS: TestCmp_NestedCleanup (0.01s)\n"}
131131
{"Time":"2022-06-11T00:00:00.0Z","Action":"output","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/always_nest_without_skip","Output":" --- PASS: TestCmp_NestedCleanup/always_nest_without_skip (0.01s)\n"}
132132
{"Time":"2022-06-11T00:00:00.0Z","Action":"pass","Package":"github.com/prashantv/faket","Test":"TestCmp_NestedCleanup/always_nest_without_skip","Elapsed":0}

0 commit comments

Comments
 (0)