Skip to content

Fix exponential retries on parsing error#39

Open
moritz157 wants to merge 1 commit into
pratikbaid3:masterfrom
moritz157:master
Open

Fix exponential retries on parsing error#39
moritz157 wants to merge 1 commit into
pratikbaid3:masterfrom
moritz157:master

Conversation

@moritz157

Copy link
Copy Markdown

This should fix #38 as it cancels the stream subscriptions if the message parser cannot parse a line. Also it catches responses without the header content-type: text/event-stream early and (if no response header connection: keep-alive is present) logs their body for debugging purposes.

@twentyforty

Copy link
Copy Markdown

Thank you @moritz157 for tackling this. I'm running into the same issue.

@pratikbaid3 what do you think of this approach? Is this ready for merging?

@pratikbaid3

Copy link
Copy Markdown
Owner

Hi @moritz157. Thank you for the PR. Looks good to merge. Doing some final testings to go ahead with the final merge.
@twentyforty, you could use the pr ref for now to see if this fixes the issue for you

@twentyforty

Copy link
Copy Markdown

yep. been using it and it does fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server responding with html error message causes an exponential number of retries

3 participants