Commit fe94253
committed
v2: Fix GameObjectsDisplay silently disabled on D3D11 games
on_frame() gated on !m_d3d12.initialized even though the mod has a
working D3D11/legacy-mode ImGui fallback path (line 380-381:
world_to_screen + draw_list->AddText). initialize_d3d_resources()
only populates m_d3d12.initialized for the D3D12 branch; the D3D11
branch has just '// TODO'. So for any game running on D3D11 (DMC5
and others), the gate returned early before reaching the ImGui
fallback \u2014 the mod was effectively disabled.
Same behavior on upstream master; DMC5 was never getting object
labels even with the mod enabled.
Split the gate: m_d3d12.initialized is only required when actually
taking the D3D12 3D-text path. For legacy mode or D3D11, proceed
to the ImGui fallback.
Verified: DMC5 (D3D11) now draws game object labels when the mod
is enabled.1 parent a306f8c commit fe94253
1 file changed
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
166 | 174 | | |
167 | 175 | | |
168 | 176 | | |
| |||
0 commit comments