Skip to content

Commit 98a7fa3

Browse files
committed
Fix extra v in golang tags
1 parent 09f6a1d commit 98a7fa3

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

pre_commit_mirror_maker/languages.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,10 @@ def golang_get_package_versions(package_name: str) -> list[str]:
4343
)
4444
url = f'https://proxy.golang.org/{escaped}/@v/list'
4545
resp = urllib.request.urlopen(url).read().decode()
46-
return sorted(resp.splitlines(), key=version.parse)
46+
return sorted(
47+
(v.removeprefix('v') for v in resp.splitlines()),
48+
key=version.parse,
49+
)
4750

4851

4952
def node_get_additional_dependencies(
@@ -61,7 +64,7 @@ def rust_get_additional_dependencies(
6164
def golang_get_additional_dependencies(
6265
package_name: str, package_version: str,
6366
) -> list[str]:
64-
return [f'{package_name}@{package_version}']
67+
return [f'{package_name}@v{package_version}']
6568

6669

6770
LIST_VERSIONS = {

tests/languages_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,5 @@ def test_rust_get_package_version_output():
4545
def test_golang_get_package_version_output():
4646
ret = golang_get_package_versions('mvdan.cc/gofumpt')
4747
assert ret
48+
assert not any(v.startswith('v') for v in ret)
4849
assert_all_text(ret)

0 commit comments

Comments
 (0)