Skip to content

Commit 4a23fa2

Browse files
committed
refactor: Better perf?
1 parent 60e6e7e commit 4a23fa2

1 file changed

Lines changed: 16 additions & 16 deletions

File tree

src/diff/props.js

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ let eventClock = 0;
3737
export function setProperty(dom, name, value, oldValue, namespace) {
3838
let useCapture,
3939
split = name.split(':');
40-
name = name.replace(/(.+):/, '');
40+
if (split.length > 1) name = split[1];
4141

4242
o: if (name === 'style') {
4343
if (typeof value == 'string') {
@@ -107,21 +107,21 @@ export function setProperty(dom, name, value, oldValue, namespace) {
107107
name = name.replace(/xlink(H|:h)/, 'h').replace(/sName$/, 's');
108108
} else if (
109109
split[0] == 'prop' ||
110-
split[0] != 'attr' &&
111-
name != 'width' &&
112-
name != 'height' &&
113-
name != 'href' &&
114-
name != 'list' &&
115-
name != 'form' &&
116-
// Default value in browsers is `-1` and an empty string is
117-
// cast to `0` instead
118-
name != 'tabIndex' &&
119-
name != 'download' &&
120-
name != 'rowSpan' &&
121-
name != 'colSpan' &&
122-
name != 'role' &&
123-
name != 'popover' &&
124-
name in dom
110+
(split[0] != 'attr' &&
111+
name != 'width' &&
112+
name != 'height' &&
113+
name != 'href' &&
114+
name != 'list' &&
115+
name != 'form' &&
116+
// Default value in browsers is `-1` and an empty string is
117+
// cast to `0` instead
118+
name != 'tabIndex' &&
119+
name != 'download' &&
120+
name != 'rowSpan' &&
121+
name != 'colSpan' &&
122+
name != 'role' &&
123+
name != 'popover' &&
124+
name in dom)
125125
) {
126126
try {
127127
dom[name] = value == null ? '' : value;

0 commit comments

Comments
 (0)