Skip to content

Support createPortal in core#5168

Open
JoviDeCroock wants to merge 1 commit into
mainfrom
JoviDeCroock/portal-parentdom-in-core
Open

Support createPortal in core#5168
JoviDeCroock wants to merge 1 commit into
mainfrom
JoviDeCroock/portal-parentdom-in-core

Conversation

@JoviDeCroock

@JoviDeCroock JoviDeCroock commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This moves createPortal into core and adds support for a new primitive so we can support other libraries manipulating the roots. With _parentDom you can change up the root of the diff algorithm. As we already support _parentDom in mangle this will mangle to __P

Co-Authored with GPT5.6-sol for moving tests around and translating to class components

@github-actions

github-actions Bot commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +0% (-3.73ms - +3.09ms)
    preact-local vs preact-main
  • filter-list: faster ✔ 0% - 1% (0.01ms - 0.19ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +2% (-0.71ms - +0.97ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +5% (-0.06ms - +0.77ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +2% (-0.35ms - +1.29ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +4% (-0.10ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.40ms - +0.34ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +5% (-0.67ms - +1.47ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.01ms - +0.01ms)
    preact-local vs preact-main
  • filter-list: slower ❌ 1% - 1% (0.01ms - 0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +2% (-0.08ms - +0.12ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 +0% - +0% (+0.01ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: slower ❌ 0% - 1% (0.01ms - 0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +3% (-0.04ms - +0.03ms)
    preact-local vs preact-main
  • todo: slower ❌ 1% - 1% (0.01ms - 0.01ms)
    preact-local vs preact-main
  • update10th1k: slower ❌ 0% - 1% (0.01ms - 0.02ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local846.92ms - 851.20ms-unsure 🔍
-0% - +0%
-3.73ms - +3.09ms
preact-main846.73ms - 852.04msunsure 🔍
-0% - +0%
-3.09ms - +3.73ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.09ms - 19.09ms-unsure 🔍
+0% - +0%
+0.01ms - +0.01ms
preact-main19.08ms - 19.08msunsure 🔍
-0% - -0%
-0.01ms - -0.01ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.52ms - 16.57ms-faster ✔
0% - 1%
0.01ms - 0.19ms
preact-main16.56ms - 16.73msslower ❌
0% - 1%
0.01ms - 0.19ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.57ms - 1.57ms-slower ❌
1% - 1%
0.01ms - 0.02ms
preact-main1.55ms - 1.56msfaster ✔
1% - 1%
0.01ms - 0.02ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local57.54ms - 58.80ms-unsure 🔍
-1% - +2%
-0.71ms - +0.97ms
preact-main57.48ms - 58.60msunsure 🔍
-2% - +1%
-0.97ms - +0.71ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.98ms - 5.13ms-unsure 🔍
-2% - +2%
-0.08ms - +0.12ms
preact-main4.97ms - 5.11msunsure 🔍
-2% - +2%
-0.12ms - +0.08ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.42ms - 17.24ms-unsure 🔍
-0% - +5%
-0.06ms - +0.77ms
preact-main16.40ms - 16.54msunsure 🔍
-5% - +0%
-0.77ms - +0.06ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.75ms - 3.76ms-unsure 🔍
+0% - +0%
+0.01ms - +0.01ms
preact-main3.74ms - 3.74msunsure 🔍
-0% - -0%
-0.01ms - -0.01ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5692

  • Commit: ec0a288

duration

VersionAvg timevs preact-localvs preact-main
preact-local54.36ms - 55.56ms-unsure 🔍
-1% - +2%
-0.35ms - +1.29ms
preact-main53.93ms - 55.05msunsure 🔍
-2% - +1%
-1.29ms - +0.35ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.02ms - 3.03ms-slower ❌
0% - 1%
0.01ms - 0.02ms
preact-main3.01ms - 3.02msfaster ✔
0% - 1%
0.01ms - 0.02ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local28.30ms - 29.02ms-unsure 🔍
-3% - +1%
-0.72ms - +0.31ms
preact-main28.50ms - 29.24msunsure 🔍
-1% - +3%
-0.31ms - +0.72ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local33.26ms - 34.64ms-unsure 🔍
-1% - +4%
-0.40ms - +1.44ms
preact-main32.81ms - 34.04msunsure 🔍
-4% - +1%
-1.44ms - +0.40ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local28.84ms - 29.94ms-unsure 🔍
-4% - +1%
-1.20ms - +0.39ms
preact-main29.22ms - 30.37msunsure 🔍
-1% - +4%
-0.39ms - +1.20ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.33ms - 25.66ms-unsure 🔍
-0% - +1%
-0.12ms - +0.31ms
preact-main25.27ms - 25.53msunsure 🔍
-1% - +0%
-0.31ms - +0.12ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.65ms - 24.23ms-faster ✔
2% - 11%
0.52ms - 2.80ms
preact-main24.28ms - 25.92msslower ❌
2% - 12%
0.52ms - 2.80ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.26ms - 20.71ms-unsure 🔍
-1% - +2%
-0.13ms - +0.45ms
preact-main20.14ms - 20.50msunsure 🔍
-2% - +1%
-0.45ms - +0.13ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 120
  • Built by: CI #5692

  • Commit: ec0a288

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.03ms - 2.19ms-unsure 🔍
-5% - +4%
-0.10ms - +0.09ms
preact-main2.05ms - 2.17msunsure 🔍
-4% - +5%
-0.09ms - +0.10ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.01ms - 1.05ms-unsure 🔍
-4% - +3%
-0.04ms - +0.03ms
preact-main1.01ms - 1.07msunsure 🔍
-3% - +4%
-0.03ms - +0.04ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.19ms - 30.49ms-unsure 🔍
-1% - +1%
-0.40ms - +0.34ms
preact-main30.03ms - 30.70msunsure 🔍
-1% - +1%
-0.34ms - +0.40ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.28ms - 1.28ms-slower ❌
1% - 1%
0.01ms - 0.01ms
preact-main1.27ms - 1.27msfaster ✔
1% - 1%
0.01ms - 0.01ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.00ms - 33.53ms-unsure 🔍
-2% - +5%
-0.67ms - +1.47ms
preact-main31.62ms - 33.12msunsure 🔍
-4% - +2%
-1.47ms - +0.67ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.98ms - 2.99ms-slower ❌
0% - 1%
0.01ms - 0.02ms
preact-main2.97ms - 2.98msfaster ✔
0% - 1%
0.01ms - 0.02ms		-

tachometer-reporter-action v2 for CI

@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown

Size Change: -93 B (-0.59%)

Total Size: 15.7 kB

📦 View Changed
Filename Size Change
compat/dist/compat.mjs 3.66 kB -210 B (-5.43%) ✅
dist/preact.mjs 5.01 kB +117 B (+2.39%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.mjs 3.89 kB
devtools/dist/devtools.mjs 274 B
hooks/dist/hooks.mjs 1.55 kB
jsx-runtime/dist/jsxRuntime.mjs 861 B
test-utils/dist/testUtils.mjs 473 B

compressed-size-action

@coveralls

coveralls commented Jul 18, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 98.485% (-0.05%) from 98.534% — JoviDeCroock/portal-parentdom-in-core into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschristian rschristian rschristian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoviDeCroock @coveralls @rschristian