AdOcean Bid Adapter: support for optional, extra emitter parameters#14959
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for passing optional custom query parameters (emitterRequestParams) through the Adocean bidder adapter, including validation, URL construction, tests, and documentation updates.
Changes:
- Validate
params.emitterRequestParamsas a plain object inisBidRequestValid. - Append URL-encoded
emitterRequestParamsto the outgoing request URL. - Add unit tests and update adapter documentation with the new optional parameter.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/spec/modules/adoceanBidAdapter_spec.js | Adds tests for validation and URL appending/encoding of emitterRequestParams. |
| modules/adoceanBidAdapter.md | Documents the new optional emitterRequestParams configuration. |
| modules/adoceanBidAdapter.js | Implements validation and URL query-string injection for emitterRequestParams. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const emitterRequestParams = []; | ||
| if (bid.params.emitterRequestParams) { | ||
| _each(bid.params.emitterRequestParams, function(v, k) { | ||
| emitterRequestParams.push(encodeURIComponent(k) + '=' + encodeURIComponent(v)); | ||
| }); | ||
| } |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18eee8b321
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Type of change
Description of change
New parameter: "emitterRequestParams" which allows to provide additional data for targeting.
Documentation
prebid/prebid.github.io#6586