ViewdeosDX Bid Adapter: deprecate adapter#15022
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80b2728f19
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| aliases: [ | ||
| 'streamkey', | ||
| 'janet', | ||
| { code: 'ocm', gvlid: 1148 }, | ||
| '9dotsmedia', | ||
| 'indicue', | ||
| 'stellormedia' | ||
| ], |
There was a problem hiding this comment.
When publishers build with adtelligentBidAdapter and use the existing bidder codes streamkey, janet, ocm, 9dotsmedia, or stellormedia, these aliases are no longer registered and there are no other repo-wide registrations for them, so those integrations will stop bidding even though this change is only deprecating viewdeosDX. Please keep the Adtelligent aliases and their host mappings unless those separate bidder codes are intentionally being deprecated too.
Useful? React with 👍 / 👎.
| }); | ||
| } | ||
|
|
||
| registerBidder(spec); |
There was a problem hiding this comment.
Removing the adapter registration leaves the module metadata inconsistent: metadata/modules.json and metadata/modules/viewdeosDXBidAdapter.json still advertise viewdeosDX and its viewdeos alias even though the implementation and tests are gone. Any tooling or consent/module registry consumer that reads metadata can still treat the deleted bidder as available, so the metadata should be regenerated/cleaned up as part of the deprecation.
Useful? React with 👍 / 👎.
Barecheck - Code coverage reportTotal: 96.48%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
| return 'ghb' + subdomainSuffixes[num++ % subdomainSuffixes.length] + '.adtelligent.com'; | ||
| } | ||
| }()), | ||
| streamkey: () => 'ghb.hb.streamkey.net', |
There was a problem hiding this comment.
please add your changes to adtelligent in a different pr
| @@ -1,345 +0,0 @@ | |||
| import { expect } from 'chai'; | |||
There was a problem hiding this comment.
please keep this deleted
There was a problem hiding this comment.
please keep this file, we will delete it in prebid 12. Please make it do nothing, eg
**
import { registerBidder } from '../src/adapters/bidderFactory.js';
const BIDDER_CODE = 'yourBidderName';
export const spec = {
code: BIDDER_CODE,
supportedMediaTypes: ['banner', 'video'], // Keep whatever you originally had
/**
* Check if the bid request is valid.
* Return false or true; it won't matter much if buildRequests is empty,
* but returning true prevents validation log errors for publishers.
*/
isBidRequestValid: function(bid) {
return false;
},
/**
* SHORT-CIRCUIT HERE: Return an empty array.
* Prebid core looks at this array to generate network calls.
* Empty array = 0 network requests made.
*/
buildRequests: function(validBidRequests, bidderRequest) {
// Add a console warning so developers checking logs know it's deprecated
utils.logWarn(`Prebid.js adapter '${BIDDER_CODE}' is deprecated and no longer active.`);
return [];
},
/**
* Since buildRequests returns nothing, interpretResponse will never be called.
* Keep it as an empty shell returning an empty array so the compiler stays happy.
*/
interpretResponse: function(serverResponse, bidRequest) {
return [];
},
/**
* Leave this as an empty shell returning an empty array.
*/
getUserSyncs: function(syncOptions, serverResponses, gdprConsent, uspConsent) {
return [];
}
};
registerBidder(spec);
**
|
Tread carefully! This PR adds 120 linter errors (possibly disabled through directives):
|
2 participants
Type of change
Description of change
Deprecates the ViewdeosDX bid adapter as it is no longer supported or maintained.
This change removes the adapter implementation from the codebase and ensures it is no longer included in the build or referenced by the module registry.
Changes included:
Other information
prebid/prebid.github.io#6607