Skip to content

Commit 16b6dd0

Browse files
fix comments
1 parent 9801715 commit 16b6dd0

2 files changed

Lines changed: 1 addition & 31 deletions

File tree

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,13 @@
11
package org.prebid.server.proto.openrtb.ext.request.beop;
22

3-
import com.fasterxml.jackson.annotation.JsonProperty;
43
import lombok.Value;
54

65
@Value(staticConstructor = "of")
76
public class ExtImpBeop {
87

9-
@JsonProperty("pid")
108
String pid;
119

12-
@JsonProperty("nid")
1310
String nid;
1411

15-
@JsonProperty("ntpnid")
1612
String ntpnid;
1713
}

src/test/java/org/prebid/server/bidder/beop/BeopBidderTest.java

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.prebid.server.bidder.beop;
22

33
import com.fasterxml.jackson.core.JsonProcessingException;
4-
import com.fasterxml.jackson.databind.node.ObjectNode;
54
import com.iab.openrtb.request.BidRequest;
65
import com.iab.openrtb.request.Imp;
76
import com.iab.openrtb.response.Bid;
@@ -70,7 +69,7 @@ public void makeHttpRequestsShouldCreateRequestWithPidInUri() {
7069
}
7170

7271
@Test
73-
public void makeHttpRequestsShouldCreateRequestWithNidAndNptnidInUri() {
72+
public void makeHttpRequestsShouldCreateRequestWithNidAndNtpnidInUri() {
7473
// given
7574
final BidRequest bidRequest = givenBidRequest(givenImp(ExtImpBeop.of(null, "networkId", "partnerId")));
7675

@@ -84,31 +83,6 @@ public void makeHttpRequestsShouldCreateRequestWithNidAndNptnidInUri() {
8483
.containsExactly(ENDPOINT_URL + "?nid=networkId&nptnid=partnerId");
8584
}
8685

87-
@Test
88-
public void makeHttpRequestsShouldAcceptLegacyNtpnidAlias() {
89-
// given
90-
final ObjectNode bidderNode = mapper.createObjectNode()
91-
.put("nid", "networkId")
92-
.put("ntpnid", "legacyPartnerId");
93-
final ObjectNode ext = mapper.createObjectNode();
94-
ext.set("bidder", bidderNode);
95-
96-
final Imp imp = Imp.builder()
97-
.id("imp-1")
98-
.ext(ext)
99-
.build();
100-
final BidRequest bidRequest = givenBidRequest(imp);
101-
102-
// when
103-
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
104-
105-
// then
106-
assertThat(result.getErrors()).isEmpty();
107-
assertThat(result.getValue()).hasSize(1)
108-
.extracting(HttpRequest::getUri)
109-
.containsExactly(ENDPOINT_URL + "?nid=networkId&nptnid=legacyPartnerId");
110-
}
111-
11286
@Test
11387
public void makeHttpRequestsShouldCreateRequestWithOriginalPayload() {
11488
// given

0 commit comments

Comments
 (0)