Skip to content

Commit 25a4386

Browse files
committed
Update after review
1 parent 330a099 commit 25a4386

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

src/test/groovy/org/prebid/server/functional/tests/TargetingSpec.groovy

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import org.prebid.server.functional.model.db.StoredRequest
1212
import org.prebid.server.functional.model.db.StoredResponse
1313
import org.prebid.server.functional.model.request.amp.AmpRequest
1414
import org.prebid.server.functional.model.request.auction.AdServerTargeting
15+
import org.prebid.server.functional.model.request.auction.App
1516
import org.prebid.server.functional.model.request.auction.BidRequest
1617
import org.prebid.server.functional.model.request.auction.Imp
1718
import org.prebid.server.functional.model.request.auction.MultiBid
@@ -20,6 +21,7 @@ import org.prebid.server.functional.model.request.auction.PrebidCache
2021
import org.prebid.server.functional.model.request.auction.PrebidStoredRequest
2122
import org.prebid.server.functional.model.request.auction.PriceGranularity
2223
import org.prebid.server.functional.model.request.auction.Range
24+
import org.prebid.server.functional.model.request.auction.Site
2325
import org.prebid.server.functional.model.request.auction.StoredAuctionResponse
2426
import org.prebid.server.functional.model.request.auction.StoredBidResponse
2527
import org.prebid.server.functional.model.request.auction.Targeting
@@ -1909,7 +1911,7 @@ class TargetingSpec extends BaseSpec {
19091911
def "PBS amp shouldn't emit error for targeting when site is array"() {
19101912
given: "Create targeting with array of site"
19111913
def anyRandomValue = PBSUtils.randomString
1912-
def targeting = ["site": [PBSUtils.randomString], "any" : anyRandomValue]
1914+
def targeting = ["site": siteValue, "any": anyRandomValue]
19131915

19141916
and: "Encode targeting to string"
19151917
def encodeTargeting = URLEncoder.encode(encode(targeting), StandardCharsets.UTF_8)
@@ -1935,6 +1937,10 @@ class TargetingSpec extends BaseSpec {
19351937

19361938
and: "Amp response shouldn't contain any errors"
19371939
assert !ampResponse.ext.errors
1940+
1941+
where:
1942+
siteValue << [null, [], [PBSUtils.randomString], [Site.defaultSite], [Site.defaultSite, PBSUtils.randomString],
1943+
[PBSUtils.randomString, Site.defaultSite], [App.defaultApp, Site.defaultSite]]
19381944
}
19391945

19401946
private static Account createAccountWithPriceGranularity(String accountId, PriceGranularityType priceGranularity) {

0 commit comments

Comments
 (0)