Add units

Author: CTMBNara

src/main/java/org/prebid/server/auction/externalortb/ProfilesProcessor.java

@@ -85,11 +85,21 @@ public Future<BidRequest> process(AuctionContext auctionContext, BidRequest bidR
             return Future.succeededFuture(bidRequest);
         }
 
+        final boolean failOnUnknown = isFailOnUnknown(auctionContext.getAccount());
+
         return fetchProfiles(accountId, profilesIds, timeoutMillis(bidRequest))
-                .compose(profiles -> emitMetrics(accountId, profiles, auctionContext))
+                .compose(profiles -> emitMetrics(accountId, profiles, auctionContext, failOnUnknown))
                 .map(profiles -> mergeResults(
-                        applyRequestProfiles(profilesIds.request(), profiles.getStoredIdToRequest(), bidRequest),
-                        applyImpsProfiles(profilesIds.imps(), profiles.getStoredIdToImp(), bidRequest.getImp())))
+                        applyRequestProfiles(
+                                profilesIds.request(),
+                                profiles.getStoredIdToRequest(),
+                                bidRequest,
+                                failOnUnknown),
+                        applyImpsProfiles(
+                                profilesIds.imps(),
+                                profiles.getStoredIdToImp(),
+                                bidRequest.getImp(),
+                                failOnUnknown)))
                 .recover(e -> Future.failedFuture(
                         new InvalidRequestException("Error during processing profiles: " + e.getMessage())));
     }
@@ -161,6 +171,14 @@ private long timeoutMillis(BidRequest bidRequest) {
         return tmax != null && tmax > 0 ? tmax : defaultTimeoutMillis;
     }
 
+    private boolean isFailOnUnknown(Account account) {
+        return Optional.ofNullable(account)
+                .map(Account::getAuction)
+                .map(AccountAuctionConfig::getProfiles)
+                .map(AccountProfilesConfig::getFailOnUnknown)
+                .orElse(failOnUnknown);
+    }
+
     private Future<StoredDataResult<Profile>> fetchProfiles(String accountId,
                                                             AllProfilesIds allProfilesIds,
                                                             long timeoutMillis) {
@@ -176,7 +194,8 @@ private Future<StoredDataResult<Profile>> fetchProfiles(String accountId,
 
     private Future<StoredDataResult<Profile>> emitMetrics(String accountId,
                                                           StoredDataResult<Profile> fetchResult,
-                                                          AuctionContext auctionContext) {
+                                                          AuctionContext auctionContext,
+                                                          boolean failOnUnknown) {
 
         final List<String> errors = fetchResult.getErrors();
         if (!errors.isEmpty()) {
@@ -197,17 +216,19 @@ private Future<StoredDataResult<Profile>> emitMetrics(String accountId,
 
     private BidRequest applyRequestProfiles(List<String> profilesIds,
                                             Map<String, Profile> idToRequestProfile,
-                                            BidRequest bidRequest) {
+                                            BidRequest bidRequest,
+                                            boolean failOnUnknown) {
 
         return !idToRequestProfile.isEmpty()
-                ? applyProfiles(profilesIds, idToRequestProfile, bidRequest, BidRequest.class)
+                ? applyProfiles(profilesIds, idToRequestProfile, bidRequest, BidRequest.class, failOnUnknown)
                 : bidRequest;
     }
 
     private <T> T applyProfiles(List<String> profilesIds,
                                 Map<String, Profile> idToProfile,
                                 T original,
-                                Class<T> tClass) {
+                                Class<T> tClass,
+                                boolean failOnUnknown) {
 
         if (profilesIds.isEmpty()) {
             return original;
@@ -244,20 +265,30 @@ private ObjectNode mergeProfile(ObjectNode original, Profile profile) {
     }
 
     private ObjectNode merge(JsonNode takePrecedence, JsonNode other) {
+        if (!takePrecedence.isObject() || !other.isObject()) {
+            throw new InvalidRequestException("One of the merge arguments is not an object.");
+        }
+
         return (ObjectNode) jsonMerger.merge(takePrecedence, other);
     }
 
     private List<Imp> applyImpsProfiles(List<List<String>> profilesIds,
                                         Map<String, Profile> idToImpProfile,
-                                        List<Imp> imps) {
+                                        List<Imp> imps,
+                                        boolean failOnUnknown) {
 
         if (idToImpProfile.isEmpty()) {
             return imps;
         }
 
         final List<Imp> updatedImps = new ArrayList<>(imps);
         for (int i = 0; i < profilesIds.size(); i++) {
-            updatedImps.set(i, applyProfiles(profilesIds.get(i), idToImpProfile, imps.get(i), Imp.class));
+            updatedImps.set(i, applyProfiles(
+                    profilesIds.get(i),
+                    idToImpProfile,
+                    imps.get(i),
+                    Imp.class,
+                    failOnUnknown));
         }
 
         return Collections.unmodifiableList(updatedImps);