Skip to content

Commit 3544c02

Browse files
committed
Add no_disclosed_vendors metric
1 parent 4dd80cb commit 3544c02

4 files changed

Lines changed: 7 additions & 2 deletions

File tree

src/main/java/org/prebid/server/metric/MetricName.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ public enum MetricName {
104104
specified,
105105
opt_out("opt-out"),
106106
invalid,
107+
no_disclosed_vendors("no-disclosed-vendors"),
107108
in_geo("in-geo"),
108109
out_geo("out-geo"),
109110
unknown_geo("unknown-geo"),

src/main/java/org/prebid/server/metric/Metrics.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -519,6 +519,10 @@ public void updatePrivacyTcfInvalidMetric() {
519519
privacy().tcf().incCounter(MetricName.invalid);
520520
}
521521

522+
public void updatePrivacyTcfNoDisclosedVendorsMetric() {
523+
privacy().tcf().incCounter(MetricName.no_disclosed_vendors);
524+
}
525+
522526
public void updatePrivacyTcfRequestsMetric(int version) {
523527
final UpdatableMetrics versionMetrics = privacy().tcf().fromVersion(version);
524528
versionMetrics.incCounter(MetricName.requests);

src/main/java/org/prebid/server/privacy/gdpr/TcfDefinerService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ private TCStringParsingResult parseConsentString(String consentString, RequestLo
352352
final String message = "Invalid TCF string: `disclosedVendors` list is empty.";
353353
warnings.add(message);
354354
logWarn(consentString, message, requestLogInfo);
355-
metrics.updatePrivacyTcfInvalidMetric();
355+
metrics.updatePrivacyTcfNoDisclosedVendorsMetric();
356356

357357
return TCStringParsingResult.of(TCStringEmpty.create(), warnings);
358358
}

src/test/java/org/prebid/server/privacy/gdpr/TcfDefinerServiceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,7 @@ public void resolveTcfContextShouldIncrementInvalidConsentStringMetricWhenDisclo
571571
assertThat(context.getWarnings()).containsExactly("Invalid TCF string: `disclosedVendors` list is empty.");
572572
});
573573

574-
verify(metrics).updatePrivacyTcfInvalidMetric();
574+
verify(metrics).updatePrivacyTcfNoDisclosedVendorsMetric();
575575
}
576576

577577
@Test

0 commit comments

Comments
 (0)