Floxis: declare ortb-version 2.6 + multi-imp seat guard + IT downconversion guard

Author: floxis-admin

src/main/java/org/prebid/server/bidder/floxis/FloxisBidder.java

@@ -63,7 +63,7 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request
 
         final ExtImpFloxis extImp;
         try {
-            extImp = parseImpExt(request.getImp().getFirst());
+            extImp = resolveCommonImpExt(request.getImp());
         } catch (PreBidException e) {
             return Result.withError(BidderError.badInput(e.getMessage()));
         }
@@ -79,6 +79,23 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request
                 .build());
     }
 
+    // A single request routes to one Floxis host/seat (the seat is the URL query key). All imps
+    // must therefore share the same seat and region; a mismatch is a misconfigured request rather
+    // than something to silently route on imp[0]'s key.
+    private ExtImpFloxis resolveCommonImpExt(List<Imp> imps) {
+        final ExtImpFloxis first = parseImpExt(imps.getFirst());
+        for (Imp imp : imps.subList(1, imps.size())) {
+            final ExtImpFloxis current = parseImpExt(imp);
+            if (!Objects.equals(current.getSeat(), first.getSeat())
+                    || !Objects.equals(current.getRegion(), first.getRegion())) {
+                throw new PreBidException(
+                        "all impressions must target the same Floxis seat and region; imp %s differs from imp %s"
+                                .formatted(imp.getId(), imps.getFirst().getId()));
+            }
+        }
+        return first;
+    }
+
     private ExtImpFloxis parseImpExt(Imp imp) {
         try {
             return mapper.mapper().convertValue(imp.getExt(), FLOXIS_EXT_TYPE_REFERENCE).getBidder();

src/main/resources/bidder-config/floxis.yaml

@@ -1,6 +1,7 @@
 adapters:
   floxis:
     endpoint: https://{{Host}}/pbs?seat={{SeatId}}
+    ortb-version: "2.6"
     modifying-vast-xml-allowed: false
     meta-info:
       maintainer-email: prebid@floxis.tech

src/test/java/org/prebid/server/bidder/floxis/FloxisBidderTest.java

@@ -154,13 +154,13 @@ public void makeHttpRequestsShouldDefaultToUseHostWhenRegionUnknown() {
     }
 
     @Test
-    public void makeHttpRequestsShouldRouteFromFirstImpAndForwardAllImps() {
+    public void makeHttpRequestsShouldRouteOnceAndForwardAllImpsWhenSeatAndRegionMatch() {
         // given
         final BidRequest bidRequest = BidRequest.builder()
                 .id("req-1")
                 .imp(asList(
                         givenImp(imp -> imp.id("imp-1").ext(givenImpExt("seat-eu", "eu"))),
-                        givenImp(imp -> imp.id("imp-2").ext(givenImpExt("seat-other", "apac")))))
+                        givenImp(imp -> imp.id("imp-2").ext(givenImpExt("seat-eu", "eu")))))
                 .site(Site.builder().id("271").build())
                 .build();
 
@@ -179,6 +179,50 @@ public void makeHttpRequestsShouldRouteFromFirstImpAndForwardAllImps() {
                 .containsExactly("imp-1", "imp-2");
     }
 
+    @Test
+    public void makeHttpRequestsShouldReturnErrorWhenImpsTargetDifferentSeat() {
+        // given
+        final BidRequest bidRequest = BidRequest.builder()
+                .id("req-1")
+                .imp(asList(
+                        givenImp(imp -> imp.id("imp-1").ext(givenImpExt("seat-eu", "eu"))),
+                        givenImp(imp -> imp.id("imp-2").ext(givenImpExt("seat-other", "eu")))))
+                .site(Site.builder().id("271").build())
+                .build();
+
+        // when
+        final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
+
+        // then
+        assertThat(result.getValue()).isEmpty();
+        assertThat(result.getErrors()).hasSize(1)
+                .containsOnly(BidderError.badInput(
+                        "all impressions must target the same Floxis seat and region; "
+                                + "imp imp-2 differs from imp imp-1"));
+    }
+
+    @Test
+    public void makeHttpRequestsShouldReturnErrorWhenImpsTargetDifferentRegion() {
+        // given
+        final BidRequest bidRequest = BidRequest.builder()
+                .id("req-1")
+                .imp(asList(
+                        givenImp(imp -> imp.id("imp-1").ext(givenImpExt("seat-eu", "eu"))),
+                        givenImp(imp -> imp.id("imp-2").ext(givenImpExt("seat-eu", "apac")))))
+                .site(Site.builder().id("271").build())
+                .build();
+
+        // when
+        final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
+
+        // then
+        assertThat(result.getValue()).isEmpty();
+        assertThat(result.getErrors()).hasSize(1)
+                .containsOnly(BidderError.badInput(
+                        "all impressions must target the same Floxis seat and region; "
+                                + "imp imp-2 differs from imp imp-1"));
+    }
+
     @Test
     public void makeHttpRequestsShouldForwardRequestBodyUnchanged() {
         // given

src/test/java/org/prebid/server/it/FloxisTest.java

@@ -8,6 +8,7 @@
 import java.io.IOException;
 
 import static com.github.tomakehurst.wiremock.client.WireMock.aResponse;
+import static com.github.tomakehurst.wiremock.client.WireMock.equalTo;
 import static com.github.tomakehurst.wiremock.client.WireMock.equalToJson;
 import static com.github.tomakehurst.wiremock.client.WireMock.post;
 import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo;
@@ -19,6 +20,7 @@ public class FloxisTest extends IntegrationTest {
     public void openrtb2AuctionShouldRespondWithBidsFromFloxis() throws IOException, JSONException {
         // given
         WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/floxis-exchange"))
+                .withQueryParam("seat", equalTo("pub-seat-1"))
                 .withRequestBody(equalToJson(jsonFrom("openrtb2/floxis/test-floxis-bid-request.json")))
                 .willReturn(aResponse().withBody(jsonFrom("openrtb2/floxis/test-floxis-bid-response.json"))));
 

src/test/resources/org/prebid/server/it/openrtb2/floxis/test-auction-floxis-request.json

@@ -14,6 +14,19 @@
       }
     }
   ],
+  "source": {
+    "schain": {
+      "complete": 1,
+      "ver": "1.0",
+      "nodes": [
+        {
+          "asi": "floxis.tech",
+          "sid": "pub-seat-1",
+          "hp": 1
+        }
+      ]
+    }
+  },
   "regs": {
     "ext": {
       "gdpr": 0

src/test/resources/org/prebid/server/it/openrtb2/floxis/test-floxis-bid-request.json

@@ -17,7 +17,18 @@
     }
   ],
   "source": {
-    "tid": "${json-unit.any-string}"
+    "tid": "${json-unit.any-string}",
+    "schain": {
+      "complete": 1,
+      "ver": "1.0",
+      "nodes": [
+        {
+          "asi": "floxis.tech",
+          "sid": "pub-seat-1",
+          "hp": 1
+        }
+      ]
+    }
   },
   "site": {
     "domain": "www.example.com",
@@ -39,9 +50,7 @@
     "USD"
   ],
   "regs": {
-    "ext": {
-      "gdpr": 0
-    }
+    "gdpr": 0
   },
   "ext": {
     "prebid": {