Skip to content

Commit 66f1f86

Browse files
Code cleanup
1 parent 7297dcd commit 66f1f86

3 files changed

Lines changed: 2 additions & 7 deletions

File tree

extra/modules/wurfl-devicedetection/src/main/java/org/prebid/server/hooks/modules/com/scientiamobile/wurfl/devicedetection/v1/OrtbDeviceUpdater.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ private String getWurflModel() {
103103
}
104104

105105
private Integer getWurflDeviceType() {
106-
107106
try {
108107
if (wurflDevice.getVirtualCapabilityAsBool("is_mobile")) {
109108
// if at least one of these capabilities is not defined, the mobile device type is undefined
@@ -133,6 +132,7 @@ private Integer getWurflDeviceType() {
133132
}
134133
} catch (CapabilityNotDefinedException | VirtualCapabilityNotDefinedException | NumberFormatException e) {
135134
logger.warn("Failed to determine device type from WURFL device capabilities", e);
135+
return null;
136136
}
137137
return null;
138138
}

extra/modules/wurfl-devicedetection/src/main/java/org/prebid/server/hooks/modules/com/scientiamobile/wurfl/devicedetection/v1/WURFLDeviceDetectionRawAuctionRequestHook.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,6 @@ public Future<InvocationResult<AuctionRequestPayload>> call(AuctionRequestPayloa
5656
}
5757

5858
final BidRequest bidRequest = auctionRequestPayload.bidRequest();
59-
if (bidRequest.getDevice() == null) {
60-
logger.warn("BidRequest is null");
61-
return noActionResult();
62-
}
63-
6459
final Device device = bidRequest.getDevice();
6560
if (device == null) {
6661
logger.warn("Device is null");

extra/modules/wurfl-devicedetection/src/test/java/org/prebid/server/hooks/modules/com/scientiamobile/wurfl/devicedetection/v1/WURFLDeviceDetectionModuleTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
import static org.assertj.core.api.Assertions.assertThat;
1212

13-
class WURFLDeviceDetectionModuleTest {
13+
public class WURFLDeviceDetectionModuleTest {
1414

1515
@Test
1616
public void codeShouldReturnCorrectModuleCode() {

0 commit comments

Comments
 (0)