Skip to content

Commit 6823ce6

Browse files
committed
Refactoring.
1 parent 5372661 commit 6823ce6

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/main/java/org/prebid/server/auction/ExchangeService.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,7 @@ private User prepareUser(String bidder,
627627
final ExtUser extUser = user != null ? user.getExt() : null;
628628
final UpdateResult<String> buyerUidUpdateResult = uidUpdater.updateUid(bidder, context, aliases);
629629
final List<Eid> userEids = extractUserEids(user);
630-
final List<Eid> allowedUserEids = resolveAllowedEids(userEids, bidder, eidPermissionHolder);
630+
final List<Eid> allowedUserEids = eidPermissionHolder.resolveAllowedEids(userEids, bidder);
631631
final boolean shouldUpdateUserEids = allowedUserEids.size() != CollectionUtils.emptyIfNull(userEids).size();
632632
final boolean shouldCleanExtPrebid = extUser != null && extUser.getPrebid() != null;
633633
final boolean shouldCleanExtData = extUser != null && extUser.getData() != null && !useFirstPartyData;
@@ -667,13 +667,6 @@ private List<Eid> extractUserEids(User user) {
667667
return user != null ? user.getEids() : null;
668668
}
669669

670-
private List<Eid> resolveAllowedEids(List<Eid> userEids, String bidder, EidPermissionHolder eidPermissionHolder) {
671-
return CollectionUtils.emptyIfNull(userEids)
672-
.stream()
673-
.filter(userEid -> eidPermissionHolder.isAllowed(userEid, bidder))
674-
.toList();
675-
}
676-
677670
private List<AuctionParticipation> getAuctionParticipation(
678671
List<BidderPrivacyResult> bidderPrivacyResults,
679672
BidRequest bidRequest,

src/main/java/org/prebid/server/auction/model/EidPermissionHolder.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,14 @@ public static EidPermissionHolder empty() {
3838
return EMPTY;
3939
}
4040

41-
public boolean isAllowed(Eid eid, String bidder) {
41+
public List<Eid> resolveAllowedEids(List<Eid> userEids, String bidder) {
42+
return CollectionUtils.emptyIfNull(userEids)
43+
.stream()
44+
.filter(userEid -> isAllowed(userEid, bidder))
45+
.toList();
46+
}
47+
48+
private boolean isAllowed(Eid eid, String bidder) {
4249
final Map<Integer, List<ExtRequestPrebidDataEidPermissions>> matchingRulesBySpecificity = eidPermissions
4350
.stream()
4451
.filter(rule -> isRuleMatched(eid, rule))

0 commit comments

Comments
 (0)