Fix comments

Author: AntoxaAntoxic

src/test/java/org/prebid/server/bidadjustments/FloorAdjustmentsResolverTest.java

@@ -14,7 +14,6 @@
 import org.prebid.server.proto.openrtb.ext.request.ImpMediaType;
 
 import java.math.BigDecimal;
-import java.math.RoundingMode;
 import java.util.Collections;
 import java.util.List;
 import java.util.Set;
@@ -44,7 +43,7 @@ public class FloorAdjustmentsResolverTest extends VertxTest {
     private static final String EUR = "EUR";
     private static final String UAH = "UAH";
 
-    @Mock(strictness = LENIENT)
+    @Mock
     private CurrencyConversionService currencyService;
 
     @Mock(strictness = LENIENT)
@@ -55,22 +54,6 @@ public class FloorAdjustmentsResolverTest extends VertxTest {
     @BeforeEach
     public void before() {
         target = new FloorAdjustmentsResolver(bidAdjustmentsRulesResolver, currencyService);
-
-        given(currencyService.convertCurrency(any(), any(), any(), any())).willAnswer(invocation -> {
-            final BigDecimal amount = invocation.getArgument(0);
-            final String fromCurrency = invocation.getArgument(2);
-            final String toCurrency = invocation.getArgument(3);
-
-            if (fromCurrency.equals(toCurrency)) {
-                return amount;
-            } else if (toCurrency.equals(USD)) {
-                return amount.divide(BigDecimal.TEN, 4, RoundingMode.HALF_EVEN);
-            } else if (fromCurrency.equals(USD)) {
-                return amount.multiply(BigDecimal.TEN);
-            } else {
-                return amount;
-            }
-        });
     }
 
     @Test
@@ -84,13 +67,14 @@ public void resolveShouldReturnInitialPriceWhenNoRulesFoundForAnyMediaType() {
                 .willReturn(Collections.emptyList());
         given(bidAdjustmentsRulesResolver.resolve(bidRequest, video_outstream, BIDDER_NAME, null))
                 .willReturn(Collections.emptyList());
+        given(currencyService.convertCurrency(BigDecimal.TEN, bidRequest, USD, USD)).willReturn(BigDecimal.TEN);
 
         // when
         final Price actual = target.resolve(initialPrice, bidRequest, mediaTypes, BIDDER_NAME);
 
         // then
         assertThat(actual).isEqualTo(initialPrice);
-        verify(currencyService, times(2)).convertCurrency(BigDecimal.TEN, bidRequest, USD, USD);
+        verify(currencyService, times(2)).convertCurrency(any(), any(), any(), any());
         verifyNoMoreInteractions(currencyService);
     }
 
@@ -105,14 +89,16 @@ public void resolveShouldApplyMultiplierRuleInReverse() {
 
         given(bidAdjustmentsRulesResolver.resolve(bidRequest, banner, BIDDER_NAME, null))
                 .willReturn(singletonList(multiplierRule));
+        given(currencyService.convertCurrency(eq(new BigDecimal("10.0000")), eq(bidRequest), eq(USD), eq(USD)))
+                .willReturn(BigDecimal.valueOf(20));
 
         // when
         final Price actual = target.resolve(initialPrice, bidRequest, mediaTypes, BIDDER_NAME);
 
         // then
         assertThat(actual).isEqualTo(Price.of(USD, new BigDecimal("10.0000")));
 
-        verify(currencyService).convertCurrency(eq(new BigDecimal("10.0000")), eq(bidRequest), eq(USD), eq(USD));
+        verify(currencyService).convertCurrency(any(), any(), any(), any());
         verifyNoMoreInteractions(currencyService);
     }
 
@@ -127,6 +113,10 @@ public void resolveShouldApplyCpmRuleInReverse() {
 
         given(bidAdjustmentsRulesResolver.resolve(bidRequest, banner, BIDDER_NAME, null))
                 .willReturn(singletonList(cpmRule));
+        given(currencyService.convertCurrency(new BigDecimal("5"), bidRequest, EUR, USD))
+                .willReturn(BigDecimal.valueOf(0.5));
+        given(currencyService.convertCurrency(new BigDecimal("50.5"), bidRequest, USD, USD))
+                .willReturn(BigDecimal.valueOf(50));
 
         // when
         final Price actual = target.resolve(initialPrice, bidRequest, mediaTypes, BIDDER_NAME);
@@ -135,8 +125,7 @@ public void resolveShouldApplyCpmRuleInReverse() {
         final Price expectedPrice = Price.of(USD, new BigDecimal("50.5"));
         assertThat(actual).isEqualTo(expectedPrice);
 
-        verify(currencyService).convertCurrency(new BigDecimal("5"), bidRequest, EUR, USD);
-        verify(currencyService).convertCurrency(new BigDecimal("50.5"), bidRequest, USD, USD);
+        verify(currencyService, times(2)).convertCurrency(any(), any(), any(), any());
         verifyNoMoreInteractions(currencyService);
     }
 
@@ -172,15 +161,18 @@ public void resolveShouldApplyMultipleRulesInReverseOrder() {
 
         given(bidAdjustmentsRulesResolver.resolve(bidRequest, banner, BIDDER_NAME, null))
                 .willReturn(List.of(rule1, rule2));
+        given(currencyService.convertCurrency(new BigDecimal("5"), bidRequest, EUR, USD))
+                .willReturn(BigDecimal.valueOf(0.5));
+        given(currencyService.convertCurrency(new BigDecimal("50.2500"), bidRequest, USD, USD))
+                .willReturn(BigDecimal.valueOf(100));
 
         // when
         final Price actual = target.resolve(initialPrice, bidRequest, mediaTypes, BIDDER_NAME);
 
         // then
         assertThat(actual).isEqualTo(Price.of(USD, new BigDecimal("50.2500")));
 
-        verify(currencyService).convertCurrency(new BigDecimal("5"), bidRequest, EUR, USD);
-        verify(currencyService).convertCurrency(new BigDecimal("50.2500"), bidRequest, USD, USD);
+        verify(currencyService, times(2)).convertCurrency(any(), any(), any(), any());
         verifyNoMoreInteractions(currencyService);
     }
 
@@ -199,15 +191,20 @@ public void resolveShouldChooseMinimalFloorAcrossMediaTypesAfterConversion() {
         given(bidAdjustmentsRulesResolver.resolve(bidRequest, video_outstream, BIDDER_NAME, null))
                 .willReturn(singletonList(videoRule));
 
+        given(currencyService.convertCurrency(new BigDecimal("25.0000"), bidRequest, USD, EUR))
+                .willReturn(new BigDecimal("250.0000"));
+        given(currencyService.convertCurrency(new BigDecimal("500"), bidRequest, UAH, USD))
+                .willReturn(new BigDecimal("50"));
+        given(currencyService.convertCurrency(new BigDecimal("150"), bidRequest, USD, EUR))
+                .willReturn(new BigDecimal("1500"));
+
         // when
         final Price actual = target.resolve(initialPrice, bidRequest, mediaTypes, BIDDER_NAME);
 
         // then
         assertThat(actual).isEqualTo(Price.of(USD, new BigDecimal("25.0000")));
 
-        verify(currencyService).convertCurrency(new BigDecimal("25.0000"), bidRequest, USD, EUR);
-        verify(currencyService).convertCurrency(new BigDecimal("500"), bidRequest, UAH, USD);
-        verify(currencyService).convertCurrency(new BigDecimal("150"), bidRequest, USD, EUR);
+        verify(currencyService, times(3)).convertCurrency(any(), any(), any(), any());
         verifyNoMoreInteractions(currencyService);
     }