arg-ttd-exception-for-malformed-endpoint

Author: andre-gielow-ttd

src/main/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidder.java

@@ -90,9 +90,17 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request
         }
 
         final BidRequest outgoingRequest = modifyRequest(request, modifiedImps, publisherId);
+        
+        final String endpoint;
+        try {
+            endpoint = resolveEndpoint(sourceSupplyId);
+        } catch (PreBidException e) {
+            return Result.withError(BidderError.badInput(e.getMessage()));
+        }
+        
         final HttpRequest<BidRequest> httpRequest = BidderUtil.defaultRequest(
                 outgoingRequest,
-                resolveEndpoint(sourceSupplyId),
+                endpoint,
                 mapper);
 
         return Result.withValue(httpRequest);
@@ -166,6 +174,10 @@ private static App modifyApp(BidRequest request, String publisherId) {
     }
 
     private String resolveEndpoint(String sourceSupplyId) {
+        if (StringUtils.isBlank(sourceSupplyId) && StringUtils.isBlank(supplyId)) {
+            throw new PreBidException("Either supplySourceId or a default endpoint must be provided");
+        }
+
         return endpointUrl.replace(
                 SUPPLY_ID_MACRO,
                 HttpUtil.encodeUrl(StringUtils.defaultString(ObjectUtils.defaultIfNull(sourceSupplyId, supplyId))));

src/test/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidderTest.java

@@ -186,6 +186,21 @@ public void makeHttpRequestsShouldReturnErrorWhenImpExtCouldNotBeParsed() {
         assertThat(result.getValue()).isEmpty();
     }
 
+    @Test
+    public void makeHttpRequestsShouldReturnErrorWhenBothSupplySourceIdAndSupplyIdAreNull() {
+        final TheTradeDeskBidder bidderWithNullSupplyId = new TheTradeDeskBidder(ENDPOINT_URL, jacksonMapper, null);
+        final BidRequest bidRequest = givenBidRequest(
+                identity(),
+                imp -> imp.ext(impExt("publisher", null)));
+
+        final Result<List<HttpRequest<BidRequest>>> result = bidderWithNullSupplyId.makeHttpRequests(bidRequest);
+
+        assertThat(result.getErrors()).hasSize(1);
+        assertThat(result.getErrors().getFirst().getMessage())
+                .isEqualTo("Either supplySourceId or a default endpoint must be provided");
+        assertThat(result.getValue()).isEmpty();
+    }
+
     @Test
     public void makeHttpRequestsShouldReturnSiteWithExtImpPublisherWhenSiteAndAppArePresent() {
         final BidRequest bidRequest = givenBidRequest(