Skip to content

Commit 6f23995

Browse files
committed
Updates after merge
1 parent 2231e23 commit 6f23995

1 file changed

Lines changed: 8 additions & 15 deletions

File tree

src/main/java/org/prebid/server/bidder/beop/BeopBidder.java

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import com.iab.openrtb.response.SeatBid;
99
import org.apache.commons.collections4.CollectionUtils;
1010
import org.apache.commons.lang3.StringUtils;
11-
import org.apache.http.client.utils.URIBuilder;
1211
import org.prebid.server.bidder.Bidder;
1312
import org.prebid.server.bidder.model.BidderBid;
1413
import org.prebid.server.bidder.model.BidderCall;
@@ -22,9 +21,8 @@
2221
import org.prebid.server.proto.openrtb.ext.request.beop.ExtImpBeop;
2322
import org.prebid.server.proto.openrtb.ext.response.BidType;
2423
import org.prebid.server.util.BidderUtil;
25-
import org.prebid.server.util.HttpUtil;
24+
import org.prebid.server.util.Uri;
2625

27-
import java.net.URISyntaxException;
2826
import java.util.ArrayList;
2927
import java.util.Collection;
3028
import java.util.List;
@@ -35,11 +33,11 @@ public class BeopBidder implements Bidder<BidRequest> {
3533
private static final TypeReference<ExtPrebid<?, ExtImpBeop>> BEOP_EXT_TYPE_REFERENCE = new TypeReference<>() {
3634
};
3735

38-
private final String endpointUrl;
36+
private final Uri endpointUrl;
3937
private final JacksonMapper mapper;
4038

4139
public BeopBidder(String endpointUrl, JacksonMapper mapper) {
42-
this.endpointUrl = HttpUtil.validateUrl(Objects.requireNonNull(endpointUrl));
40+
this.endpointUrl = Uri.of(endpointUrl);
4341
this.mapper = Objects.requireNonNull(mapper);
4442
}
4543

@@ -73,29 +71,24 @@ private ExtImpBeop parseImpExt(Imp imp) {
7371
}
7472

7573
private String buildEndpointUrl(ExtImpBeop ext) {
76-
final URIBuilder uriBuilder;
77-
try {
78-
uriBuilder = new URIBuilder(endpointUrl);
79-
} catch (URISyntaxException e) {
80-
throw new PreBidException("Invalid endpoint URL: " + e.getMessage());
81-
}
74+
final Uri.ParameterizedUri uriBuilder = endpointUrl.parameterized();
8275

8376
final String pid = StringUtils.trimToNull(ext.getPid());
8477
if (StringUtils.isNotEmpty(pid)) {
85-
uriBuilder.addParameter("pid", pid);
78+
uriBuilder.addQueryParam("pid", pid);
8679
}
8780

8881
final String nid = StringUtils.trimToNull(ext.getNid());
8982
if (StringUtils.isNotEmpty(nid)) {
90-
uriBuilder.addParameter("nid", nid);
83+
uriBuilder.addQueryParam("nid", nid);
9184
}
9285

9386
final String nptnid = StringUtils.trimToNull(ext.getNtpnid());
9487
if (StringUtils.isNotEmpty(nptnid)) {
95-
uriBuilder.addParameter("nptnid", nptnid);
88+
uriBuilder.addQueryParam("nptnid", nptnid);
9689
}
9790

98-
return uriBuilder.toString();
91+
return uriBuilder.expand();
9992
}
10093

10194
@Override

0 commit comments

Comments
 (0)