Skip to content

Commit 7162ee8

Browse files
committed
Remove support-cors related code
1 parent 71924ee commit 7162ee8

11 files changed

Lines changed: 11 additions & 34 deletions

File tree

src/main/java/org/prebid/server/bidder/UsersyncInfoBuilder.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ public class UsersyncInfoBuilder {
1414
private String usersyncUrl;
1515
private String redirectUrl;
1616
private UsersyncMethodType type;
17-
private Boolean supportCORS;
1817

1918
public static UsersyncInfoBuilder from(UsersyncMethod usersyncMethod) {
2019
final UsersyncInfoBuilder usersyncInfoBuilder = new UsersyncInfoBuilder();
@@ -23,7 +22,6 @@ public static UsersyncInfoBuilder from(UsersyncMethod usersyncMethod) {
2322
StringUtils.stripToEmpty(usersyncMethod.getRedirectUrl()),
2423
UsersyncUtil.resolveFormat(usersyncMethod));
2524
usersyncInfoBuilder.type = usersyncMethod.getType();
26-
usersyncInfoBuilder.supportCORS = usersyncMethod.isSupportCORS();
2725

2826
return usersyncInfoBuilder;
2927
}
@@ -88,7 +86,7 @@ public UsersyncInfo build() {
8886
final String resolvedUsersyncUrl = usersyncUrl.replace(
8987
UsersyncInfo.REDIRECT_URL_PLACEHOLDER, resolvedRedirectUrl);
9088

91-
return UsersyncInfo.of(resolvedUsersyncUrl, type, supportCORS);
89+
return UsersyncInfo.of(resolvedUsersyncUrl, type);
9290
}
9391

9492
private static String resolveQueryParams(String redirectUrl) {

src/main/java/org/prebid/server/bidder/UsersyncMethod.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,5 @@ public class UsersyncMethod {
1313

1414
String redirectUrl;
1515

16-
boolean supportCORS;
17-
1816
UsersyncFormat formatOverride;
1917
}

src/main/java/org/prebid/server/proto/response/UsersyncInfo.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package org.prebid.server.proto.response;
22

3-
import com.fasterxml.jackson.annotation.JsonProperty;
43
import lombok.Value;
54
import org.prebid.server.bidder.UsersyncMethodType;
65

@@ -22,7 +21,4 @@ public class UsersyncInfo {
2221
String url;
2322

2423
UsersyncMethodType type;
25-
26-
@JsonProperty("supportCORS")
27-
Boolean supportCORS;
2824
}

src/main/java/org/prebid/server/spring/config/bidder/model/usersync/UsersyncMethodConfigurationProperties.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import org.springframework.validation.annotation.Validated;
77

88
import jakarta.validation.constraints.NotBlank;
9-
import jakarta.validation.constraints.NotNull;
109

1110
@Data
1211
@Validated
@@ -18,8 +17,5 @@ public class UsersyncMethodConfigurationProperties {
1817

1918
String uidMacro;
2019

21-
@NotNull
22-
Boolean supportCors;
23-
2420
UsersyncFormat formatOverride;
2521
}

src/main/java/org/prebid/server/spring/config/bidder/util/UsersyncerCreator.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ private static UsersyncMethod toMethod(UsersyncMethodType type,
5656
.type(type)
5757
.usersyncUrl(Objects.requireNonNull(properties.getUrl()))
5858
.redirectUrl(toRedirectUrl(cookieFamilyName, externalUrl, properties.getUidMacro()))
59-
.supportCORS(properties.getSupportCors())
6059
.formatOverride(properties.getFormatOverride())
6160
.build();
6261
}

src/test/java/org/prebid/server/bidder/UsersyncInfoBuilderTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@ private static UsersyncMethod createUsersyncMethod(String usersyncUrl, String re
168168
.type(UsersyncMethodType.REDIRECT)
169169
.usersyncUrl(usersyncUrl)
170170
.redirectUrl(redirectUrl)
171-
.supportCORS(false)
172171
.build();
173172
}
174173
}

src/test/java/org/prebid/server/bidder/UsersyncMethodChooserTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,6 @@ private UsersyncMethod iframeMethod(String url) {
337337
.type(UsersyncMethodType.IFRAME)
338338
.usersyncUrl(url)
339339
.redirectUrl(null)
340-
.supportCORS(false)
341340
.build();
342341
}
343342

@@ -346,7 +345,6 @@ private UsersyncMethod redirectMethod(String url) {
346345
.type(UsersyncMethodType.REDIRECT)
347346
.usersyncUrl(url)
348347
.redirectUrl(null)
349-
.supportCORS(false)
350348
.build();
351349
}
352350
}

src/test/java/org/prebid/server/cookie/CookieSyncServiceTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1029,7 +1029,7 @@ public void prepareResponseShouldReturnWarningForAliasesSyncedAsRootCookieFamily
10291029
final BidderUsersyncStatus validStatus = BidderUsersyncStatus.builder()
10301030
.bidder("root-cookie-family")
10311031
.noCookie(true)
1032-
.usersync(UsersyncInfo.of("https://alias-usersync-url.com", UsersyncMethodType.IFRAME, false))
1032+
.usersync(UsersyncInfo.of("https://alias-usersync-url.com", UsersyncMethodType.IFRAME))
10331033
.build();
10341034

10351035
assertThat(result.getBidderStatus()).containsExactlyInAnyOrder(validStatus, warningStatus);
@@ -1056,7 +1056,7 @@ public void prepareResponseShouldNotReturnWarningForAliasesSyncedAsAliasCookieFa
10561056
final BidderUsersyncStatus status = BidderUsersyncStatus.builder()
10571057
.bidder("alias-cookie-family")
10581058
.noCookie(true)
1059-
.usersync(UsersyncInfo.of("https://alias-usersync-url.com", UsersyncMethodType.IFRAME, false))
1059+
.usersync(UsersyncInfo.of("https://alias-usersync-url.com", UsersyncMethodType.IFRAME))
10601060
.build();
10611061

10621062
assertThat(result.getBidderStatus()).containsExactly(status);
@@ -1084,7 +1084,7 @@ public void prepareResponseShouldReturnErrorForBiddersThatWereNotIncludedInRespo
10841084
final BidderUsersyncStatus validStatus = BidderUsersyncStatus.builder()
10851085
.bidder("bidder1-cookie-family")
10861086
.noCookie(true)
1087-
.usersync(UsersyncInfo.of("https://bidder1-usersync-url.com", UsersyncMethodType.IFRAME, false))
1087+
.usersync(UsersyncInfo.of("https://bidder1-usersync-url.com", UsersyncMethodType.IFRAME))
10881088
.build();
10891089

10901090
assertThat(result.getBidderStatus()).containsExactlyInAnyOrder(validStatus, warningStatus);
@@ -1122,7 +1122,7 @@ public void prepareResponseShouldReturnCustomUsersyncUrlForHostCookieSync() {
11221122
final BidderUsersyncStatus status = BidderUsersyncStatus.builder()
11231123
.noCookie(true)
11241124
.bidder("host-bidder-cookie-family")
1125-
.usersync(UsersyncInfo.of(expectedUrl, UsersyncMethodType.IFRAME, false))
1125+
.usersync(UsersyncInfo.of(expectedUrl, UsersyncMethodType.IFRAME))
11261126
.build();
11271127

11281128
assertThat(result.getBidderStatus()).containsExactly(status);
@@ -1160,7 +1160,7 @@ public void prepareResponseShouldReturnResponseWithWarningsIfNotEmpty() {
11601160
final BidderUsersyncStatus status = BidderUsersyncStatus.builder()
11611161
.noCookie(true)
11621162
.bidder("host-bidder-cookie-family")
1163-
.usersync(UsersyncInfo.of(expectedUrl, UsersyncMethodType.IFRAME, false))
1163+
.usersync(UsersyncInfo.of(expectedUrl, UsersyncMethodType.IFRAME))
11641164
.build();
11651165

11661166
assertThat(result.getBidderStatus()).containsExactly(status);
@@ -1199,7 +1199,7 @@ public void prepareResponseShouldReturnResponseWithoutWarningsIfEmpty() {
11991199
final BidderUsersyncStatus status = BidderUsersyncStatus.builder()
12001200
.noCookie(true)
12011201
.bidder("host-bidder-cookie-family")
1202-
.usersync(UsersyncInfo.of(expectedUrl, UsersyncMethodType.IFRAME, false))
1202+
.usersync(UsersyncInfo.of(expectedUrl, UsersyncMethodType.IFRAME))
12031203
.build();
12041204

12051205
assertThat(result.getBidderStatus()).containsExactly(status);

src/test/java/org/prebid/server/handler/SetuidHandlerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -897,10 +897,10 @@ private static UidsCookie emptyUidsCookie() {
897897
}
898898

899899
private static UsersyncMethod iframeMethod() {
900-
return UsersyncMethod.builder().type(UsersyncMethodType.IFRAME).supportCORS(false).build();
900+
return UsersyncMethod.builder().type(UsersyncMethodType.IFRAME).build();
901901
}
902902

903903
private static UsersyncMethod redirectMethod() {
904-
return UsersyncMethod.builder().type(UsersyncMethodType.REDIRECT).supportCORS(false).build();
904+
return UsersyncMethod.builder().type(UsersyncMethodType.REDIRECT).build();
905905
}
906906
}

src/test/java/org/prebid/server/it/ApplicationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ public void cookieSyncShouldReturnBidderStatusWithExpectedUsersyncInfo() {
326326
+ "&gpp_sid="
327327
+ "&f=i"
328328
+ "&uid=host-cookie-uid",
329-
UsersyncMethodType.REDIRECT, false))
329+
UsersyncMethodType.REDIRECT))
330330
.build(),
331331
BidderUsersyncStatus.builder()
332332
.bidder(APPNEXUS_COOKIE_FAMILY)
@@ -339,7 +339,7 @@ public void cookieSyncShouldReturnBidderStatusWithExpectedUsersyncInfo() {
339339
+ "%26gpp_sid%3D"
340340
+ "%26f%3Db"
341341
+ "%26uid%3D%24UID",
342-
UsersyncMethodType.IFRAME, false))
342+
UsersyncMethodType.IFRAME))
343343
.build());
344344
}
345345

0 commit comments

Comments
 (0)