Skip to content

Commit 73ff58e

Browse files
committed
Resolve conversations
1 parent fa8dfa2 commit 73ff58e

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

src/test/java/org/prebid/server/auction/bidderrequestpostprocessor/BidderRequestCleanerTest.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import org.prebid.server.proto.openrtb.ext.request.ExtRequest;
1212
import org.prebid.server.proto.openrtb.ext.request.ExtRequestBidAdjustmentFactors;
1313
import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebid;
14+
import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebidAdservertargetingRule;
1415
import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebidAlternateBidderCodes;
1516
import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebidAlternateBidderCodesBidder;
1617
import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebidCache;
@@ -21,9 +22,8 @@
2122
import java.util.Map;
2223
import java.util.function.UnaryOperator;
2324

24-
import static java.util.Collections.emptyList;
25-
import static java.util.Collections.emptyMap;
2625
import static java.util.Collections.singleton;
26+
import static java.util.Collections.singletonList;
2727
import static java.util.function.UnaryOperator.identity;
2828
import static org.assertj.core.api.Assertions.assertThat;
2929

@@ -63,6 +63,7 @@ public void processShouldCleanBidAdjustmentFactors() {
6363
final ExtRequestBidAdjustmentFactors factors = ExtRequestBidAdjustmentFactors.builder()
6464
.mediatypes(mediaTypes)
6565
.build();
66+
factors.addFactor("other", BigDecimal.ONE);
6667
factors.addFactor("bIdder", BigDecimal.ONE);
6768

6869
final BidderRequest bidderRequest = givenBidderRequest(extPrebid -> extPrebid.bidadjustmentfactors(factors));
@@ -198,7 +199,7 @@ public void processShouldRemoveReturnAllBidStatus() {
198199
@Test
199200
public void processShouldRemoveAliasGvlIds() {
200201
// given
201-
final BidderRequest bidderRequest = givenBidderRequest(extPrebid -> extPrebid.aliasgvlids(emptyMap()));
202+
final BidderRequest bidderRequest = givenBidderRequest(extPrebid -> extPrebid.aliasgvlids(Map.of("a", 1)));
202203

203204
// when
204205
final BidderRequestPostProcessingResult result = target.process(bidderRequest, null, null).result();
@@ -216,7 +217,8 @@ public void processShouldRemoveAliasGvlIds() {
216217
@Test
217218
public void processShouldRemoveAdServerTargeting() {
218219
// given
219-
final BidderRequest bidderRequest = givenBidderRequest(extPrebid -> extPrebid.adservertargeting(emptyList()));
220+
final BidderRequest bidderRequest = givenBidderRequest(extPrebid -> extPrebid.adservertargeting(
221+
singletonList(ExtRequestPrebidAdservertargetingRule.of(null, null, null))));
220222

221223
// when
222224
final BidderRequestPostProcessingResult result = target.process(bidderRequest, null, null).result();
@@ -272,7 +274,7 @@ public void processShouldRemoveEvents() {
272274
@Test
273275
public void processShouldRemoveNoSale() {
274276
// given
275-
final BidderRequest bidderRequest = givenBidderRequest(extPrebid -> extPrebid.nosale(emptyList()));
277+
final BidderRequest bidderRequest = givenBidderRequest(extPrebid -> extPrebid.nosale(singletonList("s")));
276278

277279
// when
278280
final BidderRequestPostProcessingResult result = target.process(bidderRequest, null, null).result();

0 commit comments

Comments
 (0)