Skip to content

Commit 74f6a25

Browse files
committed
hides mapper into givenHttpCall and fixes integration test
1 parent 996d96f commit 74f6a25

2 files changed

Lines changed: 15 additions & 5 deletions

File tree

src/test/java/org/prebid/server/bidder/seedtag/SeedtagBidderTest.java

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ public void makeBidsShouldReturnEmptyListIfBidResponseIsNull() throws JsonProces
145145
@Test
146146
public void makeBidsShouldReturnEmptyListIfBidResponseSeatBidIsNull() throws JsonProcessingException {
147147
// given
148-
final BidderCall<BidRequest> httpCall = givenHttpCall(mapper.writeValueAsString(BidResponse.builder().build()));
148+
final BidderCall<BidRequest> httpCall = givenHttpCall(BidResponse.builder().build());
149149

150150
// when
151151
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
@@ -176,7 +176,7 @@ public void makeBidsShouldReturnErrorIfResponseBodyCouldNotBeParsed() {
176176
public void makeBidsShouldReturnBannerBidIfMediaTypeBanner() throws JsonProcessingException {
177177
// given
178178
final BidderCall<BidRequest> httpCall = givenHttpCall(
179-
mapper.writeValueAsString(givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(1))));
179+
givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(1)));
180180

181181
// when
182182
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
@@ -191,7 +191,7 @@ public void makeBidsShouldReturnBannerBidIfMediaTypeBanner() throws JsonProcessi
191191
public void makeBidsShouldReturnVideoBidIfMediaTypeVideo() throws JsonProcessingException {
192192
// given
193193
final BidderCall<BidRequest> httpCall = givenHttpCall(
194-
mapper.writeValueAsString(givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(2))));
194+
givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(2)));
195195

196196
// when
197197
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
@@ -206,7 +206,7 @@ public void makeBidsShouldReturnVideoBidIfMediaTypeVideo() throws JsonProcessing
206206
public void makeBidsShouldReturnErrorIfMediaTypeInvalid() throws JsonProcessingException {
207207
// given
208208
final BidderCall<BidRequest> httpCall = givenHttpCall(
209-
mapper.writeValueAsString(givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(4).id("456"))));
209+
givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(4).id("456")));
210210

211211
// when
212212
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
@@ -248,4 +248,11 @@ private static BidResponse givenBidResponse(UnaryOperator<Bid.BidBuilder> bidCus
248248
private static BidderCall<BidRequest> givenHttpCall(String responseBody) {
249249
return BidderCall.succeededHttp(null, HttpResponse.of(200, null, responseBody), null);
250250
}
251+
252+
private static BidderCall<BidRequest> givenHttpCall(BidResponse bidResponse) throws JsonProcessingException {
253+
return BidderCall.succeededHttp(
254+
null,
255+
HttpResponse.of(200, null, mapper.writeValueAsString(bidResponse)),
256+
null);
257+
}
251258
}

src/test/resources/org/prebid/server/it/openrtb2/seedtag/test-auction-seedtag-response.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@
1919
"origbidcpm":3.33,
2020
"origbidcur":"USD",
2121
"prebid": {
22-
"type":"banner"
22+
"type":"banner",
23+
"meta": {
24+
"adaptercode": "seedtag"
25+
}
2326
}
2427
}
2528
}

0 commit comments

Comments
 (0)