Tests: Rename open-source modules and align hook suffixes

Author: osulzhenko

src/test/groovy/org/prebid/server/functional/model/ModuleName.groovy

@@ -6,9 +6,9 @@ enum ModuleName {
 
     PB_RICHMEDIA_FILTER("pb-richmedia-filter"),
     PB_RESPONSE_CORRECTION ("pb-response-correction"),
-    ORTB2_BLOCKING("ortb2-blocking"),
+    ORTB2_BLOCKING("pb-ortb2-blocking"),
     PB_REQUEST_CORRECTION('pb-request-correction'),
-    OPTABLE_TARGETING('optable-targeting'),
+    OPTABLE_TARGETING('pb-optable-targeting'),
     PB_RULE_ENGINE('pb-rule-engine')
 
     @JsonValue

src/test/groovy/org/prebid/server/functional/model/config/ExecutionGroup.groovy

@@ -19,7 +19,7 @@ class ExecutionGroup {
     static ExecutionGroup getModuleExecutionGroup(ModuleName name, Stage stage) {
         new ExecutionGroup().tap {
             timeout = 1000
-            hookSequence = [new HookId(moduleCode: name.code, hookImplCode: ModuleHookImplementation.forValue(name, stage).code)]
+            hookSequence = [new HookId(moduleCode: name.code, hookImplCode: "${name.code}-$stage-hook")]
         }
     }
 }

src/test/groovy/org/prebid/server/functional/model/config/ModuleHookImplementation.groovy

@@ -10,9 +10,9 @@ import org.prebid.server.functional.model.request.auction.RichmediaFilter
 class PbsModulesConfig {
 
     RichmediaFilter pbRichmediaFilter
-    Ortb2BlockingConfig ortb2Blocking
+    Ortb2BlockingConfig pbOrtb2Blocking
     PbResponseCorrection pbResponseCorrection
     PbRequestCorrectionConfig pbRequestCorrection
-    OptableTargetingConfig optableTargeting
+    OptableTargetingConfig pbOptableTargeting
     PbRulesEngine pbRuleEngine
 }

src/test/groovy/org/prebid/server/functional/model/config/PbsModulesConfig.groovy

@@ -8,5 +8,5 @@ import groovy.transform.ToString
 @JsonNaming(PropertyNamingStrategies.KebabCaseStrategy)
 class ModuleError {
 
-    Map<String, List<String>> ortb2Blocking
+    Map<String, List<String>> pbOrtb2Blocking
 }

src/test/groovy/org/prebid/server/functional/model/response/auction/ModuleError.groovy

@@ -8,5 +8,5 @@ import groovy.transform.ToString
 @JsonNaming(PropertyNamingStrategies.KebabCaseStrategy)
 class ModuleWarning {
 
-    Map<String, List<String>> ortb2Blocking
+    Map<String, List<String>> pbOrtb2Blocking
 }

src/test/groovy/org/prebid/server/functional/model/response/auction/ModuleWarning.groovy

@@ -1,5 +1,6 @@
 package org.prebid.server.functional.tests.module
 
+import org.prebid.server.functional.model.ModuleName
 import org.prebid.server.functional.model.config.Endpoint
 import org.prebid.server.functional.model.config.ExecutionPlan
 import org.prebid.server.functional.model.config.Stage
@@ -16,6 +17,8 @@ import static org.prebid.server.functional.model.ModuleName.PB_RICHMEDIA_FILTER
 import static org.prebid.server.functional.model.ModuleName.PB_REQUEST_CORRECTION
 import static org.prebid.server.functional.model.ModuleName.PB_RULE_ENGINE
 import static org.prebid.server.functional.model.config.Endpoint.OPENRTB2_AUCTION
+import static org.prebid.server.functional.model.config.ModuleHookImplementation.PB_RULES_ENGINE_PROCESSED_AUCTION_REQUEST
+import static org.prebid.server.functional.model.config.ModuleHookImplementation.PB_RULES_ENGINE_PROCESSED_AUCTION_REQUEST
 import static org.prebid.server.functional.model.config.Stage.ALL_PROCESSED_BID_RESPONSES
 import static org.prebid.server.functional.model.config.Stage.PROCESSED_AUCTION_REQUEST
 import static org.prebid.server.functional.testcontainers.Dependencies.getNetworkServiceContainer
@@ -33,6 +36,22 @@ class ModuleBaseSpec extends BaseSpec {
         repository.removeAllDatabaseData()
     }
 
+    protected final static Closure<String> CALL_METRIC = { ModuleName module, Stage stage ->
+        "modules.module.${module.code}.stage.${stage.metricValue}.hook.${module.code}-${stage.value}-hook.call"
+    }
+    protected final static Closure<String> UPDATE_METRIC = { ModuleName module, Stage stage ->
+        "modules.module.${module.code}.stage.${stage.metricValue}.hook.${module.code}-${stage.value}-hook.success.update"
+    }
+    protected final static Closure<String> NOOP_METRIC = { ModuleName module, Stage stage ->
+        "modules.module.${module.code}.stage.${stage.metricValue}.hook.${module.code}-${stage.value}-hook.success.noop"
+    }
+    protected final static Closure<String> NO_INVOCATION_METRIC = { ModuleName module, Stage stage ->
+        "modules.module.${module.code}.stage.${stage.metricValue}.hook.${module.code}-${stage.value}-hook.success.no-invocation"
+    }
+    protected final static Closure<String> EXECUTION_ERROR_METRIC = { ModuleName module, Stage stage ->
+        "modules.module.${module.code}.stage.${stage.metricValue}.hook.${module.code}-${stage.value}-hook.execution-error"
+    }
+
     protected static Map<String, String> getResponseCorrectionConfig(Endpoint endpoint = OPENRTB2_AUCTION) {
         ["hooks.${PB_RESPONSE_CORRECTION.code}.enabled": true,
          "hooks.host-execution-plan"                   : encode(ExecutionPlan.getSingleEndpointExecutionPlan(endpoint, [(ALL_PROCESSED_BID_RESPONSES): [PB_RESPONSE_CORRECTION]]))]

src/test/groovy/org/prebid/server/functional/tests/module/AbTestingModuleSpec.groovy

@@ -36,7 +36,7 @@ class AnalyticsTagsModuleSpec extends ModuleBaseSpec {
         pbsServiceFactory.removeContainer(getOrtb2BlockingSettings())
     }
 
-    def "PBS should include analytics tag for ortb2-blocking module in response when request and account allow client details"() {
+    def "PBS should include analytics tag for pb-ortb2-blocking module in response when request and account allow client details"() {
         given: "Default account with module config"
         def bidRequest = BidRequest.defaultBidRequest.tap {
             it.ext.prebid.analytics = new PrebidAnalytics(options: new AnalyticsOptions(enableClientDetails: true))