Skip to content

Commit 9033c82

Browse files
author
John Wier
committed
Epsilon: use versioninfo
1 parent fe71750 commit 9033c82

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

src/main/java/org/prebid/server/bidder/epsilon/EpsilonBidder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.prebid.server.proto.openrtb.ext.response.BidType;
2828
import org.prebid.server.util.BidderUtil;
2929
import org.prebid.server.util.HttpUtil;
30+
import org.prebid.server.util.VersionInfo;
3031

3132
import java.math.BigDecimal;
3233
import java.util.ArrayList;
@@ -58,7 +59,6 @@ public class EpsilonBidder implements Bidder<BidRequest> {
5859
private static final Set<Integer> AD_POSITIONS = IntStream.range(0, 8).boxed().collect(Collectors.toSet());
5960

6061
private static final String DISPLAY_MANAGER = "prebid-s2s-java";
61-
private static final String VERSION_UNDEFINED = "undefined";
6262

6363
private final String endpointUrl;
6464
private final boolean generateBidId;
@@ -74,7 +74,7 @@ public EpsilonBidder(String endpointUrl,
7474
this.generateBidId = generateBidId;
7575
this.mapper = Objects.requireNonNull(mapper);
7676
this.currencyConversionService = Objects.requireNonNull(currencyConversionService);
77-
this.displayManagerVersion = VERSION_UNDEFINED.equals(pbsVersion) ? null : pbsVersion;
77+
this.displayManagerVersion = VersionInfo.UNDEFINED.equals(pbsVersion) ? null : pbsVersion;
7878
}
7979

8080
@Override

src/main/java/org/prebid/server/util/VersionInfo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
public class VersionInfo {
1515

1616
private static final Logger logger = LoggerFactory.getLogger(VersionInfo.class);
17-
private static final String UNDEFINED = "undefined";
17+
public static final String UNDEFINED = "undefined";
1818

1919
String version;
2020
String commitHash;

src/test/java/org/prebid/server/bidder/epsilon/EpsilonBidderTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import org.prebid.server.proto.openrtb.ext.request.epsilon.ExtImpEpsilon;
3232
import org.prebid.server.proto.openrtb.ext.response.BidType;
3333
import org.prebid.server.proto.openrtb.ext.response.ExtBidResponse;
34+
import org.prebid.server.util.VersionInfo;
3435

3536
import java.math.BigDecimal;
3637
import java.util.Collections;
@@ -224,7 +225,8 @@ public void makeHttpRequestsShouldNotSetDisplayManagerVerWhenVersionIsNull() {
224225
@Test
225226
public void makeHttpRequestsShouldNotSetDisplayManagerVerWhenVersionIsUndefined() {
226227
// given
227-
target = new EpsilonBidder(ENDPOINT_URL, false, "undefined", jacksonMapper, currencyConversionService);
228+
target = new EpsilonBidder(
229+
ENDPOINT_URL, false, VersionInfo.UNDEFINED, jacksonMapper, currencyConversionService);
228230
final BidRequest bidRequest = givenBidRequest(identity());
229231

230232
// when

0 commit comments

Comments
 (0)