Skip to content

Commit 9c2f3dd

Browse files
fix comments
1 parent f27263c commit 9c2f3dd

4 files changed

Lines changed: 6 additions & 10 deletions

File tree

src/main/java/org/prebid/server/bidder/eplanning/EplanningBidder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ private static BidderBid mapToBidderBid(HbResponseSpace hbResponseSpace, HbRespo
396396
.price(new BigDecimal(hbResponseAd.getPrice()))
397397
.adm(hbResponseAd.getAdM())
398398
.crid(hbResponseAd.getCrId())
399-
.adomain(hbResponseAd.getAdomain())
399+
.adomain(Collections.singletonList(hbResponseAd.getAdom()))
400400
.w(hbResponseAd.getWidth())
401401
.h(hbResponseAd.getHeight())
402402
.build(),

src/main/java/org/prebid/server/bidder/eplanning/model/HbResponseAd.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
import lombok.Builder;
55
import lombok.Value;
66

7-
import java.util.List;
8-
97
@Builder
108
@Value
119
public class HbResponseAd {
@@ -25,8 +23,8 @@ public class HbResponseAd {
2523
@JsonProperty("crid")
2624
String crId;
2725

28-
@JsonProperty("adomain")
29-
List<String> adomain;
26+
@JsonProperty()
27+
String adom;
3028

3129
@JsonProperty("w")
3230
Integer width;

src/test/java/org/prebid/server/bidder/eplanning/EplanningBidderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -615,7 +615,7 @@ public void makeBidsShouldReturnBannerBidWithExpectedFields() throws JsonProcess
615615
.price("3.3")
616616
.adM("some-adm")
617617
.crId("CR-ID")
618-
.adomain(List.of("test.com"))
618+
.adom("test.com")
619619
.width(500)
620620
.height(300)
621621
.build()))))));
@@ -655,7 +655,7 @@ public void makeBidsShouldReturnBannerBidIfMissingAdunitCode() throws JsonProces
655655
.price("3.3")
656656
.adM("some-adm")
657657
.crId("CR-ID")
658-
.adomain(List.of("test.com"))
658+
.adom("test.com")
659659
.width(1)
660660
.height(1)
661661
.build()))))));

src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-eplanning-bid-response-1.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@
99
"adm": "<div>test</div>",
1010
"crid": "crid",
1111
"id": "imp_id",
12-
"adomain": [
13-
"test.com"
14-
],
12+
"adom": "test.com",
1513
"w": 600,
1614
"h": 300
1715
}

0 commit comments

Comments
 (0)