Skip to content

Commit 9cfcf4b

Browse files
fix comments
1 parent 47b9321 commit 9cfcf4b

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ private BidRequest updateBidRequest(BidRequest bidRequest, ExtImpNextMillennium
108108
.orElse(null);
109109

110110
return bidRequest.toBuilder()
111-
.imp(modifyFirstImp(bidRequest.getImp(), soredRequestId, extImp))
111+
.imp(modifyFirstImp(bidRequest.getImp(), soredRequestId))
112112
.ext(createExtRequest(soredRequestId, extRequestPrebidServer, extImp))
113113
.build();
114114
}
@@ -150,14 +150,13 @@ private static String formatSize(Integer w, Integer h) {
150150
: null;
151151
}
152152

153-
private List<Imp> modifyFirstImp(List<Imp> imps, String storedRequestId, ExtImpNextMillennium extImp) {
153+
private List<Imp> modifyFirstImp(List<Imp> imps, String storedRequestId) {
154154
final ExtRequestPrebid extRequestPrebid = ExtRequestPrebid.builder()
155155
.storedrequest(ExtStoredRequest.of(storedRequestId))
156156
.build();
157157

158158
final NextMillenniumExt nextMillenniumExt = NextMillenniumExt.of(
159-
NextMillenniumExtBidder.of(
160-
nmmFlags, extImp.getAdSlots(), extImp.getAllowedAds(), null, null));
159+
NextMillenniumExtBidder.ofNmmFlags(nmmFlags));
161160

162161
final ExtRequest extRequest = ExtRequest.of(extRequestPrebid);
163162
mapper.fillExtension(extRequest, nextMillenniumExt);

src/main/java/org/prebid/server/bidder/nextmillennium/proto/NextMillenniumExtBidder.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,8 @@ public class NextMillenniumExtBidder {
2020
String nmVersion;
2121

2222
String serverVersion;
23+
24+
public static NextMillenniumExtBidder ofNmmFlags(List<String> nmmFlags) {
25+
return of(nmmFlags, null, null, null, null);
26+
}
2327
}

src/test/resources/org/prebid/server/it/openrtb2/nextmillennium/test-nextmillennium-bid-request.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,7 @@
1010
"secure": 1,
1111
"ext": {
1212
"nextMillennium" : {
13-
"nmmFlags" : [ "1" ],
14-
"adSlots": ["slot-1", "slot-2"],
15-
"allowedAds": ["banner", "native"]
13+
"nmmFlags" : [ "1" ]
1614
},
1715
"prebid": {
1816
"storedrequest": {

0 commit comments

Comments
 (0)