Skip to content

Commit b98d69a

Browse files
fix comments
1 parent b99820d commit b98d69a

1 file changed

Lines changed: 13 additions & 15 deletions

File tree

src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -293,22 +293,20 @@ public void makeBidsShouldReturnBannerBidForRichMediaType() throws JsonProcessin
293293
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
294294

295295
// then
296-
final Bid expectedBid = Bid.builder()
297-
.impid("123")
298-
.ext(mapper.valueToTree(ExtPrebid.of(
299-
ExtBidPrebid.builder()
300-
.meta(org.prebid.server.proto.openrtb.ext.response.ExtBidPrebidMeta.builder()
301-
.mediaType("banner")
302-
.advertiserDomains(List.of())
303-
.build())
304-
.build(),
305-
null)))
306-
.build();
296+
assertThat(result.getErrors()).isEmpty();
297+
assertThat(result.getValue()).hasSize(1);
307298

308-
final BidderBid expected = BidderBid.of(expectedBid, banner, DEFAULT_CURRENCY);
299+
final BidderBid bidderBid = result.getValue().get(0);
300+
assertThat(bidderBid.getType()).isEqualTo(banner);
301+
assertThat(bidderBid.getBidCurrency()).isEqualTo(DEFAULT_CURRENCY);
309302

310-
assertThat(result.getErrors()).isEmpty();
311-
assertThat(result.getValue()).containsExactly(expected);
303+
final Bid bid = bidderBid.getBid();
304+
assertThat(bid.getImpid()).isEqualTo("123");
305+
306+
final JsonNode prebidMeta = bid.getExt().path("prebid").path("meta");
307+
assertThat(prebidMeta.path("mediaType").asText()).isEqualTo("banner");
308+
assertThat(prebidMeta.path("advertiserDomains").isArray()).isTrue();
309+
assertThat(prebidMeta.path("advertiserDomains").size()).isEqualTo(0);
312310
}
313311

314312
@Test
@@ -347,7 +345,7 @@ public void makeBidsShouldReturnNativeBid() throws JsonProcessingException {
347345

348346
final BidderBid bidderBid = result.getValue().get(0);
349347
assertThat(bidderBid.getType()).isEqualTo(BidType.xNative);
350-
assertThat(bidderBid.getBidCurrency()).isEqualTo("EUR");
348+
assertThat(bidderBid.getBidCurrency()).isEqualTo(DEFAULT_CURRENCY);
351349

352350
final Bid bid = bidderBid.getBid();
353351
assertThat(bid.getImpid()).isEqualTo("123");

0 commit comments

Comments
 (0)