Skip to content

Commit c164516

Browse files
committed
remove var
1 parent 61206a5 commit c164516

2 files changed

Lines changed: 15 additions & 17 deletions

File tree

src/main/java/org/prebid/server/bidder/openx/OpenxBidder.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -340,12 +340,12 @@ private static List<ExtIgi> extractIgi(OpenxBidResponse bidResponse) {
340340
}
341341

342342
private ObjectNode updateBidMeta(Bid bid) {
343-
final var ext = bid.getExt();
343+
final ObjectNode ext = bid.getExt();
344344
if (ext == null) {
345345
return null;
346346
}
347347

348-
final var openxBidExt = parseOpenxBidExt(ext);
348+
final OpenxBidExt openxBidExt = parseOpenxBidExt(ext);
349349
final int buyerId = parseStringToInt(openxBidExt.getBuyerId());
350350
final int dspId = parseStringToInt(openxBidExt.getDspId());
351351
final int brandId = parseStringToInt(openxBidExt.getBrandId());
@@ -354,13 +354,13 @@ private ObjectNode updateBidMeta(Bid bid) {
354354
return ext;
355355
}
356356

357-
final var updatedMeta = ExtBidPrebidMeta.builder()
357+
final ExtBidPrebidMeta updatedMeta = ExtBidPrebidMeta.builder()
358358
.networkId(dspId)
359359
.advertiserId(buyerId)
360360
.brandId(brandId)
361361
.build();
362362

363-
final var modifiedExtBidPrebid = ExtBidPrebid.builder().meta(updatedMeta).build();
363+
final ExtBidPrebid modifiedExtBidPrebid = ExtBidPrebid.builder().meta(updatedMeta).build();
364364

365365
ext.set(PREBID_EXT, mapper.mapper().valueToTree(modifiedExtBidPrebid));
366366

src/test/java/org/prebid/server/bidder/openx/OpenxBidderTest.java

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -995,23 +995,23 @@ private static BidderCall<BidRequest> givenHttpCall(String body) {
995995
@Test
996996
public void makeBidsShouldReturnBidMeta() throws JsonProcessingException {
997997
// given
998-
final var allBuyerExt = new ObjectNode(JsonNodeFactory.instance);
999-
final var onlyBrandExt = new ObjectNode(JsonNodeFactory.instance);
1000-
final var badExt = new ObjectNode(JsonNodeFactory.instance);
998+
final ObjectNode allBuyerExt = new ObjectNode(JsonNodeFactory.instance);
999+
final ObjectNode onlyBrandExt = new ObjectNode(JsonNodeFactory.instance);
1000+
final ObjectNode badExt = new ObjectNode(JsonNodeFactory.instance);
10011001

10021002
allBuyerExt.put("dsp_id", "1").put("buyer_id", "2").put("brand_id", "3");
10031003
onlyBrandExt.put("brand_id", "4");
10041004
badExt.put("dsp_id", "abc").put("brand_id", "cba");
10051005

1006-
final var allBuyerExpectedExtJson = "{\"dsp_id\":\"1\",\"buyer_id\":\"2\",\"brand_id\":\"3\",\"prebid\":"
1006+
final String allBuyerExpectedExtJson = "{\"dsp_id\":\"1\",\"buyer_id\":\"2\",\"brand_id\":\"3\",\"prebid\":"
10071007
+ "{\"meta\":{\"advertiserId\":2,\"brandId\":3,\"networkId\":1}}}";
1008-
final var onlyBrandExpectedExtJson = "{\"brand_id\":\"4\",\"prebid\":{\"meta\":{\"advertiserId\":0,"
1008+
final String onlyBrandExpectedExtJson = "{\"brand_id\":\"4\",\"prebid\":{\"meta\":{\"advertiserId\":0,"
10091009
+ "\"brandId\":4,\"networkId\":0}}}";
1010-
final var badExpectedExtJson = "{\"dsp_id\":\"abc\",\"brand_id\":\"cba\"}";
1010+
final String badExpectedExtJson = "{\"dsp_id\":\"abc\",\"brand_id\":\"cba\"}";
10111011

1012-
final var allBuyerExpectedExt = (ObjectNode) mapper.readTree(allBuyerExpectedExtJson);
1013-
final var onlyBrandExpectedExt = (ObjectNode) mapper.readTree(onlyBrandExpectedExtJson);
1014-
final var badExpectedExt = (ObjectNode) mapper.readTree(badExpectedExtJson);
1012+
final ObjectNode allBuyerExpectedExt = (ObjectNode) mapper.readTree(allBuyerExpectedExtJson);
1013+
final ObjectNode onlyBrandExpectedExt = (ObjectNode) mapper.readTree(onlyBrandExpectedExtJson);
1014+
final ObjectNode badExpectedExt = (ObjectNode) mapper.readTree(badExpectedExtJson);
10151015

10161016
final BidderCall<BidRequest> httpCall = givenHttpCall(mapper.writeValueAsString(BidResponse.builder()
10171017
.seatbid(singletonList(SeatBid.builder()
@@ -1042,8 +1042,7 @@ public void makeBidsShouldReturnBidMeta() throws JsonProcessingException {
10421042
.dealid("dealid3")
10431043
.adm("<div>This is an Ad</div>")
10441044
.ext(badExt)
1045-
.build()
1046-
))
1045+
.build()))
10471046
.build()))
10481047
.build()));
10491048

@@ -1053,8 +1052,7 @@ public void makeBidsShouldReturnBidMeta() throws JsonProcessingException {
10531052
Imp.builder()
10541053
.id("impId1")
10551054
.banner(Banner.builder().build())
1056-
.build()
1057-
))
1055+
.build()))
10581056
.build();
10591057

10601058
// when

0 commit comments

Comments
 (0)