Yahoo Ads: treat a non-integer gpp_sid element as malformed

resolveGppSid now promotes regs.ext.gpp_sid only when every element is an
integer. If any element is non-integral the whole array is left in regs.ext
untouched rather than promoting a filtered subset, matching the gpp and coppa
handling so no value is silently dropped. Adds a test for the mixed-array case.

Author: MananRPatel

src/main/java/org/prebid/server/bidder/yahooads/YahooAdsBidder.java

@@ -208,11 +208,12 @@ private static List<Integer> resolveGppSid(Regs regs, ExtRegs ext) {
             return regs.getGppSid();
         }
         final List<Integer> sids = new ArrayList<>(node.size());
-        node.forEach(elem -> {
-            if (elem.isIntegralNumber()) {
-                sids.add(elem.asInt());
+        for (final JsonNode elem : node) {
+            if (!elem.isIntegralNumber()) {
+                return regs.getGppSid();
             }
-        });
+            sids.add(elem.asInt());
+        }
         return sids.isEmpty() ? regs.getGppSid() : sids;
     }
 

src/test/java/org/prebid/server/bidder/yahooads/YahooAdsBidderTest.java

@@ -1,6 +1,7 @@
 package org.prebid.server.bidder.yahooads;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.node.ArrayNode;
 import com.fasterxml.jackson.databind.node.IntNode;
 import com.fasterxml.jackson.databind.node.TextNode;
@@ -554,6 +555,35 @@ public void makeHttpRequestsShouldLeaveMalformedExtValueInExtWhenSiblingFieldIsP
         assertThat(regs.getExt().getProperty("gpp").asInt()).isEqualTo(99);
     }
 
+    @Test
+    public void makeHttpRequestsShouldNotPromoteGppSidWhenArrayHasNonIntegerElement() {
+        final BidRequest bidRequest = givenBidRequest(identity(),
+                requestBuilder -> requestBuilder.regs(Regs.builder()
+                        .ext(ExtRegs.of(null, null, null, null))
+                        .build()).device(Device.builder().ua("UA").build()));
+        final ArrayNode mixed = mapper.createArrayNode();
+        mixed.add(7);
+        mixed.add("foo");
+        mixed.add(8);
+        bidRequest.getRegs().getExt().addProperty("gpp_sid", mixed);
+
+        // when
+        final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
+
+        // then
+        assertThat(result.getErrors()).isEmpty();
+        final Regs regs = result.getValue().getFirst().getPayload().getRegs();
+        // whole array treated as malformed: not promoted, left in ext untouched (nothing dropped)
+        assertThat(regs.getGppSid()).isNull();
+        assertThat(regs.getExt()).isNotNull();
+        final JsonNode keptSid = regs.getExt().getProperty("gpp_sid");
+        assertThat(keptSid.isArray()).isTrue();
+        assertThat(keptSid).hasSize(3);
+        assertThat(keptSid.get(0).asInt()).isEqualTo(7);
+        assertThat(keptSid.get(1).asText()).isEqualTo("foo");
+        assertThat(keptSid.get(2).asInt()).isEqualTo(8);
+    }
+
     @Test
     public void makeHttpRequestsShouldShortCircuitWhenRegsHasNoExt() {
         final BidRequest bidRequest = givenBidRequest(identity(),