Skip to content

Commit d15ed9e

Browse files
author
ilya
committed
DATA-53829: Fixing PR issues
1 parent d4eb7b2 commit d15ed9e

2 files changed

Lines changed: 16 additions & 22 deletions

File tree

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
package org.prebid.server.hooks.modules.liveintent.omni.channel.identity.model;
22

3-
import lombok.Builder;
43
import lombok.Value;
54

6-
@Value
7-
@Builder(toBuilder = true)
5+
@Value(staticConstructor = "of")
86
public class FullSource {
97

108
String source;
9+
1110
String inserter;
1211
}

extra/modules/live-intent-omni-channel-identity/src/main/java/org/prebid/server/hooks/modules/liveintent/omni/channel/identity/v1/hooks/LiveIntentOmniChannelIdentityProcessedAuctionRequestHook.java

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ private ExtRequestPrebidData updatePrebidData(ExtRequestPrebidData extPrebidData
237237
final List<String> originalBidders = extPrebidData != null ? extPrebidData.getBidders() : null;
238238

239239
final Set<FullSource> resolvedSources = resolvedEids.stream()
240-
.map(eid -> FullSource.builder().source(eid.getSource()).inserter(eid.getInserter()).build())
240+
.map(eid -> FullSource.of(eid.getSource(), eid.getInserter()))
241241
.collect(Collectors.toSet());
242242

243243
final List<ExtRequestPrebidDataEidPermissions> eidPermissions = extPrebidData != null
@@ -249,29 +249,24 @@ private ExtRequestPrebidData updatePrebidData(ExtRequestPrebidData extPrebidData
249249
.filter(Objects::nonNull)
250250
.toList();
251251

252-
if (CollectionUtils.isEmpty(updatedPermissions)) {
253-
return ExtRequestPrebidData.of(
254-
originalBidders,
255-
resolvedEids.stream()
256-
.map(eid ->
257-
ExtRequestPrebidDataEidPermissions.builder()
258-
.bidders(targetBidders.stream().toList())
259-
.inserter(INSERTER)
260-
.source(eid.getSource())
261-
.build())
262-
.toList());
263-
} else {
264-
return ExtRequestPrebidData.of(originalBidders, updatedPermissions);
265-
}
252+
return CollectionUtils.isEmpty(updatedPermissions)
253+
? ExtRequestPrebidData.of(
254+
originalBidders,
255+
resolvedEids.stream()
256+
.map(eid ->
257+
ExtRequestPrebidDataEidPermissions.builder()
258+
.bidders(targetBidders.stream().toList())
259+
.inserter(INSERTER)
260+
.source(eid.getSource())
261+
.build())
262+
.toList())
263+
: ExtRequestPrebidData.of(originalBidders, updatedPermissions);
266264
}
267265

268266
private ExtRequestPrebidDataEidPermissions restrictEidPermission(ExtRequestPrebidDataEidPermissions permission,
269267
Set<FullSource> resolvedSources) {
270268

271-
final FullSource permFullSource = FullSource.builder()
272-
.source(permission.getSource())
273-
.inserter(permission.getInserter())
274-
.build();
269+
final FullSource permFullSource = FullSource.of(permission.getSource(), permission.getInserter());
275270
if (!resolvedSources.contains(permFullSource)) {
276271
return permission;
277272
}

0 commit comments

Comments
 (0)