Skip to content

Commit db22af7

Browse files
committed
Update after review
1 parent e6c4730 commit db22af7

5 files changed

Lines changed: 5 additions & 9 deletions

File tree

src/test/groovy/org/prebid/server/functional/testcontainers/scaffolding/CurrencyConversion.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@ class CurrencyConversion extends NetworkScaffolding {
3434

3535
@Override
3636
protected RequestPatternBuilder getRequest(String value) {
37-
return null
37+
throw new UnsupportedOperationException()
3838
}
3939
}

src/test/groovy/org/prebid/server/functional/testcontainers/scaffolding/HttpSettings.groovy

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,7 @@ class HttpSettings extends NetworkScaffolding {
5252
.withHeader("Content-Type", "application/json")
5353
.withBody(encode(responseModel))
5454

55-
headers.each { k, v ->
56-
responseBuilder.withHeader(k, v)
57-
}
55+
headers.each { responseBuilder.withHeader(it.key, it.value) }
5856

5957
wireMockClient.register(new StubMapping(getRfcRequestPattern(value).build(), responseBuilder.build()))
6058
}

src/test/groovy/org/prebid/server/functional/testcontainers/scaffolding/NetworkScaffolding.groovy

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,7 @@ abstract class NetworkScaffolding implements ObjectMapperWrapper {
6363
.withHeader("Content-Type", "application/json")
6464
.withBody(encode(responseModel))
6565

66-
headers.each { k, v ->
67-
responseBuilder.withHeader(k, v)
68-
}
66+
headers.each { responseBuilder.withHeader(it.key, it.value) }
6967

7068
wireMockClient.register(new StubMapping(getRequest(value).build(), responseBuilder.build()))
7169
}

src/test/groovy/org/prebid/server/functional/testcontainers/scaffolding/PrebidCache.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class PrebidCache extends NetworkScaffolding {
6262
@Override
6363
protected RequestPatternBuilder getRequest(String impId) {
6464
postRequestedFor(urlEqualTo(CACHE_ENDPOINT))
65-
.withRequestBody(matchingJsonPath("\$.puts[?(@.value.impid == '" + impId + "')]"))
65+
.withRequestBody(matchingJsonPath("\$.puts[?(@.value.impid == '$impId')]"))
6666
}
6767

6868

src/test/groovy/org/prebid/server/functional/testcontainers/scaffolding/VendorList.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class VendorList extends NetworkScaffolding {
3434

3535
@Override
3636
protected RequestPatternBuilder getRequest(String value) {
37-
return null
37+
throw new UnsupportedOperationException()
3838
}
3939

4040
void setResponse(TcfPolicyVersion tcfPolicyVersion = TCF_POLICY_V2,

0 commit comments

Comments
 (0)