Skip to content

Commit dc3d8e6

Browse files
committed
Add coverage for ext?.prebid?.bidAdjustmentFactors?.mediaTypes
1 parent f55bd7b commit dc3d8e6

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ import static org.prebid.server.functional.model.bidder.BidderName.RUBICON
5151
import static org.prebid.server.functional.model.mock.services.currencyconversion.CurrencyConversionRatesResponse.defaultConversionRates
5252
import static org.prebid.server.functional.model.request.auction.AdjustmentType.MULTIPLIER
5353
import static org.prebid.server.functional.model.request.auction.BidAdjustmentMediaType.BANNER
54+
import static org.prebid.server.functional.model.request.auction.BidAdjustmentMediaType.VIDEO
5455
import static org.prebid.server.functional.model.request.auction.DebugCondition.ENABLED
5556
import static org.prebid.server.functional.model.request.auction.DistributionChannel.APP
5657
import static org.prebid.server.functional.model.request.auction.DistributionChannel.DOOH
@@ -62,6 +63,8 @@ import static org.prebid.server.functional.util.PBSUtils.roundDecimal
6263

6364
class BidderFieldDisplayBehaviorSpec extends BaseSpec {
6465

66+
private static final WILDCARD = "*"
67+
6568
def "PBS should pass ext.prebid.createTids to bidder request"() {
6669
given: "Default bid request"
6770
def bidRequest = BidRequest.defaultBidRequest.tap {
@@ -575,8 +578,8 @@ class BidderFieldDisplayBehaviorSpec extends BaseSpec {
575578
given: "Default BidRequest with ext.prebid.bidAdjustments"
576579
def currency = USD
577580
def rule = new BidAdjustmentRule().tap {
578-
generic = ["*": [new AdjustmentRule(adjustmentType: MULTIPLIER, value: PBSUtils.randomPrice, currency: currency)]]
579-
openx = ["*": [new AdjustmentRule(adjustmentType: MULTIPLIER, value: PBSUtils.randomPrice, currency: currency)]]
581+
generic = [(WILDCARD): [new AdjustmentRule(adjustmentType: MULTIPLIER, value: PBSUtils.randomPrice, currency: currency)]]
582+
openx = [(WILDCARD): [new AdjustmentRule(adjustmentType: MULTIPLIER, value: PBSUtils.randomPrice, currency: currency)]]
580583
}
581584
def bidRequest = BidRequest.getDefaultBidRequest().tap {
582585
ext.prebid.bidAdjustments = BidAdjustment.getDefaultWithSingleMediaTypeRule(BANNER, rule)
@@ -609,7 +612,7 @@ class BidderFieldDisplayBehaviorSpec extends BaseSpec {
609612
ext.prebid.bidAdjustmentFactors = new BidAdjustmentFactors().tap {
610613
adjustments = [(BidderName.GENERIC): bidAdjustment, (OPENX): bidAdjustment]
611614
mediaTypes = [(BANNER): [(BidderName.GENERIC): mediaTypeBidAdjustment],
612-
(BANNER): [(OPENX): mediaTypeBidAdjustment]]
615+
(VIDEO): [(OPENX): mediaTypeBidAdjustment]]
613616
}
614617
}
615618

@@ -626,8 +629,9 @@ class BidderFieldDisplayBehaviorSpec extends BaseSpec {
626629
assert bidderRequest.ext.prebid.bidAdjustmentFactors.mediaTypes[BANNER][GENERIC] == bidRequest.ext.prebid.bidAdjustmentFactors.mediaTypes[BANNER][GENERIC]
627630

628631
and: "Bidder request shouldn't contain opneX bid adjustment factors for generic call"
629-
assert bidderRequest.ext.prebid.bidAdjustmentFactors.adjustments[OPENX]
630-
assert bidderRequest.ext.prebid.bidAdjustmentFactors.mediaTypes[BANNER][OPENX]
632+
assert !bidderRequest?.ext?.prebid?.bidAdjustmentFactors?.adjustments[OPENX]
633+
assert !bidderRequest?.ext?.prebid?.bidAdjustmentFactors?.mediaTypes[BANNER][OPENX]
634+
assert !bidderRequest?.ext?.prebid?.bidAdjustmentFactors?.mediaTypes[VIDEO]
631635

632636
where:
633637
bidAdjustmentFactor << [0.9, 1.1]

0 commit comments

Comments
 (0)