Skip to content

Commit e3a801c

Browse files
committed
Missed review remarks
1 parent 4693030 commit e3a801c

3 files changed

Lines changed: 11 additions & 4 deletions

File tree

extra/modules/id5-user-id/src/main/java/org/prebid/server/hooks/modules/id5/userid/v1/Id5IdInjectHook.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public Future<InvocationResult<BidderRequestPayload>> call(BidderRequestPayload
6767
return resultBuilder(invocationContext)
6868
.status(InvocationStatus.success)
6969
.action(InvocationAction.no_action)
70-
.debugMessages(List.of("id5-user-id-inject: no ids to inject"))
70+
.debugMessages(Collections.singletonList("id5-user-id-inject: no ids to inject"))
7171
.build();
7272
}
7373
final User originalUser = payload.bidRequest().getUser();
@@ -87,8 +87,7 @@ public Future<InvocationResult<BidderRequestPayload>> call(BidderRequestPayload
8787
.status(InvocationStatus.success)
8888
.action(InvocationAction.update)
8989
.payloadUpdate(initial -> BidderRequestPayloadImpl.of(updatedBidRequest))
90-
.debugMessages(List.of(
91-
"id5-user-id-inject: updated user with id5 eids"))
90+
.debugMessages(Collections.singletonList("id5-user-id-inject: updated user with id5 eids"))
9291
.build();
9392
});
9493
}

extra/modules/id5-user-id/src/main/java/org/prebid/server/hooks/modules/id5/userid/v1/fetch/HttpFetchClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ private PrebidServerMetadata createProviderMetadata(BidRequest bidRequest, Prebi
207207
private Id5UserId parseResponse(HttpClientResponse response) {
208208
final String body = response.getBody();
209209
final int statusCode = response.getStatusCode();
210-
if (response.getStatusCode() == 200) {
210+
if (statusCode == 200) {
211211
logger.debug("id5-user-id: fetched id5Id succeeded, body {}", body);
212212
return decodeResponse(body);
213213
}

extra/modules/id5-user-id/src/main/java/org/prebid/server/hooks/modules/id5/userid/v1/model/FetchRequest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,17 @@ public class FetchRequest {
6868
public static class PrebidServerMetadata {
6969

7070
String channel;
71+
7172
String channelVersion;
73+
7274
Id5IdModuleProperties id5ModuleConfig;
75+
7376
Publisher publisher;
77+
7478
List<String> bidders;
79+
7580
boolean transmitUfpdDisallowed;
81+
7682
boolean transmitGeoDisallowed;
7783
}
7884

@@ -81,7 +87,9 @@ public static class PrebidServerMetadata {
8187
public static class Publisher {
8288

8389
String id;
90+
8491
String name;
92+
8593
String domain;
8694
}
8795
}

0 commit comments

Comments
 (0)