Skip to content

Commit f6f88bb

Browse files
committed
Fix comments
1 parent f88ce6f commit f6f88bb

2 files changed

Lines changed: 8 additions & 14 deletions

File tree

src/main/java/org/prebid/server/bidder/missena/MissenaBidder.java

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ private ExtImpMissena parseImpExt(Imp imp) {
9191

9292
private HttpRequest<MissenaAdRequest> makeHttpRequest(BidRequest request, Imp imp, ExtImpMissena extImp) {
9393
final Site site = request.getSite();
94-
final String pageUrl = site != null ? site.getPage() : null;
9594
final User user = request.getUser();
9695
final Regs regs = request.getRegs();
9796
final Device device = request.getDevice();
@@ -118,7 +117,7 @@ private HttpRequest<MissenaAdRequest> makeHttpRequest(BidRequest request, Imp im
118117
.gdpr(isGdpr(regs))
119118
.gdprConsent(getUserConsent(user))
120119
.idempotencyKey(request.getId())
121-
.referer(pageUrl)
120+
.referer(site != null ? site.getPage() : null)
122121
.refererCanonical(site != null ? site.getDomain() : null)
123122
.requestId(request.getId())
124123
.schain(source != null ? source.getSchain() : null)
@@ -147,10 +146,6 @@ private Price resolveBidFloor(Imp imp, BidRequest bidRequest, String targetCurre
147146
private Price convertBidFloor(Price bidFloorPrice, String impId, BidRequest bidRequest, String targetCurrency) {
148147
final String bidFloorCur = bidFloorPrice.getCurrency();
149148

150-
if (targetCurrency.equalsIgnoreCase(bidFloorCur)) {
151-
return bidFloorPrice;
152-
}
153-
154149
try {
155150
final BigDecimal convertedPrice = currencyConversionService
156151
.convertCurrency(bidFloorPrice.getValue(), bidRequest, bidFloorCur, targetCurrency);
@@ -163,19 +158,19 @@ private Price convertBidFloor(Price bidFloorPrice, String impId, BidRequest bidR
163158
}
164159

165160
private String resolveCurrency(List<String> requestCurrencies) {
166-
for (String currency : requestCurrencies) {
167-
if (USD_CURRENCY.equalsIgnoreCase(currency)) {
161+
String currency = USD_CURRENCY;
162+
163+
for (String requestCurrency : requestCurrencies) {
164+
if (USD_CURRENCY.equalsIgnoreCase(requestCurrency)) {
168165
return USD_CURRENCY;
169166
}
170-
}
171167

172-
for (String currency : requestCurrencies) {
173-
if (EUR_CURRENCY.equalsIgnoreCase(currency)) {
174-
return EUR_CURRENCY;
168+
if (EUR_CURRENCY.equalsIgnoreCase(requestCurrency)) {
169+
currency = EUR_CURRENCY;
175170
}
176171
}
177172

178-
return USD_CURRENCY;
173+
return currency;
179174
}
180175

181176
private MultiMap makeHeaders(Device device, Site site) {

src/main/java/org/prebid/server/bidder/missena/MissenaUserParams.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,5 @@ public class MissenaUserParams {
1919
String testMode;
2020

2121
ObjectNode settings;
22-
2322
}
2423

0 commit comments

Comments
 (0)