Skip to content

Commit fd63ce6

Browse files
committed
fix comments
1 parent a3c4ea1 commit fd63ce6

2 files changed

Lines changed: 12 additions & 13 deletions

File tree

src/main/java/org/prebid/server/bidder/smartadserver/SmartadserverBidder.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,7 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request
6262
for (Imp imp : request.getImp()) {
6363
try {
6464
final ExtImpSmartadserver extImp = parseImpExt(imp);
65-
if (!isProgrammaticGuaranteed && extImp.isProgrammaticGuaranteed()) {
66-
isProgrammaticGuaranteed = true;
67-
}
65+
isProgrammaticGuaranteed |= extImp.isProgrammaticGuaranteed();
6866
impToExtImpMap.put(imp, extImp);
6967
} catch (PreBidException e) {
7068
errors.add(BidderError.badInput(e.getMessage()));
@@ -122,8 +120,9 @@ private static Publisher modifyPublisher(Publisher publisher, Integer networkId)
122120
}
123121

124122
private String makeUrl(boolean isProgrammaticGuaranteed) {
123+
final String url = isProgrammaticGuaranteed ? secondaryEndpointUrl : endpointUrl;
125124
try {
126-
final URI uri = new URI(isProgrammaticGuaranteed ? secondaryEndpointUrl : endpointUrl);
125+
final URI uri = new URI(url);
127126
final String path = isProgrammaticGuaranteed ? "/ortb" : "/api/bid";
128127
final URIBuilder uriBuilder = new URIBuilder(uri)
129128
.setPath(StringUtils.removeEnd(uri.getPath(), "/") + path);
@@ -134,7 +133,7 @@ private String makeUrl(boolean isProgrammaticGuaranteed) {
134133

135134
return uriBuilder.toString();
136135
} catch (URISyntaxException e) {
137-
throw new PreBidException("Malformed URL: %s.".formatted(secondaryEndpointUrl));
136+
throw new PreBidException("Malformed URL: %s.".formatted(url));
138137
}
139138
}
140139

src/main/java/org/prebid/server/spring/config/bidder/SmartadserverConfiguration.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,6 @@ public class SmartadserverConfiguration {
2424

2525
private static final String BIDDER_NAME = "smartadserver";
2626

27-
@Data
28-
@EqualsAndHashCode(callSuper = true)
29-
@NoArgsConstructor
30-
private static class SmartadserverConfigurationProperties extends BidderConfigurationProperties {
31-
32-
private String secondaryEndpoint;
33-
}
34-
3527
@Bean("smartadserverConfigurationProperties")
3628
@ConfigurationProperties("adapters.smartadserver")
3729
SmartadserverConfigurationProperties configurationProperties() {
@@ -50,4 +42,12 @@ BidderDeps smartadserverBidderDeps(SmartadserverConfigurationProperties smartads
5042
config.getEndpoint(), config.getSecondaryEndpoint(), mapper))
5143
.assemble();
5244
}
45+
46+
@Data
47+
@EqualsAndHashCode(callSuper = true)
48+
@NoArgsConstructor
49+
private static class SmartadserverConfigurationProperties extends BidderConfigurationProperties {
50+
51+
private String secondaryEndpoint;
52+
}
5353
}

0 commit comments

Comments
 (0)