Skip to content

New Adapter: Oprx#4432

Open
Ivan-Z-Oprx wants to merge 15 commits into
prebid:masterfrom
Ivan-Z-Oprx:adding-adapter-oprx
Open

New Adapter: Oprx#4432
Ivan-Z-Oprx wants to merge 15 commits into
prebid:masterfrom
Ivan-Z-Oprx:adding-adapter-oprx

Conversation

@Ivan-Z-Oprx

@Ivan-Z-Oprx Ivan-Z-Oprx commented Jul 11, 2025

Copy link
Copy Markdown

No description provided.

github-actions[bot]
github-actions Bot reviewed Jul 11, 2025
View reviewed changes
Comment thread adapters/oprx/oprx.go Outdated
var bidExt openrtb_ext.ExtBid
err := jsonutil.Unmarshal(bid.Ext, &bidExt)
if err == nil && bidExt.Prebid != nil {
return openrtb_ext.ParseBidType(string(bidExt.Prebid.Type))

@github-actions github-actions Bot Jul 11, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

@github-actions

github-actions Bot commented Jul 11, 2025

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6ca1843

oprx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:27:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:43:	getMediaTypeForBid	83.3%
github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:57:	MakeBids		63.6%
total:								(statements)		71.4%

@suruvu

suruvu commented Jul 11, 2025

Copy link
Copy Markdown

Please let us know if we need to do anything for this pullrequest

@bsardo bsardo added the adapter label Jul 14, 2025
@Ivan-Z-Oprx Ivan-Z-Oprx mentioned this pull request Jul 22, 2025
Merged
8 tasks
przemkaczmarek
przemkaczmarek reviewed Jul 24, 2025
View reviewed changes
Comment thread static/bidder-info/oprx.yaml
przemkaczmarek
przemkaczmarek reviewed Jul 24, 2025
View reviewed changes
Comment thread static/bidder-info/oprx.yaml
przemkaczmarek
przemkaczmarek reviewed Jul 24, 2025
View reviewed changes
Comment thread adapters/oprx/oprxtest/exemplary/banner.json
przemkaczmarek
przemkaczmarek reviewed Jul 24, 2025
View reviewed changes
Comment thread adapters/oprx/oprx.go Outdated
przemkaczmarek
przemkaczmarek reviewed Jul 24, 2025
View reviewed changes
Comment thread adapters/oprx/oprx.go Outdated
@przemkaczmarek przemkaczmarek changed the title New Adapter: oprx New Adapter: Oprx Jul 24, 2025
@przemkaczmarek przemkaczmarek self-assigned this Jul 24, 2025
github-actions[bot]
github-actions Bot reviewed Jul 25, 2025
View reviewed changes
Comment thread adapters/oprx/oprx.go
var bidExt openrtb_ext.ExtBid
err := jsonutil.Unmarshal(bid.Ext, &bidExt)
if err == nil && bidExt.Prebid != nil {
return openrtb_ext.ParseBidType(string(bidExt.Prebid.Type))

@github-actions github-actions Bot Jul 25, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

@github-actions

github-actions Bot commented Jul 25, 2025

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b855061

oprx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:26:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:42:	MakeBids		86.4%
github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:85:	getMediaTypeForBid	83.3%
total:								(statements)		85.7%

@github-actions

github-actions Bot commented Jul 28, 2025

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b639119

oprx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:26:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:42:	MakeBids		86.4%
github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:85:	getMediaTypeForBid	83.3%
total:								(statements)		85.7%

przemkaczmarek
przemkaczmarek previously approved these changes Jul 28, 2025
View reviewed changes
@przemkaczmarek przemkaczmarek self-requested a review July 28, 2025 14:23
pm-jaydeep-mohite
pm-jaydeep-mohite reviewed Jul 31, 2025
View reviewed changes
Comment thread static/bidder-params/oprx.json
Comment on lines +24 to +27
"bid_floor": {
"type": "number",
"description": "Bidding Price Floor"
},

@pm-jaydeep-mohite pm-jaydeep-mohite Jul 31, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this as bidder param ? ( as standard parameter imp.bidfloor is present)

@przemkaczmarek przemkaczmarek Sep 16, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ivan-Z-Oprx

@bsardo

bsardo commented Oct 22, 2025

Copy link
Copy Markdown
Collaborator

@Ivan-Z-Oprx please see most recent comment above.

bsardo
bsardo reviewed Jan 20, 2026
View reviewed changes
Comment thread static/bidder-params/oprx.json
Comment thread adapters/oprx/oprx.go Outdated
Comment thread adapters/oprx/oprx.go Outdated
@github-actions

github-actions Bot commented Feb 27, 2026

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f3d84e9

oprx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:26:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:42:	MakeBids		85.7%
github.com/prebid/prebid-server/v3/adapters/oprx/oprx.go:82:	getMediaTypeForBid	83.3%
total:								(statements)		85.3%

@Ivan-Z-Oprx Ivan-Z-Oprx mentioned this pull request Feb 27, 2026
Open
7 tasks
@bsardo

bsardo commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

@Ivan-Z-Oprx please resolve conflicts by merging with master.

@pm-jaydeep-mohite pm-jaydeep-mohite self-requested a review April 14, 2026 06:47
@bsardo

bsardo commented May 12, 2026

Copy link
Copy Markdown
Collaborator

@Ivan-Z-Oprx please resolve conflicts by merging with master.

1 similar comment
@przemkaczmarek

przemkaczmarek commented May 28, 2026

Copy link
Copy Markdown
Collaborator

@Ivan-Z-Oprx please resolve conflicts by merging with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsardo bsardo bsardo left review comments
@github-actions github-actions[bot] github-actions[bot] left review comments
@przemkaczmarek przemkaczmarek Awaiting requested review from przemkaczmarek
@pm-jaydeep-mohite pm-jaydeep-mohite Awaiting requested review from pm-jaydeep-mohite

At least 2 approving reviews are required to merge this pull request.

Assignees

@Pubmatic-Supriya-Patil Pubmatic-Supriya-Patil

@przemkaczmarek przemkaczmarek

Labels

adapter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Ivan-Z-Oprx @suruvu @bsardo @przemkaczmarek @pm-jaydeep-mohite @Pubmatic-Supriya-Patil