Skip to content

New Adapter: Scalibur#4640

Merged
bsardo merged 43 commits into
prebid:masterfrom
scalibur-io:scaliburA
Jun 2, 2026
Merged

New Adapter: Scalibur#4640
bsardo merged 43 commits into
prebid:masterfrom
scalibur-io:scaliburA

Conversation

@bTimor

@bTimor bTimor commented Dec 21, 2025

Copy link
Copy Markdown
Contributor

Type of change

  • New bidder adapter

Description

This PR adds the Scalibur bidder adapter to Prebid Server.

Features:

  • Supports Banner and Video media types.
  • Implements User Sync via iframe.
  • Automated tests include standard unit tests and JSON data-driven samples.

Verification:

  • End-to-end user sync flow verified using a private Scalibur sync server.
  • Successfully verified that PBS maps the uids cookie to user.buyeruid in outgoing requests.
  • All tests in adapters/scalibur passed.
  • Root ./validate.sh passed (ignoring unrelated global config/hook test timeouts).

Checklist

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

prebid/prebid.github.io#6381

Comment thread adapters/scalibur/scalibur.go Outdated
Comment thread adapters/scalibur/scalibur.go Outdated
@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a87ab09

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		93.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:170:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:257:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:282:	getBidMediaType		40.0%
total:									(statements)		82.7%

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c4e7220

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		86.2%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:186:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:273:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:298:	getBidMediaType		40.0%
total:									(statements)		79.4%

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 088c807

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		86.2%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:186:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:273:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:298:	getBidMediaType		40.0%
total:									(statements)		79.4%

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 60a0c74

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		86.2%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:186:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:273:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:298:	getBidMediaType		37.5%
total:									(statements)		78.4%

@bTimor

bTimor commented Dec 23, 2025

Copy link
Copy Markdown
Contributor Author

I've updated the media type logic to follow the recommended pattern and resolved the bot feedback. Ready for review and workflow approval.

Comment thread adapters/scalibur/scaliburtest/exemplary/success_banner.json
Comment thread adapters/scalibur/scalibur.go Outdated
Comment thread adapters/scalibur/scalibur.go
Comment thread adapters/scalibur/scalibur.go Outdated
Comment thread static/bidder-info/scalibur.yaml
Comment thread static/bidder-params/scalibur.json
Comment thread adapters/scalibur/scalibur.go Outdated
@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 09d4885

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:24:	Builder			71.4%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:40:	MakeRequests		84.7%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:196:	MakeBids		89.5%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:284:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:309:	getBidMediaType		50.0%
total:									(statements)		82.6%

@bTimor

bTimor commented Jan 12, 2026

Copy link
Copy Markdown
Contributor Author

@ccorbo
Updated the PR to address all feedback, including currency conversion, VAST extraction, and test file placement. Ready for another look.

Comment thread adapters/scalibur/scalibur.go Outdated
Comment thread adapters/scalibur/scalibur.go
Comment thread adapters/scalibur/scalibur.go
Comment thread adapters/scalibur/scalibur.go
Comment thread adapters/scalibur/scalibur.go
Comment thread adapters/scalibur/scalibur.go Outdated
Comment thread adapters/scalibur/scalibur.go Outdated
Comment thread static/bidder-info/scalibur.yaml
Comment thread static/bidder-info/scalibur.yaml
Comment thread static/bidder-info/scalibur.yaml
@bTimor bTimor dismissed stale reviews from ccorbo and danylo-kazymyrov-teqblaze via 218466e May 13, 2026 11:10
@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 218466e

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:24:	Builder			75.0%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:36:	MakeRequests		95.3%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:192:	MakeBids		92.1%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:284:	parseScaliburExt	85.7%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:303:	getBidMediaType		100.0%
total:									(statements)		93.7%

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 218466e

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:24:	Builder			75.0%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:36:	MakeRequests		95.3%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:192:	MakeBids		92.1%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:284:	parseScaliburExt	85.7%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:303:	getBidMediaType		100.0%
total:									(statements)		93.7%

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4e79921

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:24:	Builder			75.0%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:36:	MakeRequests		95.3%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:192:	MakeBids		92.1%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:284:	parseScaliburExt	85.7%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:303:	getBidMediaType		100.0%
total:									(statements)		93.7%

@bTimor

bTimor commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

@bsardo thanks for the response. I resolved all the requested issues and updated the branch with the last master.
Waiting for your approval and merge.

@bTimor

bTimor commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

@bsardo , @ccorbo , @danylo-kazymyrov-teqblaze any update?

ccorbo
ccorbo previously approved these changes May 20, 2026
@bTimor

bTimor commented May 23, 2026

Copy link
Copy Markdown
Contributor Author

@bsardo , @ccorbo , @danylo-kazymyrov-teqblaze, @pm-jaydeep-mohite this has become extremely urgent. I’ve spent a lot of extra time keeping the PR up to date and pinging you all, while no actual progress has been made. I now have a major client waiting on it.

Please let me know if there is someone else I should contact in order to get the PR merged.

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 90f1739

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:24:	Builder			75.0%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:36:	MakeRequests		95.3%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:192:	MakeBids		92.1%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:284:	parseScaliburExt	85.7%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:303:	getBidMediaType		100.0%
total:									(statements)		93.7%

@bTimor

bTimor commented May 24, 2026

Copy link
Copy Markdown
Contributor Author

@bsardo , @ccorbo , @danylo-kazymyrov-teqblaze , @pm-jaydeep-mohite , still needs 2 approvals and merge.

@bsardo bsardo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bTimor address the one comment and I will approve and get this merged.

Comment thread adapters/scalibur/scalibur.out Outdated
@bTimor

bTimor commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

@bsardo deleted the file.

@bTimor

bTimor commented May 31, 2026

Copy link
Copy Markdown
Contributor Author

@bsardo , @ccorbo , @danylo-kazymyrov-teqblaze , @pm-jaydeep-mohite. Resolve all comments. waiting for the merge.

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, e4832ea

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:24:	Builder			75.0%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:36:	MakeRequests		95.3%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:192:	MakeBids		92.1%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:284:	parseScaliburExt	85.7%
github.com/prebid/prebid-server/v4/adapters/scalibur/scalibur.go:303:	getBidMediaType		100.0%
total:									(statements)		93.7%

@bsardo bsardo changed the title New Bidder: Scalibur New Adapter: Scalibur Jun 2, 2026
@bsardo bsardo merged commit f0a0339 into prebid:master Jun 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants