Skip to content

Fixing inaccuracy regarding TTD adapter and HTTP/2 #6499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisHuie merged 6 commits into from
Apr 2, 2026
+21 −22
Merged

Fixing inaccuracy regarding TTD adapter and HTTP/2 #6499

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40785be
Fixing inaccuracy
robhazan Mar 24, 2026
d13df80
Removing useHttp2 flag
robhazan Mar 24, 2026
b46dc32
attempting to fix md linting issues
robhazan Mar 31, 2026
52848b3
Update ttd.md
assertiverich Apr 1, 2026
efdfbaa
Add bid parameters section to TTD documentation
patmmccann Apr 1, 2026
7a8db24
Update ttd.md
patmmccann Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions dev-docs/bidders/ttd.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,15 @@
fpd_supported: false
---

### Disclosure

Check failure on line 29 in dev-docs/bidders/ttd.md

View workflow job for this annotation

GitHub Actions / run markdownlint

Heading levels should only increment by one level at a time 

dev-docs/bidders/ttd.md:29 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: h2; Actual: h3] https://github.com/DavidAnson/markdownlint/blob/v0.40.0/doc/md001.md

This adapter is known to use an HTTP 1 endpoint. Header bidding often generates multiple requests to the same host and bidders are encouraged to change to HTTP 2 or above to help improve publisher page performance via multiplexing.

{: .alert.alert-danger :}
Note: The Trade Desk Header Bidding adapter requires setup and approval before beginning. Please reach out to <OpenPathPublishers@thetradedesk.com> for more details.

### Bid Params

{: .table .table-bordered .table-striped }
Name | Scope | Description | Example | Type

Check failure on line 37 in dev-docs/bidders/ttd.md

View workflow job for this annotation

GitHub Actions / run markdownlint

Tables should be surrounded by blank lines 

dev-docs/bidders/ttd.md:37 MD058/blanks-around-tables Tables should be surrounded by blank lines [Context: "Name | Scope | Description | E..."] https://github.com/DavidAnson/markdownlint/blob/v0.40.0/doc/md058.md
--- | --- | --- | --- | ----
`supplySourceId` | required | The TTD-provided supply source name. | `'supplier'` | `String`
`publisherId` | required | The publisher ID. If there is a sellers.json, this should be the same as the seller_id in the sellers.json for the site being trafficked. If there is no sellers.json, this should be hardcoded to "1". | `'1427ab10f2e448057ed3b422'` | `String`
Expand All @@ -44,14 +42,13 @@
`banner` | optional | Display banner targeting parameters. See the banner section below. | `{}` | `object`
`bidfloor` | optional | Sets a bid floor price | `0.95` | `Float`
`customBidderEndpoint` | optional | Only set if TTD has provided a custom endpoint. If set the custom endpoint will take precedent over the hard-coded endpoints | `https://customBidderEndpoint/bid/bidder/` | `String`
`useHttp2` | optional | When true, the adapter will use an endpoint that supports HTTP2. | `true` | `boolean`

@robin-crazygames robin-crazygames Mar 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why this line should be removed.
https://github.com/prebid/Prebid.js/blob/1d8b5fe28c16b1965252839e27fcb9a9afc15312/modules/ttdBidAdapter.js#L284 still switches to a different endpoint when you set that param to true

@robhazan robhazan Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robin-crazygames All of our endpoints support HTTP/2 now. So we no longer need to send traffic to some special endpoint for that. We don't want to break backwards compatibility for anyone who may be using this flag, but have no need for it anymore. So we figure just remove it from docs so nobody net new starts using it.

@robin-crazygames robin-crazygames Mar 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation

@robin-crazygames robin-crazygames Apr 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: prebid/Prebid.js#14665


### Banner Object

The following banner parameters are supported:

{: .table .table-bordered .table-striped }
Name | Scope | Description | Example | Type

Check failure on line 51 in dev-docs/bidders/ttd.md

View workflow job for this annotation

GitHub Actions / run markdownlint

Tables should be surrounded by blank lines 

dev-docs/bidders/ttd.md:51 MD058/blanks-around-tables Tables should be surrounded by blank lines [Context: "Name | Scope | Description | E..."] https://github.com/DavidAnson/markdownlint/blob/v0.40.0/doc/md058.md
--- | --- | --- | --- | ----
`expdir` | optional | Directions in which the banner may expand. See "Expandable Direction" in the [OpenRTB 2.5 docs](https://www.iab.com/wp-content/uploads/2016/03/OpenRTB-API-Specification-Version-2-5-FINAL.pdf) for possible values. | `[1, 3]` | `Array[integer]`

Expand Down
Loading