Remove pbadslot and customPbAdSlot from GPT Pre-Auction docs#6612
Remove pbadslot and customPbAdSlot from GPT Pre-Auction docs#6612patmmccann wants to merge 1 commit into
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 047818b49d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 1. Otherwise, if a customPreAuction function is specified, run that. If the result isn't empty, place it in GPID. | ||
| 1. Otherwise, if useDefaultPreAuction is true, run the default logic and place the return value in GPID: |
There was a problem hiding this comment.
With a customPreAuction function configured, the module calls that function and does not fall through to useDefaultPreAuction when it returns an empty value, even though useDefaultPreAuction now defaults to true. As written, publishers can reasonably expect ad units where their custom function returns undefined to still get the default GPID, but those ad units will be left without one unless the custom function supplies it.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Do you have this information from the prebid.js source code? If so, point to the exact location where this behaviour is implemented.
2 participants
Fixes #6435
Motivation
pbadslot/customPbAdSlotsupport has been removed from Prebid.js and the module now focuses on GPID population.Description
pbadslotand thecustomPbAdSlotexample and replaced them with GPID-focused wording and guidance.useDefaultPreAuction(defaulting totrue) and thecustomPreAuction(adUnit, adServerAdSlot, gptAdUnitPath)signature.customPreAuctionsample usinggptAdUnitPath./features/pbAdSlot.html#the-gpid).Testing
markdownlint-clivianpmand ranmarkdownlint --config .markdownlint.json dev-docs/modules/gpt-pre-auction.md, and linting passed for the edited file.bundle installto ensure Jekyll dependencies were available and then ranbundle exec jekyll build, and the site built successfully without errors for the modified content.Codex Task