Skip to content

Minor fixes in MicroManager regarding Adaptivity#273

Merged
Snapex2409 merged 1 commit into
developfrom
mm-ada-fix
May 21, 2026
Merged

Minor fixes in MicroManager regarding Adaptivity#273
Snapex2409 merged 1 commit into
developfrom
mm-ada-fix

Conversation

@Snapex2409
Copy link
Copy Markdown
Collaborator

@Snapex2409 Snapex2409 commented May 20, 2026

Some variable in the MicroManager were named incorrectly.
Switched gid to lid.

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@Snapex2409 Snapex2409 marked this pull request as ready for review May 20, 2026 12:31
@Snapex2409 Snapex2409 requested a review from IshaanDesai May 20, 2026 12:31
Copy link
Copy Markdown
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check the underlying model adaptivity functionality but I assume that it now works with local IDs instead of global IDs.

# Conflicts:
#	CHANGELOG.md
@Snapex2409
Copy link
Copy Markdown
Collaborator Author

Model Adaptivity used LIDs also previously. Here, the main changes were renamings. The variables were just named incorrectly. Only in the "first" change were GIDs used (incorrectly).

@Snapex2409 Snapex2409 merged commit bedd534 into develop May 21, 2026
10 checks passed
@Snapex2409 Snapex2409 deleted the mm-ada-fix branch May 21, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants