Skip to content

Not checkpointing non-geometric fields#367

Closed
vidulejs wants to merge 18 commits into
developfrom
324-not-checkpointing-non-geometric-fields
Closed

Not checkpointing non-geometric fields#367
vidulejs wants to merge 18 commits into
developfrom
324-not-checkpointing-non-geometric-fields

Conversation

@vidulejs
Copy link
Copy Markdown
Collaborator

@vidulejs vidulejs commented May 20, 2025

Note: This Pull Request has been superseded and is now closed.
The work originally done in this PR has been cleaned up and split into two new PRs which solve two different issues.

Main changes

  • Fixed meshOldPoints checkpointing. Previously mesh would move from incorrect interim state to meshPoints, instead of meshOldPoints (leads to incorrect mesh flux).
  • Removed comments and vectors to mesh fields which don't exist
  • Mesh volume checkpointing (needed for higher order time derivative schemes)

@vidulejs vidulejs linked an issue May 20, 2025 that may be closed by this pull request
21 tasks
@vidulejs vidulejs changed the title 324 not checkpointing non geometric fields Fix mesh oldPoints, volumes checkpointing May 30, 2025
@precice-bot
Copy link
Copy Markdown

This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/coupling-problem-about-in-house-openfoam-solver-with-calculix-by-precice/1125/6

@vidulejs vidulejs changed the title Fix mesh oldPoints, volumes checkpointing Not checkpointing non-geometric fields Jul 10, 2025
@vidulejs
Copy link
Copy Markdown
Collaborator Author

Closing this draft pull request in favor of two cleaner PRs.

This branch became a long-running experiment for both mesh checkpointing and an
FSI subcycling bugfix. To make the review process clearer and more manageable, I
have split the work into two separate, clean pull requests:

  1. Mesh points & volumes checkpointing #369: This PR contains the complete,
    consolidated history for the mesh and volume checkpointing feature.
  2. FSI implicit subcycling fix #370: This PR builds on the checkpointing branch
    to fix a bug in how readCouplingData handles time during implicit subcycling steps.

@vidulejs vidulejs closed this Jul 11, 2025
@vidulejs vidulejs deleted the 324-not-checkpointing-non-geometric-fields branch July 11, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not checkpointing non-geometric fields

2 participants