Skip to content

Commit 17bc4a5

Browse files
authored
Make system tests output filenames more descriptive (#776)
Rename `stdout.log` to `system-tests-stdout.log` and `stderr.log` to `system-tests-stderr.log`.
1 parent 5e651ca commit 17bc4a5

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

tools/tests/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Workflow for the preCICE v3 release testing:
3636

3737
6. Download the build artifacts from Summary > runs.
3838

39-
- In there, you may want to check the `stdout.log` and `stderr.log` files.
39+
- In there, you may want to check the `system-tests-stdout.log` and `system-tests-stderr.log` files.
4040
- The produced results are in `precice-exports/`, the reference results in `reference-results-unpacked`.
4141
- Compare using, e.g., ParaView or [fieldcompare](https://gitlab.com/dglaeser/fieldcompare): `fieldcompare dir precice-exports/ reference/`. The `--diff` option will give you `precice-exports/diff_*.vtu` files, while you can also try different tolerances with `-rtol` and `-atol`.
4242

tools/tests/systemtests/Systemtest.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def _get_length_of_name(results: List[SystemtestResult]) -> int:
117117
with open(os.environ["GITHUB_STEP_SUMMARY"], "a") as f:
118118
print("\n\n", file=f)
119119
print(
120-
"In case a test fails, download the archive from the bottom of this page and look into each `stdout.log` and `stderr.log`. The time spent in each step might already give useful hints.",
120+
"In case a test fails, download the archive from the bottom of this page and look into each `system-tests-stdout.log` and `system-tests-stderr.log`. The time spent in each step might already give useful hints.",
121121
file=f)
122122
print(
123123
"See the [documentation](https://precice.org/dev-docs-system-tests.html#understanding-what-went-wrong).",
@@ -543,9 +543,9 @@ def __repr__(self):
543543
return f"{self.tutorial.name} {self.case_combination}"
544544

545545
def __write_logs(self, stdout_data: List[str], stderr_data: List[str]):
546-
with open(self.system_test_dir / "stdout.log", 'w') as stdout_file:
546+
with open(self.system_test_dir / "system-tests-stdout.log", 'w') as stdout_file:
547547
stdout_file.write("\n".join(stdout_data))
548-
with open(self.system_test_dir / "stderr.log", 'w') as stderr_file:
548+
with open(self.system_test_dir / "system-tests-stderr.log", 'w') as stderr_file:
549549
stderr_file.write("\n".join(stderr_data))
550550

551551
def __apply_max_time_override(self):

0 commit comments

Comments
 (0)